Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow debug mode to toggle #108

Open
andrewpbray opened this issue Oct 23, 2024 · 2 comments
Open

allow debug mode to toggle #108

andrewpbray opened this issue Oct 23, 2024 · 2 comments

Comments

@andrewpbray
Copy link
Contributor

andrewpbray commented Oct 23, 2024

@jimjam-slam What are your thoughts about expanding debug-mode to allow

  • debug: false (the default)
  • debug: toggle (on keypress would toggle on or off)
  • debug-mode: true permanently puts on the debug class

?

Is "debug-mode" the right name for this? You can also imagine it as "author-view" or something. We could also add the values that the ojs variables take.

@jimjam-slam
Copy link
Collaborator

I'd be happy with the three values! I'd also love to include the OJS variables (we already have them on a few demos)... I'm not 100% sure whether the OJS engine is initialised if the user isn't using OJS, but if it's being a debug flag, I'm not too stressed about forcing it to be initialised.

@jimjam-slam
Copy link
Collaborator

No strong view on the name!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants