Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minard demo too narrow without .page-columns.page-full all the way up #121

Closed
jimjam-slam opened this issue Nov 1, 2024 · 3 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@jimjam-slam
Copy link
Collaborator

jimjam-slam commented Nov 1, 2024

I picked up a problem with the Minard scroll while recording our videos — it seems that in issue #81 (PR #82), we do indeed need to propagate .page-columns.page-full all the way up to main. Minard is a case where we don't (only on the direct parent section), and it causes the full grid to "sandwich" into the page column.

I think I can probably revert that to going all the way up today and put out a quick bug fix release 1.0.1 if that's okay with you, @andrewpbray!

@jimjam-slam jimjam-slam added the bug Something isn't working label Nov 1, 2024
@jimjam-slam jimjam-slam self-assigned this Nov 1, 2024
@jimjam-slam
Copy link
Collaborator Author

I think we just need to revert c9c6a9b for this.

jimjam-slam pushed a commit that referenced this issue Nov 1, 2024
@jimjam-slam
Copy link
Collaborator Author

I'm not sure who pointed this AI at our repo... #122 does not solve the issue at hand, and it edits our generated CSS, not the source SCSS file.

it did, however, pick up a separate issue in our .sidebar-right layout! I'll fold that into #123 (which is my PR).

@jimjam-slam
Copy link
Collaborator Author

Fixed in #123!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants
@jimjam-slam and others