Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove trigger markup for non-scrolly formats #147

Open
andrewpbray opened this issue Nov 20, 2024 · 2 comments
Open

remove trigger markup for non-scrolly formats #147

andrewpbray opened this issue Nov 20, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@andrewpbray
Copy link
Contributor

It'd be nice if a closeread doc could "fail gracefully" when rendered to a different format like pdf or html. Right now it does so fairly well with the exception of the @cr-mysticky which remain visible in the narrative blocks after rendering. A few options:

  1. Appeal to Quarto devs to add cr- as a protected prefix. Then we could have Quarto scrub them.
  2. Switch closeread to a filter that could be run even on different formats. When run on those formats, all it'd run is a trigger scrubber.
  3. Add options to closeread-html to also produce an alternate (non-scrolly) format.
@andrewpbray andrewpbray added the enhancement New feature or request label Nov 20, 2024
@andrewpbray andrewpbray changed the title remove trigger syntax remove trigger markup for non-scrolly formats Nov 20, 2024
@jimjam-slam
Copy link
Collaborator

Mmmm, good idea! I still love the idea of getting Closeread all the way down to a filter, but I can't remember now what our blocker on that was.

@andrewpbray
Copy link
Contributor Author

Haha, I was trying to remember why we decided to hold off on the filter for now and ... I really couldn't remember our rationale for sticking with a format for the time being!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants