-nofullscreen does not work on XP in True Color mode

[pphaneuf]

No description provided.

[pphaneuf]

What steps will reproduce the problem?

1. Be in a True Color graphics mode on Windows XP
2. Run quadra with the -nofullscreen flag on the command line

What is the expected output? What do you see instead?

I expected Quadra to run in a window. Instead, it ran fullscreen like
usual. At the very least, it seems like it ought to pop up a dialog box
explaining why it can't do -nofullscreen rather than going on to start
fullscreen anyway.

Actually, what I really expected was that Quadra would have a menu option
somewhere to switch between window/fullscreen, but then maybe it does in
more favorable circumstances.

What version of the product are you using? On what operating system?

Quadra 1.2.0 on Windows XP Professional SP3.

Please provide any additional information below.

I expect the same thing happens in anything other than 256-color mode, but
lack the patience to try it in High Color mode. For all I know it doesn't
work in 256-color mode either; it's not very easy to switch to that on
Windows XP since it is not one of the choices provided by the UI.

[pphaneuf]

Heh, I wasn't even aware that the windowed mode stuff actually did anything on Windows (I coded this up for X
Window on Linux). The version in Subversion's trunk uses libSDL, and I believe would work as you expect on
Windows.

The way the command-line flags are handled is a little bit weird, and doesn't easily lend itself to validation at
startup as it is at the moment (not that there's a good reason for how it is, just explaining why there's no
validation now).