Replace StringBuffer with StringBuilder where possible

quaff · quaff · commit 7e6c4da8f3d6 · 2020-09-03T15:09:30.000+08:00
diff --git a/spring-aop/src/test/java/org/springframework/aop/interceptor/CustomizableTraceInterceptorTests.java b/spring-aop/src/test/java/org/springframework/aop/interceptor/CustomizableTraceInterceptorTests.java
@@ -143,13 +143,13 @@ public void testSunnyDayPathLogsCorrectlyWithPrettyMuchAllPlaceholdersMatching()
 		given(log.isTraceEnabled()).willReturn(true);
 
 		CustomizableTraceInterceptor interceptor = new StubCustomizableTraceInterceptor(log);
-		interceptor.setEnterMessage(new StringBuffer()
+		interceptor.setEnterMessage(new StringBuilder()
 			.append("Entering the '").append(CustomizableTraceInterceptor.PLACEHOLDER_METHOD_NAME)
 			.append("' method of the [").append(CustomizableTraceInterceptor.PLACEHOLDER_TARGET_CLASS_NAME)
 			.append("] class with the following args (").append(CustomizableTraceInterceptor.PLACEHOLDER_ARGUMENTS)
 			.append(") and arg types (").append(CustomizableTraceInterceptor.PLACEHOLDER_ARGUMENT_TYPES)
 			.append(").").toString());
-		interceptor.setExitMessage(new StringBuffer()
+		interceptor.setExitMessage(new StringBuilder()
 			.append("Exiting the '").append(CustomizableTraceInterceptor.PLACEHOLDER_METHOD_NAME)
 			.append("' method of the [").append(CustomizableTraceInterceptor.PLACEHOLDER_TARGET_CLASS_SHORT_NAME)
 			.append("] class with the following args (").append(CustomizableTraceInterceptor.PLACEHOLDER_ARGUMENTS)
diff --git a/spring-context/src/test/java/org/springframework/beans/factory/xml/XmlBeanFactoryTestTypes.java b/spring-context/src/test/java/org/springframework/beans/factory/xml/XmlBeanFactoryTestTypes.java
@@ -589,7 +589,7 @@ class ReverseMethodReplacer implements MethodReplacer, Serializable {
 	@Override
 	public Object reimplement(Object obj, Method method, Object[] args) throws Throwable {
 		String s = (String) args[0];
-		return new StringBuffer(s).reverse().toString();
+		return new StringBuilder(s).reverse().toString();
 	}
 }
 
diff --git a/spring-context/src/test/java/org/springframework/beans/factory/xml/XmlBeanFactoryTests.java b/spring-context/src/test/java/org/springframework/beans/factory/xml/XmlBeanFactoryTests.java
@@ -1324,7 +1324,7 @@ void replaceMethodOverrideWithSetterInjection() {
 
 		// Now test replace
 		String s = "this is not a palindrome";
-		String reverse = new StringBuffer(s).reverse().toString();
+		String reverse = new StringBuilder(s).reverse().toString();
 		assertThat(oom.replaceMe(s)).as("Should have overridden to reverse, not echo").isEqualTo(reverse);
 
 		assertThat(oom.replaceMe()).as("Should have overridden no-arg overloaded replaceMe method to return fixed value").isEqualTo(FixedMethodReplacer.VALUE);
@@ -1380,7 +1380,7 @@ void serializableMethodReplacerAndSuperclass() throws IOException {
 		reader.loadBeanDefinitions(DELEGATION_OVERRIDES_CONTEXT);
 		SerializableMethodReplacerCandidate s = (SerializableMethodReplacerCandidate) xbf.getBean("serializableReplacer");
 		String forwards = "this is forwards";
-		String backwards = new StringBuffer(forwards).reverse().toString();
+		String backwards = new StringBuilder(forwards).reverse().toString();
 		assertThat(s.replaceMe(forwards)).isEqualTo(backwards);
 		// SPR-356: lookup methods & method replacers are not serializable.
 		assertThat(SerializationTestUtils.isSerializable(s)).as("Lookup methods and method replacers are not meant to be serializable.").isFalse();
diff --git a/spring-context/src/test/java/org/springframework/scripting/MessengerScrambler.java b/spring-context/src/test/java/org/springframework/scripting/MessengerScrambler.java
@@ -28,7 +28,7 @@ public class MessengerScrambler {
 
 	public String scramble(ProceedingJoinPoint pjp) throws Throwable {
 		String message = (String) pjp.proceed();
-		return new StringBuffer(message).reverse().toString();
+		return new StringBuilder(message).reverse().toString();
 	}
 
 }
diff --git a/spring-core/src/main/java/org/springframework/cglib/core/ReflectUtils.java b/spring-core/src/main/java/org/springframework/cglib/core/ReflectUtils.java
@@ -260,7 +260,7 @@ private static Class getClass(String className, ClassLoader loader, String[] pac
 		while ((index = className.indexOf("[]", index) + 1) > 0) {
 			dimensions++;
 		}
-		StringBuffer brackets = new StringBuffer(className.length() - dimensions);
+		StringBuilder brackets = new StringBuilder(className.length() - dimensions);
 		for (int i = 0; i < dimensions; i++) {
 			brackets.append('[');
 		}

Original file line number	Diff line number	Diff line change
`@@ -589,7 +589,7 @@ class ReverseMethodReplacer implements MethodReplacer, Serializable {`
`589`	`589`	`@Override`
`590`	`590`	`public Object reimplement(Object obj, Method method, Object[] args) throws Throwable {`
`591`	`591`	`String s = (String) args[0];`
`592`		`- return new StringBuffer(s).reverse().toString();`
	`592`	`+ return new StringBuilder(s).reverse().toString();`
`593`	`593`	`}`
`594`	`594`	`}`
`595`	`595`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ public class MessengerScrambler {`
`28`	`28`
`29`	`29`	`public String scramble(ProceedingJoinPoint pjp) throws Throwable {`
`30`	`30`	`String message = (String) pjp.proceed();`
`31`		`- return new StringBuffer(message).reverse().toString();`
	`31`	`+ return new StringBuilder(message).reverse().toString();`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`}`
Original file line number	Diff line number	Diff line change
`@@ -260,7 +260,7 @@ private static Class getClass(String className, ClassLoader loader, String[] pac`
`260`	`260`	`while ((index = className.indexOf("[]", index) + 1) > 0) {`
`261`	`261`	`dimensions++;`
`262`	`262`	`}`
`263`		`- StringBuffer brackets = new StringBuffer(className.length() - dimensions);`
	`263`	`+ StringBuilder brackets = new StringBuilder(className.length() - dimensions);`
`264`	`264`	`for (int i = 0; i < dimensions; i++) {`
`265`	`265`	`brackets.append('[');`
`266`	`266`	`}`