Nightly tests are failing

[anurudhp]

https://github.com/quantumlib/Qualtran/actions/runs/12927816318 (jan 23)

cc @NoureldinYosri looks like the mod-sub classical action test is failing after #1518

[NoureldinYosri]

the tests pass locally

$ pytest qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py -k modsub_classical_action -v
qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_modsub_classical_action[13-4-QUInt] PASSED                                                                                                                                                                                                     [  3%]
qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_modsub_classical_action[13-4-QMontgomeryUInt] PASSED                                                                                                                                                                                           [  6%]
qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_modsub_classical_action[13-5-QUInt] PASSED                                                                                                                                                                                                     [ 10%]
qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_modsub_classical_action[13-5-QMontgomeryUInt] PASSED                                                                                                                                                                                           [ 13%]
qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_modsub_classical_action[17-5-QUInt] PASSED                                                                                                                                                                                                     [ 16%]
qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_modsub_classical_action[17-5-QMontgomeryUInt] PASSED                                                                                                                                                                                           [ 20%]
qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_modsub_classical_action[23-5-QUInt] PASSED                                                                                                                                                                                                     [ 23%]
qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_modsub_classical_action[23-5-QMontgomeryUInt] PASSED                                                                                                                                                                                           [ 26%]
qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_modsub_classical_action_large[32-1000000007] PASSED                                                                                                                                                                                            [ 30%]
qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_modsub_classical_action_large[32-1000000009] PASSED                                                                                                                                                                                            [ 33%]
qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_modsub_classical_action_large[33-1000000007] PASSED                                                                                                                                                                                            [ 36%]
qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_modsub_classical_action_large[33-1000000009] PASSED                                                                                                                                                                                            [ 40%]
qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_modsub_classical_action_fast PASSED                                                                                                                                                                                                            [ 43%]
qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_cmodsub_classical_action[13-4-QUInt-0] PASSED                                                                                                                                                                                                  [ 46%]
qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_cmodsub_classical_action[13-4-QUInt-1] PASSED                                                                                                                                                                                                  [ 50%]
qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_cmodsub_classical_action[13-4-QMontgomeryUInt-0] PASSED                                                                                                                                                                                        [ 53%]
qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_cmodsub_classical_action[13-4-QMontgomeryUInt-1] PASSED                                                                                                                                                                                        [ 56%]
qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_cmodsub_classical_action[13-5-QUInt-0] PASSED                                                                                                                                                                                                  [ 60%]
qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_cmodsub_classical_action[13-5-QUInt-1] PASSED                                                                                                                                                                                                  [ 63%]
qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_cmodsub_classical_action[13-5-QMontgomeryUInt-0] PASSED                                                                                                                                                                                        [ 66%]
qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_cmodsub_classical_action[13-5-QMontgomeryUInt-1] PASSED                                                                                                                                                                                        [ 70%]
qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_cmodsub_classical_action[17-5-QUInt-0] PASSED                                                                                                                                                                                                  [ 73%]
qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_cmodsub_classical_action[17-5-QUInt-1] PASSED                                                                                                                                                                                                  [ 76%]
qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_cmodsub_classical_action[17-5-QMontgomeryUInt-0] PASSED                                                                                                                                                                                        [ 80%]
qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_cmodsub_classical_action[17-5-QMontgomeryUInt-1] PASSED                                                                                                                                                                                        [ 83%]
qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_cmodsub_classical_action_large[32-1000000007] PASSED                                                                                                                                                                                           [ 86%]
qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_cmodsub_classical_action_large[32-1000000009] PASSED                                                                                                                                                                                           [ 90%]
qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_cmodsub_classical_action_large[33-1000000007] PASSED                                                                                                                                                                                           [ 93%]
qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_cmodsub_classical_action_large[33-1000000009] PASSED                                                                                                                                                                                           [ 96%]
qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_cmodsub_classical_action_fast PASSED                                                                                                                                                                                                           [100%]

================================================================================================================================= 30 passed, 402 deselected in 116.37s (0:01:56) =================================================================================================================================

and they don't call the bloqs with those inputs ... their input range is range(prime)

Qualtran/qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py

Lines 173 to 174 in 123b83a

	for x, y in itertools.product(range(prime), repeat=2):
	assert b.call_classically(x=x, y=y) == cb.call_classically(x=x, y=y) == (x, (y - x) % prime)

but the error says they called with x=prime

FAILED qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_modsub_classical_action[13-4-QUInt] - ValueError: x=13 is outside the valid interval for modular addition [0, 13)
FAILED qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_modsub_classical_action[13-4-QMontgomeryUInt] - ValueError: x=13 is outside the valid interval for modular addition [0, 13)
FAILED qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_modsub_classical_action[13-5-QUInt] - ValueError: x=13 is outside the valid interval for modular addition [0, 13)
FAILED qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_modsub_classical_action[13-5-QMontgomeryUInt] - ValueError: x=13 is outside the valid interval for modular addition [0, 13)
FAILED qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_modsub_classical_action[17-5-QUInt] - ValueError: x=17 is outside the valid interval for modular addition [0, 17)
FAILED qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_modsub_classical_action[17-5-QMontgomeryUInt] - ValueError: x=17 is outside the valid interval for modular addition [0, 17)
FAILED qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_modsub_classical_action[23-5-QUInt] - ValueError: x=23 is outside the valid interval for modular addition [0, 23)
FAILED qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_modsub_classical_action[23-5-QMontgomeryUInt] - ValueError: x=23 is outside the valid interval for modular addition [0, 23)
FAILED qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_cmodsub_classical_action[13-4-QUInt-0] - ValueError: x=13 is outside the valid interval for modular addition [0, 13)
FAILED qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_cmodsub_classical_action[13-4-QUInt-1] - ValueError: x=13 is outside the valid interval for modular addition [0, 13)
FAILED qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_cmodsub_classical_action[13-4-QMontgomeryUInt-0] - ValueError: x=13 is outside the valid interval for modular addition [0, 13)
FAILED qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_cmodsub_classical_action[13-4-QMontgomeryUInt-1] - ValueError: x=13 is outside the valid interval for modular addition [0, 13)
FAILED qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_cmodsub_classical_action[13-5-QUInt-0] - ValueError: x=13 is outside the valid interval for modular addition [0, 13)
FAILED qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_cmodsub_classical_action[13-5-QUInt-1] - ValueError: x=13 is outside the valid interval for modular addition [0, 13)
FAILED qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_cmodsub_classical_action[13-5-QMontgomeryUInt-0] - ValueError: x=13 is outside the valid interval for modular addition [0, 13)
FAILED qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_cmodsub_classical_action[13-5-QMontgomeryUInt-1] - ValueError: x=13 is outside the valid interval for modular addition [0, 13)
FAILED qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_cmodsub_classical_action[17-5-QUInt-0] - ValueError: x=17 is outside the valid interval for modular addition [0, 17)
FAILED qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_cmodsub_classical_action[17-5-QUInt-1] - ValueError: x=17 is outside the valid interval for modular addition [0, 17)
FAILED qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_cmodsub_classical_action[17-5-QMontgomeryUInt-0] - ValueError: x=17 is outside the valid interval for modular addition [0, 17)
FAILED qualtran/bloqs/mod_arithmetic/mod_subtraction_test.py::test_cmodsub_classical_action[17-5-QMontgomeryUInt-1] - ValueError: x=17 is outside the valid interval for modular addition [0, 17)

---

something is weired with the nightly run

[mpharrigan]

fwiw the tests fail for me if I run check/pytest

[mpharrigan]

and they don't call the bloqs with those inputs ... their input range is range(prime)

The error arises when calling via the decomposition. x=0 gets turned into x=13 in the call to ModAdd

[NoureldinYosri]

yup. looks like when I ran the tests locally I had an old version of the repo somehow. This fixes it #1537