-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Errformat to ReviewDog #33
Comments
I'll look into that, thanks. PRs are welcome, by the way. |
@quasilyte I would like to have this feature too and created a pull request there. It doesn't accept error string (only error code) but I think it's good enough for now :) |
@quasilyte Sorry, if possible, I would like to have your review for this PR: |
@jlwt90, sorry for the late response, I had hard times finding a free time. Your PR (although already merged) looks good to me. Thank you. |
I believe we can close this issue now. |
@quasilyte No problem! Thank you for your review! 🙇 |
Currently it seems that Reviewdog doesn't support
go-consistent
.Here is the error that Reviewdog spews out:
While it is possible to workaround this by defining a custom error format for Reviewdog, this is error-prone since whenever the output of the tool changes Reviewdog will fail to parse the output.
For the same reason I think any non-maintainer that tries to make a PR to Reviewdog for adding error format for
go-consistent
will run into the same concern.I hope the maintainers of
go-consistent
will consider this!The text was updated successfully, but these errors were encountered: