panc: Deprecated should always return boolean true #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrha
force-pushed
the
deprecated_true
branch
3 times, most recently
from
daddb31 to
71d04a2
Compare
This allows us to start removing the hundreds of instances of `... with {deprecated(...); true;}` in the schema.
It's not clear why it ever returned undef, but it appears to have been this way since the original rewrite in Java and looks like it was originally default boilerplate for new functions.
The documentation and comments claim it should be returning the string passed to it, but this has never been the case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to start removing the hundreds of instances of
... with {deprecated(...); true;}in the schema.It's not clear why it ever returned
undef, but it appears to have been this way since the original rewrite in Java and looks like it was originally default boilerplate for new functions.The documentation and comments claim it should be returning the string passed to it, but this has never been the case.
Resolves #243.