Skip to content

Incorrect Classification of CustomSiLU as Binary Operator in _AIMET_V1_BINARY_MODULES #3898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kenanking opened this issue Mar 11, 2025 · 1 comment

Comments

@kenanking
Copy link

kenanking commented Mar 11, 2025

The custom.CustomSiLU operator appears to be incorrectly classified as a binary operator in the _AIMET_V1_BINARY_MODULES list (line 752), which is causing quantization to fail.

SiLU (Sigmoid Linear Unit) is an activation function defined as f(x) = x * sigmoid(x), which operates on a single input tensor. This is a unary operation, not a binary one. I think it's an accidental mistake.

_AIMET_V1_BINARY_MODULES = [
    custom.MatMul,
    custom.Add,
    custom.Multiply,
    # ... other binary operators ...
    custom.CustomSiLU,  # <-- This appears to be incorrectly classified
    custom.Maximum,
    # ... other operators ...
]

@My-captain
Copy link

same issue when quantize ovis2, anyone could confirm and correct it in sdk?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants