Used UAPI kernel headers instead of using a copy #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quic-bkumar
reviewed
May 27, 2024
README.md
Outdated
| git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git | ||
| cd linux/ | ||
| make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- defconfig | ||
| make headers_install INSTALL_HDR_PATH=<Path to install headers> |
Contributor
There was a problem hiding this comment.
use , also can you move this just below "Build and installation" and call it as "pre-requisites" for build and install.
quic-bkumar
reviewed
May 27, 2024
configure.ac
Outdated
| if test -d "$HEADER_PATH"; then | ||
| AC_MSG_RESULT([Header found]) | ||
| else | ||
| AC_MSG_ERROR([Header directory $HEADER_PATH not found]) |
Contributor
There was a problem hiding this comment.
Use "Linux kernel headers not found in #HEADER_PATH"
quic-bkumar
reviewed
May 27, 2024
configure.ac
Outdated
| AC_ARG_WITH([kernel_header], [AS_HELP_STRING([--with-kernel_header=PATH], [Specify path to the header])], [HEADER_PATH="$withval"],[AC_MSG_ERROR([Header path is required])]) | ||
| # Checking if the header path is valid | ||
| if test -d "$HEADER_PATH"; then | ||
| AC_MSG_RESULT([Header found]) |
Contributor
There was a problem hiding this comment.
Use "Linux kernel header found"
Signed-off-by: Gettiboina Chanikya Prakash <[email protected]>
lumag
suggested changes
Apr 23, 2025
| git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git | ||
| cd linux/ | ||
| make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- defconfig | ||
| make headers_install INSTALL_HDR_PATH=<Path to install headers> |
Contributor
There was a problem hiding this comment.
Why is this necessary? Corresponding headers should be a part of the kernel-headers packages being installed as a libc-dev dependency. If not, you should not be depending on them.
|
This pull request has been marked as stale due to 60 days of inactivity. To prevent automatic closure in 10 days, remove the stale label or add a comment. You can reopen a closed pull request at any time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.