@hadley PTAL at this repo's current GHA set-up. We recently updated lint-changed-files so that the action fails if new lints are detected. That's working pretty well for us:

lintr/.github/workflows/lint-changed-files.yaml

Lines 33 to 39 in bed54c5

    
                   run: | 
        
                     Sys.setenv("LINTR_ERROR_ON_LINT" = TRUE) 
        
                     files <- gh::gh("GET https://api.github.com/repos/r-lib/lintr/pulls/${{ github.event.pull_request.number }}/files") 
        
                     changed_files <- purrr::map_chr(files, "filename") 
        
                     all_files <- list.files(recursive = TRUE) 
        
                     exclusions_list <- as.list(setdiff(all_files, changed_files)) 
        
                     lintr::lint_package(exclusions = exclusions_list)

Please help to close if you agree that's a good approach

	run: \|
	Sys.setenv("LINTR_ERROR_ON_LINT" = TRUE)
	files <- gh::gh("GET https://api.github.com/repos/r-lib/lintr/pulls/${{ github.event.pull_request.number }}/files")
	changed_files <- purrr::map_chr(files, "filename")
	all_files <- list.files(recursive = TRUE)
	exclusions_list <- as.list(setdiff(all_files, changed_files))
	lintr::lint_package(exclusions = exclusions_list)

Should lint_package() error on CI? #1226

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Should `lint_package()` error on CI? #1226