diff --git a/DESCRIPTION b/DESCRIPTION index c1f7a8b..ccd7d4e 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,6 +1,6 @@ Package: rcmdcheck Title: Run 'R CMD check' from 'R' and Capture Results -Version: 1.4.0.9000 +Version: 1.4.0.9001 Authors@R: c( person("Gábor", "Csárdi", , "csardi.gabor@gmail.com", role = c("cre", "aut")), person("Mango Solutions", role = c("cph", "fnd")), @@ -42,4 +42,4 @@ Config/Needs/website: tidyverse/tidytemplate Config/testthat/edition: 3 Encoding: UTF-8 Roxygen: list(markdown = TRUE) -RoxygenNote: 7.2.1 +RoxygenNote: 7.3.2 diff --git a/NAMESPACE b/NAMESPACE index 045e85d..329c61e 100644 --- a/NAMESPACE +++ b/NAMESPACE @@ -43,4 +43,5 @@ importFrom(utils,tail) importFrom(withr,local_path) importFrom(withr,with_dir) importFrom(withr,with_envvar) +importFrom(withr,with_libpaths) importFrom(xopen,xopen) diff --git a/NEWS.md b/NEWS.md index 7535603..68f970e 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,4 +1,3 @@ - # rcmdcheck (development version) * Fixed an issue where check output could be malformed when testing @@ -6,6 +5,9 @@ * Update pkgdown template and move url to https://rcmdcheck.r-lib.org. +* Fixed and issue where `rcmdcheck_process$new()` could fail the setup stage + due to `libpath` not being used by the build sub process. (#230, @maksymiuks) + # rcmdcheck 1.4.0 * `cran_check_results()` now downloads results in parallel, so it is diff --git a/R/build.R b/R/build.R index 630ed86..6616bc4 100644 --- a/R/build.R +++ b/R/build.R @@ -1,6 +1,6 @@ #' @importFrom pkgbuild pkgbuild_process -#' @importFrom withr with_envvar +#' @importFrom withr with_libpaths build_package <- function(path, tmpdir, build_args, libpath, quiet) { path <- normalizePath(path) @@ -16,8 +16,7 @@ build_package <- function(path, tmpdir, build_args, libpath, quiet) { desc <- desc(path) clean_doc <- as_flag(desc$get("Config/build/clean-inst-doc"), NULL) - with_envvar( - c("R_LIBS_USER" = paste(libpath, collapse = .Platform$path.sep)), { + with_libpaths(libpath, { proc <- pkgbuild_process$new( path, tmpdir, diff --git a/man/rcmdcheck.Rd b/man/rcmdcheck.Rd index 0ecde39..96ae865 100644 --- a/man/rcmdcheck.Rd +++ b/man/rcmdcheck.Rd @@ -2,6 +2,7 @@ % Please edit documentation in R/package.R \docType{package} \name{rcmdcheck} +\alias{rcmdcheck-package} \alias{rcmdcheck} \title{Run R CMD check from R and Capture Results} \usage{ @@ -135,3 +136,22 @@ Note that \code{Config/rcmdcheck/ignore-inconsequential-notes} and the \verb{R CMD check} from a shell (or GUI) will not use them. } +\seealso{ +Useful links: +\itemize{ + \item \url{https://rcmdcheck.r-lib.org/} + \item \url{https://github.com/r-lib/rcmdcheck#readme} + \item Report bugs at \url{https://github.com/r-Lib/rcmdcheck/issues} +} + +} +\author{ +\strong{Maintainer}: Gábor Csárdi \email{csardi.gabor@gmail.com} + +Other contributors: +\itemize{ + \item Mango Solutions [copyright holder, funder] + \item Posit Software, PBC [copyright holder, funder] +} + +}