Merge pull request #116 from r-lib/sparse_is_ns-bug

Author: EmilHvitfeldt

NEWS.md

@@ -2,6 +2,8 @@
 
 * Fixed bug where `sparse_multiplication()` had a stack imbalence when returning all 0s. (#113)
 
+* Fixed bug where `sparse_is_na(type = "integer")` would error on character vectors. (#116)
+
 # sparsevctrs 0.3.3
 
 ## Bug Fixes

R/sparse_is_na.R

@@ -44,7 +44,7 @@ sparse_is_na <- function(x, type = "logical") {
       rep(1, length(positions)),
       positions,
       length(x),
-      sparse_default(x)
+      0L
     )
   }
 

tests/testthat/test-sparse_is_na.R

@@ -2,38 +2,46 @@ test_that("sparse_is_na() works - double", {
   x <- sparse_double(c(10, -10), c(5, 100), 1000)
 
   expect_equal(is.na(x), sparse_is_na(x))
+  expect_equal(as.integer(is.na(x)), sparse_is_na(x, type = "integer"))
 
   x <- sparse_double(c(NA, 10, 30), 1:3, 1000)
 
   expect_equal(is.na(x), sparse_is_na(x))
+  expect_equal(as.integer(is.na(x)), sparse_is_na(x, type = "integer"))
 })
 
 test_that("sparse_is_na() works - integer", {
   x <- sparse_integer(c(10, -10), c(5, 100), 1000)
 
   expect_equal(is.na(x), sparse_is_na(x))
+  expect_equal(as.integer(is.na(x)), sparse_is_na(x, type = "integer"))
 
   x <- sparse_integer(c(NA, 10, 30), 1:3, 1000)
 
   expect_equal(is.na(x), sparse_is_na(x))
+  expect_equal(as.integer(is.na(x)), sparse_is_na(x, type = "integer"))
 })
 
 test_that("sparse_is_na() works - logical", {
   x <- sparse_logical(c(TRUE, TRUE), c(5, 100), 1000)
 
   expect_equal(is.na(x), sparse_is_na(x))
+  expect_equal(as.integer(is.na(x)), sparse_is_na(x, type = "integer"))
 
   x <- sparse_logical(c(NA, TRUE, TRUE), 1:3, 1000)
 
   expect_equal(is.na(x), sparse_is_na(x))
+  expect_equal(as.integer(is.na(x)), sparse_is_na(x, type = "integer"))
 })
 
 test_that("sparse_is_na() works - character", {
   x <- sparse_character(c("A", "B"), c(5, 100), 1000)
 
   expect_equal(is.na(x), sparse_is_na(x))
+  expect_equal(as.integer(is.na(x)), sparse_is_na(x, type = "integer"))
 
   x <- sparse_character(c(NA, "A", "B"), 1:3, 1000)
 
   expect_equal(is.na(x), sparse_is_na(x))
+  expect_equal(as.integer(is.na(x)), sparse_is_na(x, type = "integer"))
 })