Skip to content

Commit b45ab79

Browse files
authored
Merge pull request #29 from neuroanatomy/master
big update
2 parents c2635ba + 1d633fe commit b45ab79

File tree

125 files changed

+8638
-17076
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

125 files changed

+8638
-17076
lines changed

.eslintrc.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ module.exports = {
66
},
77
"extends": "eslint:recommended",
88
"parserOptions": {
9-
"sourceType": "module"
9+
"sourceType": "module",
10+
"ecmaVersion": 8
1011
},
1112
"rules": {
1213
"accessor-pairs": "error",
@@ -89,7 +90,7 @@ module.exports = {
8990
"max-lines": "error",
9091
"max-nested-callbacks": "error",
9192
"max-params": "off",
92-
"max-statements": "error",
93+
"max-statements": ["error", 100],
9394
"max-statements-per-line": "off",
9495
"multiline-ternary": [
9596
"error",

ANNOTATIONS.md

-33
This file was deleted.

BRAINMAPPERS.md

-46
This file was deleted.

CONTRIBUTING.md renamed to Contributing.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
In our [GitHub issue #42](https://github.com/neuroanatomy/BrainBox/issues/177) you find
88
detailed information on how to participate and get credit for your work. Currently, we
99
are trying to complete the dolphin brain!! Join our team of
10-
[BrainMappers](https://github.com/neuroanatomy/BrainBox/blob/master/BRAINMAPPERS.md)
10+
[BrainMappers](https://github.com/neuroanatomy/BrainBox/blob/master/BrainMappers.md)
1111
We will be happy to work with anyone who would love to join our effort.
1212
While you can see in real-time what your collaborators are writing or drawing on a given
1313
data set, you can also chat with them, and ask for help or approval of your work. We want

Issue_Template.md

+25
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
## Thank you for your feedback.
2+
3+
### Please tag your issue as a feature request or a bug report using the labels on the right.
4+
5+
### Current behaviour
6+
7+
* If this is a bug, please explain how to reproduce the problem
8+
* Which tools did you use in which sequence?
9+
* Is the error concerning a text or a volume annotation?
10+
* Which label set has been used for the volume annotation (if applicable)?
11+
* What is the type and resolution of your data? (Can you provide a link to your data?)
12+
* Do not include sensitive information.
13+
* Upload the browser error message if you are familiar with web developer tools.
14+
15+
### Expected behaviour
16+
17+
### Version information (for bug reports)
18+
19+
* **Browser + version**:
20+
* **Your OS + version**:
21+
* Paste the output of these commands:
22+
```
23+
node --version && npm --version
24+
```
25+

LICENSE

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
Copyright [2016] OpenNeuroLab Developers
1+
Copyright [2016] BrainBox Developers
22

33
Licensed under the Apache License, Version 2.0 (the "License");
44
you may not use this file except in compliance with the License.

Pull_Request_Template.md

+79
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,79 @@
1+
<!-- Thank you for your contribution to BrainBox -->
2+
3+
<!-- Give a short title and description for your pull request: -->
4+
5+
---
6+
<!-- Run the tests. Replace each `[ ]` by `[X]` when the step is complete.-->
7+
- [ ] These changes fix #__ (github issue number if applicable).
8+
- [ ] ```npm run mocha-test``` ran with full success.
9+
- [ ] ```npm run mocha-test``` ran resulted in failure in _____
10+
11+
<!-- Replace `__` with appropriate information: -->
12+
- [ ] I implemented tests for the changes I made OR
13+
- [ ] These changes do not require tests because _____
14+
15+
<!-- Make sure that "Allow edits from maintainers" checkbox is checked.-->
16+
17+
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification. -->
18+
19+
20+
- [ ] All BrainBox tools behave as expected:
21+
* **KEYS**
22+
* right and left arrow keys
23+
- [ ] jump to next or previous slice within one brain, respectively
24+
- [ ] update the slider accordingly
25+
- [ ] update the slice number accordingly (upper left corner of the viewer window)
26+
* down and up arrow keys
27+
- [ ] jump to the next or previous brain within one project, respectively
28+
- [ ] update the selected subject in the annotation table
29+
* **TOOL BUTTONS**
30+
* minus
31+
- [ ] jumps to the previous slice within one brain
32+
- [ ] updates the slider accordingly
33+
- [ ] updates the slice number accordingly (upper left corner of the viewer window)
34+
* plus
35+
- [ ] jumps to the next slice within one brain
36+
- [ ] updates the slider accordingly
37+
- [ ] updates the slice number accordingly (upper left corner of the viewer window)
38+
* slider
39+
- [ ] updates slice view and slice number on the fly
40+
* sag / cor / axi buttons
41+
- [ ] switch view between the three orthogonal planes
42+
* show tool
43+
- [ ] when you click and drag in your browser window, this tool displays a cirlce at the position of your mouse click & drag as well as the user name in all browser windows connected to the same brain
44+
* the numbers at the bottom of the tool panel
45+
- [ ] change pencil size and eraser size accordingly
46+
* pencil tool
47+
- [ ] draws a line in the colour displayed in the color field
48+
- [ ] in combination with bucket tool filles a complete area with the chosen colour (be sure to have closed the contour line ;) Otherwise, the undo button will be your friend ;)
49+
- [ ] updates length and volume information (of what has been segmented) in the upper left corner of the viewer
50+
* erase tool
51+
- [ ] erases upon click drag from the annotation
52+
- [ ] in combination with the bucket tool erases the complete area of the color where you click
53+
* fill bucket tool
54+
* in combination with pencil tool
55+
- [ ] fills a complete area with the colour displayed in the colour field
56+
* in combination with erase tool
57+
- [ ] erases the complete area that is filled by the colour of where you click
58+
* colour field
59+
- [ ] displays the currently chosen colour to draw and fill
60+
- [ ] on click opens the set of colours available within the chosen label set where a new colour can be selected upon click
61+
* ruler tool
62+
- [ ] measures the distance between start and end of your defined path
63+
- [ ] points of mouse click appear and stay visible until you hit return key (this functionality is currently broken!) (you can click as many points as you wish to define the path you are interested in)
64+
- [ ] on return key, BrainBox will print the distance into the chat field (the ruler tool seems to be currently broken!!!)
65+
* adjust tool
66+
- [ ] slide opacity of overlaid annotation from 0 to 100%
67+
- [ ] increase or decrease brightness of the underlying MRI data
68+
- [ ] increase or decrease the contrast of the underlying MRI data
69+
* eyedropper tool
70+
- [ ] updates the colour field in the tool panel
71+
- [ ] displays/updates the region name in the upper left corner of the viewer
72+
* undo tool
73+
- [ ] undoes the user's actions in reverse chronological order and currently has the bug that it even undoes actions in slices you are currently not seeing! and there is currently no redo...
74+
* save button
75+
- [ ] saves the annotation of the data set into the data base
76+
- [ ] displays a message that user needs to login in case they are not
77+
- [ ] display a message `Atlas saved Wed Oct 18 2017 12:49:12 GMT+0200 (CEST)`
78+
79+

README.md renamed to ReadMe.md

+22-14
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11

22
[![CircleCI](https://circleci.com/gh/neuroanatomy/BrainBox/tree/master.svg?style=shield)](https://circleci.com/gh/neuroanatomy/BrainBox/tree/master) [![Join the chat at https://gitter.im/OpenNeuroLab-Brainbox/Lobby](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/OpenNeuroLab-Brainbox/Lobby?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
33

4-
# BrainBox - An application from the [Open Neuroimaging Laboratory](http://openneu.ro/)
4+
# BrainBox - A platform for real-time collaboration in neuroimaging
55

66
[![Join the chat at https://gitter.im/OpenNeuroLab-Brainbox/Lobby](https://badges.gitter.im/OpenNeuroLab-Brainbox/Lobby.svg)](https://gitter.im/OpenNeuroLab-Brainbox/Lobby?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
77

8-
BrainBox is a web application for the collaborative curation of neuroimaging data
8+
BrainBox is a Web application for the collaborative curation of neuroimaging data
99
available online. You can share, visualise and annotate MRI brain
1010
data in real-time, collaboratively. BrainBox will provide the means to create a
1111
layer of collaborative annotation over all the available MRI data without
@@ -34,7 +34,7 @@ Our aim is to make BrainBox into a reliable tool for open, reproducible, collabo
3434

3535
We will be happy to work with anyone who would love to join our effort.
3636
While you can see in real-time what your collaborators are writing or drawing on a given data set, you can also chat with them, and ask for help or approval of your work. We want to open this scientific process to everyone with any background including citizen scientists and researchers. Join us!
37-
**Join our segmentation sprint!** In our [GitHub issue #42](https://github.com/neuroanatomy/BrainBox/issues/177) you find detailed information on how to participate and get credit for your work. Currently, we are trying to complete the dolphin brain! Join our team of [BrainMappers](https://github.com/neuroanatomy/BrainBox/blob/master/BRAINMAPPERS.md)
37+
**Join our segmentation sprint!** In our [GitHub issue #42](https://github.com/neuroanatomy/BrainBox/issues/177) you find detailed information on how to participate and get credit for your work. Currently, we are trying to complete the dolphin brain! Join our team of [BrainMappers](https://github.com/neuroanatomy/BrainBox/blob/master/BrainMappers.md)
3838

3939
And please also feel free to join our efforts on GitHub! Everybody very welcome!
4040

@@ -68,7 +68,26 @@ Or launch your own collaborative project on [BrainBox](http://brainbox.pasteur.f
6868

6969
If you want to work on BrainBox's code, you'll need a local installation:
7070

71+
72+
## Non docker developer install instructions
73+
74+
1. install and start `mongo` database
75+
2. clone the repo and `cd` to the brainbox directory
76+
4. [create a new OAuth application](https://github.com/settings/applications/new) for your local brainbox url (http://localhost:3000 by default)
77+
5. paste the keys into the github-keys.json.example file, and drop the .example
78+
6. drop the `.example` from `controller/atlasMakerServer/blacklist.json.example`
79+
7. drop the `.example` from `controller/atlasMakerServer/whitelist.json.example`
80+
8. drop the `.example` from `blacklist.json.example`
81+
9. drop the `.example` from `whitelist.json.example`
82+
10. `npm install`
83+
11. `npm run prepare`
84+
12. `npm run build`
85+
13. `npm start`
86+
14. To check that your code style is like the one we use, enter `npm run lint`, or you can type `eslint` before committing, to do that install `eslint` globally using `npm i -g eslint` (our code style rules are in the file `.eslintrc`).
87+
88+
7189
## Using Docker to install and run BrainBox
90+
These installation instructions may need to be updated.
7291

7392
1. `git clone` this repository or download it
7493
2. `mv BrainBox brainbox` to rename the directory
@@ -81,17 +100,6 @@ If you want to work on BrainBox's code, you'll need a local installation:
81100
8. `docker-compose up`
82101
9. Then open `http://localhost:3000` in your browser.
83102

84-
## Non docker developer install instructions
85-
86-
1. install and start `mongo` database
87-
2. clone the repo and `cd` to the brainbox directory
88-
4. [create a new OAuth application](https://github.com/settings/applications/new) for your local brainbox url (http://localhost:3000 by default)
89-
5. paste the keys into the github-keys.json.example file, and drop the .example
90-
6. drop the `.example` from `controller/atlasMakerServer/blacklist.json.example`
91-
7. drop the `.example` from `controller/atlasMakerServer/whitelist.json.example`
92-
8. `npm install`
93-
9. `npm start`
94-
10. To check that your code style is like the one we use, enter `npm run lint`, or you can type `eslint` before committing, to do that install `eslint` globally using `npm i -g eslint` (our code style rules are in the file `.eslintrc`).
95103

96104
## Tests
97105

0 commit comments

Comments
 (0)