Skip to content

Commit 9d9c87b

Browse files
committed
Updated sample code for configuring connections
1 parent 3bfc000 commit 9d9c87b

File tree

3 files changed

+6
-14
lines changed

3 files changed

+6
-14
lines changed

CHANGELOG.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
- [#1196](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/1196) Use default inspect for database adapter
1111
- [#1216](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/1216) Refactor adapter interface to match abstract adapter
1212
- [#1225](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/1225) Drop support to Ruby 3.1
13-
- [#1242](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/1242) Changed how additional connection configuration is performed
1413

1514
#### Fixed
1615

README.md

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -105,15 +105,14 @@ configuration then implement the `additional_connection_configuration` method in
105105
example we are setting the `TEXTSIZE` to 64 megabytes.
106106

107107
```ruby
108-
module ActiveRecord
109-
module ConnectionAdapters
110-
class SQLServerAdapter < AbstractAdapter
111-
def additional_connection_configuration
112-
@raw_connection.execute("SET TEXTSIZE #{64.megabytes}").do
113-
end
108+
ActiveRecord::ConnectionAdapters::SQLServerAdapter.prepend(
109+
Module.new do
110+
def configure_connection
111+
super
112+
@raw_connection.execute("SET TEXTSIZE #{64.megabytes}").do
114113
end
115114
end
116-
end
115+
)
117116
```
118117

119118
#### Configure Application Name

lib/active_record/connection_adapters/sqlserver_adapter.rb

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -521,12 +521,6 @@ def configure_connection
521521

522522
initialize_dateformatter
523523
use_database
524-
additional_connection_configuration
525-
end
526-
527-
# Allow for additional connection configuration by overriding this method.
528-
def additional_connection_configuration
529-
# no-op
530524
end
531525
end
532526
end

0 commit comments

Comments
 (0)