Merge pull request #110 from eregon/symbol-to-js-fix

Add test for passing Symbol to JS and fix it for GraalJSRuntime

Author: byroot

lib/execjs/external_runtime.rb

@@ -1,5 +1,6 @@
-require "tmpdir"
 require "execjs/runtime"
+require "tmpdir"
+require "json"
 
 module ExecJS
   class ExternalRuntime < Runtime

lib/execjs/graaljs_runtime.rb

@@ -96,6 +96,8 @@ def convert_ruby_to_js(value)
         case value
         when nil, true, false, Integer, Float, String
           value
+        when Symbol
+          value.to_s
         when Array
           value.map { |e| convert_ruby_to_js(e) }
         when Hash

lib/execjs/ruby_rhino_runtime.rb

@@ -1,4 +1,5 @@
 require "execjs/runtime"
+require "json"
 
 module ExecJS
   class RubyRhinoRuntime < Runtime
@@ -32,7 +33,11 @@ def eval(source, options = {})
       end
 
       def call(properties, *args)
-        unbox @rhino_context.eval(properties).call(*args)
+        # Might no longer be necessary if therubyrhino handles Symbols directly:
+        # https://github.com/rubyjs/therubyrhino/issues/43
+        converted_args = JSON.parse(JSON.generate(args), create_additions: false)
+
+        unbox @rhino_context.eval(properties).call(*converted_args)
       rescue Exception => e
         raise wrap_error(e)
       end

test/test_execjs.rb

@@ -167,6 +167,13 @@ def test_context_call_missing_function
     end
   end
 
+  def test_symbol
+    context = ExecJS.compile("function echo(test) { return test; }")
+    assert_equal "symbol", context.call("echo", :symbol)
+    assert_equal ["symbol"], context.call("echo", [:symbol])
+    assert_equal({"key" => "value"}, context.call("echo", {key: :value}))
+  end
+
   def test_additional_options
     assert ExecJS.eval("true", :foo => true)
     assert ExecJS.exec("return true", :foo => true)