diff --git a/app/models/names_manager/canonical_names.rb b/app/models/names_manager/canonical_names.rb index 17becf66..bce02197 100644 --- a/app/models/names_manager/canonical_names.rb +++ b/app/models/names_manager/canonical_names.rb @@ -486,6 +486,7 @@ def self.map(canonical_name, *also_as) map 'Hakan Ensari', 'hakanensari' map 'Hal Brodigan', 'postmodern' map 'Hampton Catlin', "hcatlin\100gmail.com" + map 'Harsh Deep', 'Harsh' map 'Hartley McGuire', 'Hartley McGuire @skipkayhil' map 'Hendrik Mans', "hendrik\100mans.de" map 'Hendy Irawan', 'ceefour' @@ -1193,7 +1194,6 @@ def self.map(canonical_name, *also_as) map 'Zhang Kang', 'piecehealth', 'Kang Zhang' map 'Zheng Jia', 'zhengjia' map 'zzak', 'Zachary Scott' - map 'Harsh Deep', 'Harsh', "harsh.deep\100moderntreasury.com" # Reverse SEEN_ALSO_AS to be able to go from handler to canonical name. CANONICAL_NAME_FOR = {} SEEN_ALSO_AS.each do |canonical_name, also_as| diff --git a/test/credits/canonical_names_test.rb b/test/credits/canonical_names_test.rb index 74d9ac81..8af8f80f 100644 --- a/test/credits/canonical_names_test.rb +++ b/test/credits/canonical_names_test.rb @@ -1211,6 +1211,10 @@ class CanonicalNamesTest < ActiveSupport::TestCase assert_contributor_names 'bd261ff', 'David Heinemeier Hansson' end + test 'dhh' do + assert_contributor_names 'dd6f3e1', 'David Heinemeier Hansson' + end + test 'diatmpravin' do assert_contributor_names 'a302597', 'Pravin Mishra' end @@ -1760,6 +1764,10 @@ class CanonicalNamesTest < ActiveSupport::TestCase assert_contributor_names '4c21026', 'Mike Breen' end + test 'Harsh' do + assert_contributor_names '5ff38f4', 'Harsh Deep' + end + test 'Hartley McGuire @skipkayhil' do assert_contributor_names '773d640', 'Hartley McGuire' end @@ -5159,13 +5167,5 @@ class CanonicalNamesTest < ActiveSupport::TestCase test 'प्रथमेश Sonpatki' do assert_contributor_names 'a7a2bc0f66', 'Prathamesh Sonpatki' end - - test 'Harsh' do - assert_contributor_names '5ff38f4', 'Harsh Deep' - end - - test 'dhh' do - assert_contributor_names 'dd6f3e1', 'David Heinemeier Hansson' - end end end