Skip to content

Conversation

@findolor
Copy link
Contributor

@findolor findolor commented Nov 21, 2025

Dependent PR

Motivation

We have updated the metadata repository to include additional subgraph queries. This PR bumps up the commit hash for that functionality.

Solution

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

Summary by CodeRabbit

  • Chores
    • Updated internal dependencies with no functional changes to user-facing features.

✏️ Tip: You can customize this high-level summary in your review settings.

@findolor findolor requested review from 0xgleb and hardyjosh November 21, 2025 08:07
@findolor findolor self-assigned this Nov 21, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 21, 2025

Walkthrough

This PR updates the lib/rain.metadata submodule pointer from commit 0fc7d0f21e28ab5360b23ba45a298d56313c5ab5 to 4defa4b927a0915e6417ec3662bb035647e0ab0a. No functional code changes are present.

Changes

Cohort / File(s) Summary
Submodule Update
lib/rain.metadata
Updated submodule pointer to new commit

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Verify the target commit 4defa4b927a0915e6417ec3662bb035647e0ab0a is valid and from the expected repository
  • Confirm the submodule update aligns with any related dependency changes in this release

Possibly related PRs

  • Update metadata submod #402: Updates the lib/rain.metadata submodule pointer (same pattern, different target commit)
  • metadata #398: Updates the lib/rain.metadata submodule pointer (same pattern, different target commit)

Suggested reviewers

  • hardyjosh
  • 0xgleb

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Bump rain.metadata commit hash' is directly and specifically related to the changeset, which updates a submodule pointer for lib/rain.metadata to a new commit hash.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch rain.metadata-bump

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d1fee1b and 18827b5.

📒 Files selected for processing (1)
  • lib/rain.metadata (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
  • GitHub Check: rainix (ubuntu-latest, test-wasm-build)
  • GitHub Check: rainix (ubuntu-latest, rainix-rs-static)
  • GitHub Check: rainix (ubuntu-latest, rainix-sol-artifacts)
  • GitHub Check: rainix (ubuntu-latest, rainix-sol-static)
  • GitHub Check: rainix (ubuntu-latest, rainix-rs-artifacts)
  • GitHub Check: rainix (ubuntu-latest, rainix-sol-test)
  • GitHub Check: rainix (macos-latest, rainix-rs-artifacts)
  • GitHub Check: rainix (macos-latest, rainix-rs-test)
  • GitHub Check: rainix (ubuntu-latest, rainix-rs-test)
  • GitHub Check: git-clean

@@ -1 +1 @@
Subproject commit 0fc7d0f21e28ab5360b23ba45a298d56313c5ab5
Subproject commit 4defa4b927a0915e6417ec3662bb035647e0ab0a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Verify the new submodule commit exists and the dependency chain is complete.

This PR updates the lib/rain.metadata submodule pointer to a new commit hash. Before merging, confirm:

  1. The new commit hash 4defa4b927a0915e6417ec3662bb035647e0ab0a exists in the rain.metadata repository
  2. The dependent PR (rain.metadata#84) that introduced the subgraph query changes is finalized and merged
  3. All integration tests in rain.interpreter pass with the updated submodule

🏁 Script executed:

#!/bin/bash
# Description: Verify the new submodule commit is reachable and test submodule resolution

# Test 1: Verify the commit hash format is valid (40 hex chars)
NEW_COMMIT="4defa4b927a0915e6417ec3662bb035647e0ab0a"
if [[ $NEW_COMMIT =~ ^[0-9a-f]{40}$ ]]; then
  echo "✓ Commit hash format is valid"
else
  echo "✗ Commit hash format is invalid"
  exit 1
fi

# Test 2: Check if .gitmodules exists and contains rain.metadata reference
if [ -f .gitmodules ]; then
  echo "✓ .gitmodules file exists"
  echo "--- .gitmodules content ---"
  cat .gitmodules
  echo "----"
  
  # Verify rain.metadata submodule is configured
  if grep -q "path = lib/rain.metadata" .gitmodules; then
    echo "✓ rain.metadata submodule is registered"
    # Extract the URL for reference
    SUBMODULE_URL=$(git config --file .gitmodules --get submodule.lib/rain.metadata.url)
    echo "  Submodule URL: $SUBMODULE_URL"
  else
    echo "✗ rain.metadata submodule not found in .gitmodules"
  fi
else
  echo "✗ .gitmodules file not found"
fi

# Test 3: List the current submodule status
echo "--- Current submodule status ---"
git config --file .gitmodules --get-regexp path

Length of output: 1124


🏁 Script executed:

#!/bin/bash
# Verify the new commit exists in the rain.metadata remote repository

NEW_COMMIT="4defa4b927a0915e6417ec3662bb035647e0ab0a"
REMOTE_URL="https://github.com/rainprotocol/rain.metadata"

echo "Checking if commit $NEW_COMMIT exists in $REMOTE_URL"
echo "---"

# Fetch the commit info from the remote without cloning the full repo
# Using ls-remote to check if the commit exists
git ls-remote "$REMOTE_URL" | head -20

echo "---"
echo "Attempting to fetch the specific commit..."
git fetch --depth=1 "$REMOTE_URL" "$NEW_COMMIT" 2>&1 | head -20 || echo "Fetch attempt completed (may show errors if commit not found)"

Length of output: 1744


🏁 Script executed:

#!/bin/bash
# Check the status of rain.metadata PR #84 using GitHub CLI

echo "Checking PR status for rainprotocol/rain.metadata#84..."
gh pr view 84 --repo rainprotocol/rain.metadata --json state,title,mergedAt,author || echo "Cannot access PR or PR does not exist"

Length of output: 244


Do not merge: submodule commit exists only on an unmerged feature branch.

The new commit hash 4defa4b927a0915e6417ec3662bb035647e0ab0a is not reachable from the rain.metadata repository's main branches. This commit exists only on the feature branch for PR rainlanguage/rain.metadata#84, which is currently OPEN and not merged. Pinning the submodule to a commit on an unmerged branch creates a broken dependency state.

Before updating the submodule:

  1. Ensure rain.metadata#84 is merged to a stable branch (main/master)
  2. Then update lib/rain.metadata to point to that finalized commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants