How to obtain the decoded iFormat in FFI?

[xlievo]

Can you add the following retrieval method? or did I miss something...?

impl DecodedYUV<'_> {
    /// Return the video format of the current frame.
    #[must_use]
    pub fn format(&self) -> i32{
        self.info.iFormat
    }
}

[ralfbiedert]

We can, but:

• Would that value ever show anything else than videoFormatI420, since AFAIK upstream only supports that?
• Format should probably return a "nice" VideoFormat enum that has a to_native() -> i32 method

[xlievo]

Okay, maybe this isn't important, at least there isn't enough reason for it yet.
There is an additional question of why the DecodedYUV -> timestamp is always equal to 0.
I see the following code; can you explain it further?

let timestamp = Timestamp::from_millis(buffer_info.uiInBsTimeStamp); // TODO: Is this the right one?

[ralfbiedert]

This is an open issue / known bug; also see unit test encode_at_timestamp_roundtrips that for now fails and is ignored.

I suspect the issue is on our side, but unfortunately the upstream documentation isn't very good, so it's a bit hard to tell how this is supposed to work.

A fix (including documentation) would be highly welcome!