Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API does not throw error while adding nodepool with AZ #751

Closed
cpinjani opened this issue Dec 12, 2024 · 2 comments
Closed

API does not throw error while adding nodepool with AZ #751

cpinjani opened this issue Dec 12, 2024 · 2 comments
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@cpinjani
Copy link
Contributor

cpinjani commented Dec 12, 2024

Setup
Rancher version: v2.10-c4944b3ca0b39c474121df9e7ef31f7aff4e4f7a-head
AKS Operator version: v1.10.1-rc.2

Description
Via UI, it is not possible to add nodepool with Availability Zone for a cluster created in region with no support for AZ. Updating this via API does not raise any error. It simply reverts the changes to AKSConfig after a few minutes.
The API should raise an error for the same.

Steps to reproduce:

  • Create a cluster in region without AZ support Eg. WestUS
  • Add nodepool via API and mention availability zones

Expected results:
The API must throw an error while adding nodepool with AZ in region where AZ are not supported.

Logs

time="2024-12-12T08:17:17Z" level=info msg="Checking configuration for cluster [cpinjani-akswest (id: c-4zdpb)]"
time="2024-12-12T08:17:18Z" level=info msg="Adding node pool [pool11] for cluster [cpinjani-akswest (id: c-4zdpb)]"
time="2024-12-12T08:17:24Z" level=info msg="Waiting for cluster [cpinjani-akswest (id: c-4zdpb)] to update node pool [pool11]"
time="2024-12-12T08:17:55Z" level=info msg="Checking configuration for cluster [cpinjani-akswest (id: c-4zdpb)]"
time="2024-12-12T08:17:56Z" level=info msg="Cluster [cpinjani-akswest (id: c-4zdpb)] finished updating"
time="2024-12-12T08:17:57Z" level=info msg="Checking configuration for cluster [cpinjani-akswest (id: c-4zdpb)]"
time="2024-12-12T08:17:59Z" level=info msg="Configuration for cluster [cpinjani-akswest (id: c-4zdpb)] was verified"

PR's:

@cpinjani cpinjani added the kind/bug Something isn't working label Dec 12, 2024
@cpinjani cpinjani added this to the v2.10.2 milestone Dec 12, 2024
@cpinjani cpinjani moved this to Backlog in CAPI / Turtles Dec 12, 2024
@mjura mjura self-assigned this Dec 24, 2024
@mjura mjura moved this from Backlog to In Progress (8 max) in CAPI / Turtles Jan 3, 2025
mjura added a commit to mjura/rancher that referenced this issue Jan 13, 2025
mjura added a commit to mjura/rancher that referenced this issue Jan 14, 2025
mjura added a commit to mjura/rancher that referenced this issue Jan 14, 2025
mjura added a commit to mjura/rancher that referenced this issue Jan 15, 2025
mjura added a commit to mjura/rancher that referenced this issue Jan 15, 2025
mjura added a commit to mjura/rancher that referenced this issue Jan 15, 2025
mjura added a commit to mjura/rancher that referenced this issue Jan 15, 2025
mjura added a commit to mjura/aks-operator that referenced this issue Jan 17, 2025
mjura added a commit to mjura/rancher that referenced this issue Jan 20, 2025
mjura added a commit to mjura/rancher that referenced this issue Jan 20, 2025
mjura added a commit to mjura/aks-operator that referenced this issue Jan 21, 2025
mjura added a commit to mjura/aks-operator that referenced this issue Jan 21, 2025
mjura added a commit to mjura/aks-operator that referenced this issue Jan 21, 2025
mjura added a commit to mjura/aks-operator that referenced this issue Jan 22, 2025
mjura added a commit to mjura/aks-operator that referenced this issue Jan 23, 2025
mjura added a commit to mjura/aks-operator that referenced this issue Jan 27, 2025
mjura added a commit to mjura/aks-operator that referenced this issue Jan 27, 2025
mjura added a commit to mjura/aks-operator that referenced this issue Jan 27, 2025
mjura added a commit to mjura/aks-operator that referenced this issue Jan 27, 2025
@mjura mjura moved this from In Progress (8 max) to PR to be reviewed in CAPI / Turtles Jan 28, 2025
@mjura mjura removed this from the v2.10.2 milestone Jan 29, 2025
@mjura mjura added this to the v2.11.0 milestone Jan 29, 2025
@mjura mjura moved this from PR to be reviewed to To Test in CAPI / Turtles Jan 29, 2025
@cpinjani cpinjani self-assigned this Jan 29, 2025
diogoasouza pushed a commit to diogoasouza/rancher that referenced this issue Jan 29, 2025
chiukapoor pushed a commit to chiukapoor/rancher that referenced this issue Feb 4, 2025
@cpinjani
Copy link
Contributor Author

cpinjani commented Feb 6, 2025

Test Result
Rancher version: v2.11-1d345932e5f78b3da07ebe13691c8224c62b6240-head, AKS Operator version: v1.11.0-rc.3

Issue is reproducible on above build. Also the full validation is blocked by follow-up issue #850

cc: @mjura @mitulshah-suse

@cpinjani cpinjani moved this from To Test to Blocked in CAPI / Turtles Feb 6, 2025
@cpinjani cpinjani removed their assignment Feb 6, 2025
@kkaempf kkaempf removed this from CAPI / Turtles Feb 6, 2025
@mitulshah-suse mitulshah-suse modified the milestones: v2.11.0, v2.11.1 Mar 5, 2025
@rishabhmsra
Copy link

Validated on rancher v2.11-head:

  • Created AKS v1.32 cluster in WestUS region.
  • Once cluster came into Active state, added a node pool mentioning the availability zones via API.
  • Cluster goes into Updating state with following error on UI : Failed to update cluster [rishabh-aks3 (id: c-zv2vj)]: availability zones are not supported in region westus
  • Since we getting error after sending request via API, closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants