Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] cudf.pandas produces incorrect results for groupby-cumprod #17880

Open
MarcoGorelli opened this issue Jan 31, 2025 · 0 comments · May be fixed by #17895
Open

[BUG] cudf.pandas produces incorrect results for groupby-cumprod #17880

MarcoGorelli opened this issue Jan 31, 2025 · 0 comments · May be fixed by #17895
Labels
bug Something isn't working Python Affects Python cuDF API.

Comments

@MarcoGorelli
Copy link
Contributor

MarcoGorelli commented Jan 31, 2025

Describe the bug
Incorrect results

Steps/Code to reproduce bug

%%writefile t.py
import pandas as pd
df = pd.DataFrame({'a': [1, 2, None, 3], 'b': ['x']*4})
print(df.groupby('b')['a'].cumprod())

Then run

!python t.py

and

!python -m cudf.pandas t.py

Expected behavior

0    1.0
1    2.0
2    NaN
3    6.0
Name: a, dtype: float64

got

0    1.0
1    2.0
2    NaN
3    NaN
Name: a, dtype: float64

Environment overview (please complete the following information)

  • Environment location: [Bare-metal, Docker, Cloud(specify cloud provider)]
  • Method of cuDF install: [conda, Docker, or from source]
    • If method of install is [Docker], provide docker pull & docker run commands used

cudf version: '25.02.00a360'

Environment details
Please run and paste the output of the cudf/print_env.sh script here, to gather any other relevant environment details

Additional context
Add any other context about the problem here.

spotted in Narwhals

@MarcoGorelli MarcoGorelli added the bug Something isn't working label Jan 31, 2025
@mroeschke mroeschke added the Python Affects Python cuDF API. label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Python Affects Python cuDF API.
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

2 participants