Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UMAP transform illegal memory access error when data_on_host=True #6259

Merged
merged 4 commits into from
Jan 28, 2025
Merged

Fix UMAP transform illegal memory access error when data_on_host=True #6259

merged 4 commits into from
Jan 28, 2025
+30 −11

Conversation

csadorf
Copy link
Contributor

@csadorf csadorf commented Jan 24, 2025 •
edited
Loading

Fixes #6216 by identifying whether the original input data is on host or device and conditionally builds the brute force index (required for a separate transform() call) for the correct matrix view.

  • Identify and fix root cause
  • Clean up implementation
  • Implement unit test
  • Document fix

Closes #6216

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 24, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@csadorf csadorf self-assigned this Jan 24, 2025
@github-actions github-actions bot added Cython / Python Cython or Python issue CUDA/C++ labels Jan 24, 2025
@csadorf csadorf added 2 - In Progress Currenty a work in progress non-breaking Non-breaking change bug Something isn't working CUDA/C++ and removed Cython / Python Cython or Python issue CUDA/C++ labels Jan 24, 2025
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Jan 24, 2025
@csadorf csadorf marked this pull request as ready for review January 24, 2025 15:33
@csadorf csadorf requested review from a team as code owners January 24, 2025 15:33
@csadorf csadorf added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currenty a work in progress labels Jan 24, 2025
@dantegd
Copy link
Member

dantegd commented Jan 25, 2025

@csadorf we needed to merge branch-24.02 to get the devcontainer jobs passing, just did it and we should be good to merge now

@dantegd
Copy link
Member

dantegd commented Jan 25, 2025

/merge

@dantegd dantegd changed the title Fix issue 6216 Fix UMAP transform illegal memory access error when data_on_host=True Jan 25, 2025
viclafargue
viclafargue approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@viclafargue viclafargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dantegd
Copy link
Member

dantegd commented Jan 27, 2025

/merge

@rapids-bot rapids-bot bot merged commit 6985c51 into rapidsai:branch-25.02 Jan 28, 2025
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wphicks wphicks wphicks approved these changes

@viclafargue viclafargue viclafargue approved these changes

@cjnolet cjnolet Awaiting requested review from cjnolet cjnolet is a code owner automatically assigned from rapidsai/cuml-cpp-codeowners

Assignees

@csadorf csadorf

Labels
3 - Ready for Review Ready for review by team bug Something isn't working CUDA/C++ Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] UMAP transform throws illegal memory access error when data_on_host=True
4 participants
@csadorf @dantegd @viclafargue @wphicks