From df4ea06e87b4c1f4f758cc3f90d6d6ec3aeaa497 Mon Sep 17 00:00:00 2001
From: James Lamb <jlamb@nvidia.com>
Date: Mon, 3 Feb 2025 09:13:32 -0600
Subject: [PATCH] disallow fallback to Make in Python builds (#636)

Contributes to https://github.com/rapidsai/build-planning/issues/146

Proposes:

* setting `[tool.scikit-build].ninja.make-fallback = false`, so `scikit-build-core` will not silently fallback to using GNU Make if `ninja` is not available
* including all groups in `dependencies.yaml` with `output_types: pyproject` in `output_types: requirements` as well.
  - *So that, for example, they show up in the solved environment in RAPIDS devcontainers (https://github.com/rapidsai/devcontainers)*

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: https://github.com/rapidsai/cuvs/pull/636
---
 dependencies.yaml             | 2 +-
 python/cuvs/pyproject.toml    | 2 +-
 python/libcuvs/pyproject.toml | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/dependencies.yaml b/dependencies.yaml
index 186e14841..eabfd1ca6 100644
--- a/dependencies.yaml
+++ b/dependencies.yaml
@@ -397,7 +397,7 @@ dependencies:
               - *libcusparse114
   cuda_wheels:
     specific:
-      - output_types: pyproject
+      - output_types: [requirements, pyproject]
         matrices:
           - matrix:
               cuda: "12.*"
diff --git a/python/cuvs/pyproject.toml b/python/cuvs/pyproject.toml
index 2193f7dcb..d6847b381 100644
--- a/python/cuvs/pyproject.toml
+++ b/python/cuvs/pyproject.toml
@@ -104,7 +104,7 @@ build-dir = "build/{wheel_tag}"
 cmake.build-type = "Release"
 cmake.version = "CMakeLists.txt"
 minimum-version = "build-system.requires"
-ninja.make-fallback = true
+ninja.make-fallback = false
 sdist.reproducible = true
 wheel.packages = ["cuvs"]
 
diff --git a/python/libcuvs/pyproject.toml b/python/libcuvs/pyproject.toml
index 94d3e81d8..64dd54cfc 100644
--- a/python/libcuvs/pyproject.toml
+++ b/python/libcuvs/pyproject.toml
@@ -77,7 +77,7 @@ build-dir = "build/{wheel_tag}"
 cmake.build-type = "Release"
 cmake.version = "CMakeLists.txt"
 minimum-version = "build-system.requires"
-ninja.make-fallback = true
+ninja.make-fallback = false
 sdist.reproducible = true
 wheel.install-dir = "libcuvs"
 wheel.packages = ["libcuvs"]