Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MacOS doesn't have O_DIRECT, so I commented out this line in cpp/include/kvikio/file_handle.hpp: #383

Closed
qkoziol opened this issue May 22, 2024 · 0 comments · Fixed by #404
Closed

MacOS doesn't have O_DIRECT, so I commented out this line in cpp/include/kvikio/file_handle.hpp: #383

qkoziol opened this issue May 22, 2024 · 0 comments · Fixed by #404

Comments

@qkoziol
Copy link

qkoziol commented May 22, 2024 

          > > MacOS doesn't have O_DIRECT, so I commented out this line in cpp/include/kvikio/file_handle.hpp:

// if (o_direct) { file_flags |= O_DIRECT; }
After that, ./build.sh libkvikio worked :-)

@qkoziol, could you please open a separate issue for this so we don't lose track.

Yes, will do

Originally posted by @qkoziol in #373 (comment)
This was referenced Jul 15, 2024
Closed
Merged
@rapids-bot rapids-bot bot closed this as completed in #404 Jul 24, 2024
rapids-bot bot pushed a commit that referenced this issue Jul 24, 2024
@jakirkham
Use #ifdef to guard O_DIRECT usage (#404)
89a3343 
Fixes #383

Authors:
  - https://github.com/jakirkham
  - Mads R. B. Kristensen (https://github.com/madsbk)

Approvers:
  - Mads R. B. Kristensen (https://github.com/madsbk)
  - Lawrence Mitchell (https://github.com/wence-)

URL: #404
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use #ifdef to guard O_DIRECT usage jakirkham/kvikio
1 participant
@qkoziol