Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding Cython bindings #23

Open
vyasr opened this issue Feb 7, 2025 · 0 comments
Open

Consider adding Cython bindings #23

vyasr opened this issue Feb 7, 2025 · 0 comments

Comments

@vyasr
Copy link
Contributor

vyasr commented Feb 7, 2025

Currently rapids-logger is a pure C++ library. However, some consumers of it expect to also be able to expose its bindings in Python. Currently that is the case for both rmm and cuml. As of the writing of this issue, we determined that the extra packaging work that would need to be done to create Python packages of rapids-logger that expose the relevant bindings is more work than it's worth, so rmm and cuml are simply going to write their own small set of Cython bindings to the C++ loggers, which means they will be doing some cdef externs from rapids-logger headers directly. If at some point it becomes clear that the benefits outweigh the costs (i.e. if more projects start needing these bindings we can reconsider adding a minimal rapids-logger Python package to centralize and export those bindings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant