Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RayService] A new RayCluster should not be prepared if the serve service points to the existing pending cluster #2877

Closed
1 of 2 tasks
Tracked by #2548
kevin85421 opened this issue Feb 2, 2025 · 1 comment · Fixed by #2887
Closed
1 of 2 tasks
Tracked by #2548
Labels

Comments

@kevin85421
Copy link
Member

kevin85421 commented Feb 2, 2025

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

The RayService controller updates the head and serve services to point to the pending cluster when it is ready, then promotes the pending cluster to the active cluster. However, it seems possible that the services have already pointed to the pending RayCluster, but RayService decides to prepare a new cluster because the user updated the RayService spec.

Then, the old pending cluster will be removed, and requests may be dropped.

Use case

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@kevin85421 kevin85421 added enhancement New feature or request triage rayservice 1.3.0 and removed triage labels Feb 2, 2025
@kevin85421
Copy link
Member Author

/assign @rueian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant