From 934c4ee863ad73adee47ff46efc7902e94817cda Mon Sep 17 00:00:00 2001 From: naveen-s-rzp Date: Wed, 12 Feb 2025 02:23:13 +0530 Subject: [PATCH] remove printStackTrace() --- .../apache/ranger/audit/test/TestEvents.java | 2 +- .../ranger/audit/utils/ORCFileUtil.java | 2 +- .../ranger/audit/utils/RollingTimeUtil.java | 2 +- .../client/datatype/GrantRevokeData.java | 4 +-- .../model/validation/TestRangerValidator.java | 4 +-- .../utils/RangerCredentialProviderTest.java | 4 +-- .../utils/install/XmlConfigChanger.java | 4 +-- .../credentialapi/CredentialReader.java | 2 +- .../apache/ranger/credentialapi/buildks.java | 30 +++++++++---------- .../ElasticSearchIndexBootStrapper.java | 2 +- .../ranger/server/tomcat/EmbeddedServer.java | 8 ++--- .../authorization/hbase/TestPolicyEngine.java | 2 +- .../services/hdfs/client/HdfsClient.java | 2 +- .../services/hive/client/HiveClient.java | 4 +-- .../main/java/org/apache/util/sql/Jisql.java | 12 ++++---- .../org/apache/util/sql/MaskingThread.java | 2 +- .../org/apache/util/sql/MySQLPLRunner.java | 12 ++++---- .../key/VerifyIsDBMasterkeyCorrect.java | 2 +- .../key/VerifyIsHSMMasterkeyCorrect.java | 2 +- .../crypto/key/kms/server/KMSWebApp.java | 2 +- .../authorizer/ExampleClient.java | 2 +- .../test/Impl/TestChildFistClassLoader.java | 4 +-- .../apache/ranger/sizing/RangerMemSizing.java | 4 +-- .../org/apache/ranger/biz/ServiceDBStore.java | 2 +- .../credentialapi/CredentialReader.java | 2 +- .../org/apache/ranger/db/XXModuleDefDao.java | 2 +- .../org/apache/ranger/patch/BaseLoader.java | 2 +- ...AtlasForClassificationResource_J10047.java | 2 +- .../patch/cliutil/ChangeUserNameUtil.java | 2 +- .../org/apache/ranger/rest/ServiceREST.java | 2 +- .../security/web/filter/RangerKrbFilter.java | 4 +-- .../apache/ranger/service/XAssetService.java | 8 ++--- .../ranger/service/XAuditMapService.java | 6 ++-- .../ranger/service/XGroupUserService.java | 6 ++-- .../ranger/service/XPermMapService.java | 6 ++-- .../ranger/service/XResourceService.java | 8 ++--- .../ElasticSearchAccessAuditsServiceTest.java | 2 +- .../nestedstructureplugin/ResourceTests.java | 8 ++--- .../UserSyncMetricsProducer.java | 2 +- 39 files changed, 89 insertions(+), 89 deletions(-) diff --git a/agents-audit/src/main/java/org/apache/ranger/audit/test/TestEvents.java b/agents-audit/src/main/java/org/apache/ranger/audit/test/TestEvents.java index 91a9e75ea0..203f493139 100644 --- a/agents-audit/src/main/java/org/apache/ranger/audit/test/TestEvents.java +++ b/agents-audit/src/main/java/org/apache/ranger/audit/test/TestEvents.java @@ -102,7 +102,7 @@ public static void main(String[] args) { provider.stop(); } catch(Exception excp) { LOG.info(excp.getLocalizedMessage()); - excp.printStackTrace(); + } LOG.info("<== TestEvents.main()"); diff --git a/agents-audit/src/main/java/org/apache/ranger/audit/utils/ORCFileUtil.java b/agents-audit/src/main/java/org/apache/ranger/audit/utils/ORCFileUtil.java index 061c324332..c89d1cd23c 100644 --- a/agents-audit/src/main/java/org/apache/ranger/audit/utils/ORCFileUtil.java +++ b/agents-audit/src/main/java/org/apache/ranger/audit/utils/ORCFileUtil.java @@ -428,7 +428,7 @@ public static void main(String[] args) throws Exception { auditOrcFileUtil.log(write, events); write.close(); } catch (Exception e){ - e.printStackTrace(); + } } diff --git a/agents-audit/src/main/java/org/apache/ranger/audit/utils/RollingTimeUtil.java b/agents-audit/src/main/java/org/apache/ranger/audit/utils/RollingTimeUtil.java index f59817f7c6..4c10172cdd 100644 --- a/agents-audit/src/main/java/org/apache/ranger/audit/utils/RollingTimeUtil.java +++ b/agents-audit/src/main/java/org/apache/ranger/audit/utils/RollingTimeUtil.java @@ -260,7 +260,7 @@ public static void main(String[] args) { nextRollOvertime = rollingTimeUtil.computeNextRollingTime(rollOverPeriod); System.out.println(nextRollOvertime); } catch (Exception e1) { - e1.printStackTrace(); + } long rollOverTime = rollingTimeUtil.computeNextRollingTime(duration, null); nextRollOvertime = new Date(rollOverTime); diff --git a/agents-common/src/main/java/org/apache/ranger/admin/client/datatype/GrantRevokeData.java b/agents-common/src/main/java/org/apache/ranger/admin/client/datatype/GrantRevokeData.java index 4444959fd3..ead56fcb6a 100644 --- a/agents-common/src/main/java/org/apache/ranger/admin/client/datatype/GrantRevokeData.java +++ b/agents-common/src/main/java/org/apache/ranger/admin/client/datatype/GrantRevokeData.java @@ -150,7 +150,7 @@ public String toJson() { try { return JsonUtilsV2.objToJson(this); } catch (Exception e) { - e.printStackTrace(); + } return ""; @@ -226,7 +226,7 @@ public String toJson() { try { return JsonUtilsV2.objToJson(this); } catch (Exception e) { - e.printStackTrace(); + } return ""; diff --git a/agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerValidator.java b/agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerValidator.java index 6114225ca1..eb53bc2db9 100644 --- a/agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerValidator.java +++ b/agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerValidator.java @@ -157,7 +157,7 @@ public void test_getServiceDef() { RangerServiceDef serviceDef = mock(RangerServiceDef.class); when(_store.getServiceDefByName("good-service")).thenReturn(serviceDef); } catch (Exception e) { - e.printStackTrace(); + Assert.fail("Unexpected exception during mocking!"); } @@ -224,7 +224,7 @@ public void test_getService() { RangerService service = mock(RangerService.class); when(_store.getServiceByName("good-service")).thenReturn(service); } catch (Exception e) { - e.printStackTrace(); + Assert.fail("Unexpected exception during mocking!"); } diff --git a/agents-cred/src/test/java/org/apache/ranger/authorization/hadoop/utils/RangerCredentialProviderTest.java b/agents-cred/src/test/java/org/apache/ranger/authorization/hadoop/utils/RangerCredentialProviderTest.java index a3b83977de..271bc816ea 100644 --- a/agents-cred/src/test/java/org/apache/ranger/authorization/hadoop/utils/RangerCredentialProviderTest.java +++ b/agents-cred/src/test/java/org/apache/ranger/authorization/hadoop/utils/RangerCredentialProviderTest.java @@ -78,7 +78,7 @@ public void setup() throws Exception { System.out.println("Keystore File is NULL"); } } catch(Throwable t) { - t.printStackTrace(); + } Configuration conf = new Configuration(); @@ -170,7 +170,7 @@ private static boolean isCredentialShellInteractiveEnabled() { } } catch (Throwable e) { System.out.println("Unable to find the value of [" + fieldName + "] field in the Class [" + cs.getClass().getName() + "]. Skiping -f option"); - e.printStackTrace(); + ret = false; } diff --git a/agents-installer/src/main/java/org/apache/ranger/utils/install/XmlConfigChanger.java b/agents-installer/src/main/java/org/apache/ranger/utils/install/XmlConfigChanger.java index 270e521815..ac1dbcdfe7 100644 --- a/agents-installer/src/main/java/org/apache/ranger/utils/install/XmlConfigChanger.java +++ b/agents-installer/src/main/java/org/apache/ranger/utils/install/XmlConfigChanger.java @@ -79,7 +79,7 @@ public static void main(String[] args) { catch(Throwable t) { System.err.println("*************************************************************************"); System.err.println("******* ERROR: unable to process xml configuration changes due to error:" + t.getMessage()); - t.printStackTrace(); + System.err.println("*************************************************************************"); System.exit(1); } @@ -436,7 +436,7 @@ private void loadInstallProperties() { installProperties.load(in); } catch (IOException ioe) { System.err.println("******* ERROR: load file failure. The reason: " + ioe.getMessage()); - ioe.printStackTrace(); + } } // To support environment variable, we will add all environment variables to the Properties diff --git a/credentialbuilder/src/main/java/org/apache/ranger/credentialapi/CredentialReader.java b/credentialbuilder/src/main/java/org/apache/ranger/credentialapi/CredentialReader.java index 679b5721d4..1ec28449b7 100644 --- a/credentialbuilder/src/main/java/org/apache/ranger/credentialapi/CredentialReader.java +++ b/credentialbuilder/src/main/java/org/apache/ranger/credentialapi/CredentialReader.java @@ -88,7 +88,7 @@ public static String getDecryptedString(String CrendentialProviderPath,String al } } }catch(Exception ex){ - ex.printStackTrace(); + credential=null; } return credential; diff --git a/credentialbuilder/src/main/java/org/apache/ranger/credentialapi/buildks.java b/credentialbuilder/src/main/java/org/apache/ranger/credentialapi/buildks.java index 4ee7080cfb..79d8f857bf 100644 --- a/credentialbuilder/src/main/java/org/apache/ranger/credentialapi/buildks.java +++ b/credentialbuilder/src/main/java/org/apache/ranger/credentialapi/buildks.java @@ -51,7 +51,7 @@ public static void main(String[] args) { System.exit(1); } }catch(Exception ex){ - ex.printStackTrace(); + System.exit(1); } } @@ -109,7 +109,7 @@ public int createCredential(String args[]){ } } }catch(Exception ex){ - ex.printStackTrace(); + } return returnCode; } @@ -163,9 +163,9 @@ public int createKeyStore(String args[]){ returnCode= cs.run(finalArgs); //if response code is zero then success else failure }catch(IOException ex){ - ex.printStackTrace(); + } catch(Exception ex){ - ex.printStackTrace(); + } return returnCode; } @@ -225,9 +225,9 @@ public int createCredentialFromUserInput(){ //if response code is zero then success else failure //System.out.println("Response Code:"+returnCode); }catch(IOException ex){ - ex.printStackTrace(); + } catch(Exception ex){ - ex.printStackTrace(); + } return returnCode; } @@ -265,9 +265,9 @@ public int listCredential(String args[]){ //if response code is zero then success else failure //System.out.println("Response Code:"+returnCode); }catch(IOException ex){ - ex.printStackTrace(); + } catch(Exception ex){ - ex.printStackTrace(); + } return returnCode; } @@ -308,9 +308,9 @@ public int deleteCredential(String args[], boolean isSilentMode){ //if response code is zero then success else failure //System.out.println("Response Code:"+returnCode); }catch(IOException ex){ - ex.printStackTrace(); + } catch(Exception ex){ - ex.printStackTrace(); + } return returnCode; } @@ -369,7 +369,7 @@ public static boolean isValidCreateCommand(String command,String alias,String va System.out.println("Invalid input or runtime error! Please try again."); System.out.println("Input:"+command+" "+alias+" "+valueOption+" "+credential+" "+providerOption+" "+providerPath); displaySyntax("create", storeType); - ex.printStackTrace(); + return false; } return isValid; @@ -405,7 +405,7 @@ public static boolean isValidListCommand(String command,String providerOption,St System.out.println("Invalid input or runtime error! Please try again."); System.out.println("Input:"+command+" "+providerOption+" "+providerPath); displaySyntax("list", storeTpe); - ex.printStackTrace(); + return false; } return isValid; @@ -480,7 +480,7 @@ public String getCredential(String args[]){ System.out.println("Alias "+ alias +" does not exist!!"); } }catch(Exception ex){ - ex.printStackTrace(); + } return tempCredential; } @@ -521,7 +521,7 @@ public static boolean isValidGetCommand(String command,String alias,String provi System.out.println("Invalid input or runtime error! Please try again."); System.out.println("Input:"+command+" "+alias+" "+providerOption+" "+providerPath); displaySyntax("get", storeType); - ex.printStackTrace(); + return false; } return isValid; @@ -544,7 +544,7 @@ private static boolean isCredentialShellInteractiveEnabled() { } } catch (Throwable e) { System.out.println("Unable to find the value of [" + fieldName + "] field in the Class [" + cs.getClass().getName() + "]. Skiping -f option"); - e.printStackTrace(); + ret = false; } diff --git a/embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/ElasticSearchIndexBootStrapper.java b/embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/ElasticSearchIndexBootStrapper.java index 15a16e41fc..6e7b93c7e1 100644 --- a/embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/ElasticSearchIndexBootStrapper.java +++ b/embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/ElasticSearchIndexBootStrapper.java @@ -264,7 +264,7 @@ private boolean createIndex() { } } catch (Exception e) { LOG.severe("Unable to create Index. Reason:" + e.toString()); - e.printStackTrace(); + } } else { LOG.info("Index " + this.index + " is already created."); diff --git a/embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java b/embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java index cae9075a7b..e5b9de90a4 100644 --- a/embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java +++ b/embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java @@ -271,7 +271,7 @@ public void start() { + "] = path [" + webapp_dir + "]."); } catch (LifecycleException lce) { LOG.severe("Tomcat Server failed to start webapp:" + lce.toString()); - lce.printStackTrace(); + } if (servername.equalsIgnoreCase(ADMIN_SERVER_NAME)) { @@ -304,7 +304,7 @@ public Void run() { }); } catch (Exception e) { LOG.severe("Tomcat Server failed to start:" + e.toString()); - e.printStackTrace(); + } } else { startServer(server); @@ -347,10 +347,10 @@ private void startServer(final Tomcat server) { shutdownServer(); } catch (LifecycleException e) { LOG.severe("Tomcat Server failed to start:" + e.toString()); - e.printStackTrace(); + } catch (Exception e) { LOG.severe("Tomcat Server failed to start:" + e.toString()); - e.printStackTrace(); + } } diff --git a/hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/TestPolicyEngine.java b/hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/TestPolicyEngine.java index 7710385214..13aac0afc4 100644 --- a/hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/TestPolicyEngine.java +++ b/hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/TestPolicyEngine.java @@ -122,7 +122,7 @@ private void runTests(InputStreamReader reader, String testName) { } } catch(Throwable excp) { - excp.printStackTrace(); + } } diff --git a/hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsClient.java b/hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsClient.java index 675c9120e6..c82843a1c5 100644 --- a/hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsClient.java +++ b/hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsClient.java @@ -186,7 +186,7 @@ public static final void main(String[] args) { try { fsList = fs.listFiles(baseDir, fileNameToMatch,null); } catch (Exception e) { - e.printStackTrace(); + } if (fsList != null && fsList.size() > 0) { for(String s : fsList) { diff --git a/hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java b/hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java index 6d6bbbb693..44878a0cfe 100644 --- a/hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java +++ b/hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java @@ -773,7 +773,7 @@ public static void main(String[] args) { try { dbList = hc.getDatabaseList(args[1],null); } catch (Exception e) { - e.printStackTrace(); + } if (CollectionUtils.isEmpty(dbList)) { System.out.println("No database found with db filter [" + args[1] + "]"); @@ -808,7 +808,7 @@ else if (args.length == 4) { } } catch(Exception e) { - e.printStackTrace(); + } finally { if (hc != null) { diff --git a/jisql/src/main/java/org/apache/util/sql/Jisql.java b/jisql/src/main/java/org/apache/util/sql/Jisql.java index b3e2725504..28846e50ee 100644 --- a/jisql/src/main/java/org/apache/util/sql/Jisql.java +++ b/jisql/src/main/java/org/apache/util/sql/Jisql.java @@ -260,7 +260,7 @@ public static void main(String argv[]) { jisql.parseArgs(argv); } catch (Throwable t) { - t.printStackTrace(); + jisql.usage(); System.exit(1); } @@ -269,7 +269,7 @@ public static void main(String argv[]) { jisql.run(); } catch (Exception e) { - e.printStackTrace(); + System.exit(1); } @@ -326,12 +326,12 @@ public void run() throws Exception { catch (InstantiationException ie) { isExit=true; System.err.println("Cannot instantiate the driver class \"" + driverName + "\""); - ie.printStackTrace(System.err); + } catch (IllegalAccessException iae) { isExit=true; System.err.println("Cannot instantiate the driver class \"" + driverName + "\" because of an IllegalAccessException"); - iae.printStackTrace(System.err); + } finally { if (connection != null) { @@ -370,7 +370,7 @@ public void doIsql() throws IOException, SQLException { } catch (FileNotFoundException fnfe) { System.err.println("Unable to open file \"" + inputFileName + "\""); - fnfe.printStackTrace(System.err); + throw fnfe; } } @@ -514,7 +514,7 @@ public void doIsql() throws IOException, SQLException { throw sqle; } catch (Exception e) { - e.printStackTrace(System.err); + } if (inputQuery != null) diff --git a/jisql/src/main/java/org/apache/util/sql/MaskingThread.java b/jisql/src/main/java/org/apache/util/sql/MaskingThread.java index e4343d0591..77325aebf0 100644 --- a/jisql/src/main/java/org/apache/util/sql/MaskingThread.java +++ b/jisql/src/main/java/org/apache/util/sql/MaskingThread.java @@ -46,7 +46,7 @@ public void run() } catch (InterruptedException iex) { - iex.printStackTrace(); + } if (!stop) { diff --git a/jisql/src/main/java/org/apache/util/sql/MySQLPLRunner.java b/jisql/src/main/java/org/apache/util/sql/MySQLPLRunner.java index 308350f0e0..80f38d6af8 100644 --- a/jisql/src/main/java/org/apache/util/sql/MySQLPLRunner.java +++ b/jisql/src/main/java/org/apache/util/sql/MySQLPLRunner.java @@ -209,12 +209,12 @@ private void runScript(Connection conn, Reader reader) throws IOException, rs.close(); } } catch (Exception e) { - e.printStackTrace(); + } try { statement.close(); } catch (Exception e) { - e.printStackTrace(); + // Ignore to workaround a bug in Jakarta DBCP } Thread.yield(); @@ -324,20 +324,20 @@ public static void main(String args[]){ } catch (SQLException sqle) { - sqle.printStackTrace(); + } catch (ClassNotFoundException cnfe) { System.err.println("Cannot find the driver class \"" + driverName + "\" in the current classpath."); } catch (InstantiationException ie) { System.err.println("Cannot instantiate the driver class \"" + driverName + "\""); - ie.printStackTrace(System.err); + } catch (IllegalAccessException iae) { System.err.println("Cannot instantiate the driver class \"" + driverName + "\" because of an IllegalAccessException"); - iae.printStackTrace(System.err); + }catch (Exception sqle) { - sqle.printStackTrace(); + } finally { if (con != null) { diff --git a/kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsDBMasterkeyCorrect.java b/kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsDBMasterkeyCorrect.java index 632e728f4c..39daf77a08 100644 --- a/kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsDBMasterkeyCorrect.java +++ b/kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsDBMasterkeyCorrect.java @@ -47,7 +47,7 @@ public static void main(String[] args) throws Throwable { } new VerifyIsDBMasterkeyCorrect().verifyMasterkey(password); } catch (Exception e) { - e.printStackTrace(); + } } diff --git a/kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsHSMMasterkeyCorrect.java b/kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsHSMMasterkeyCorrect.java index e5ebeb783f..d137e74570 100644 --- a/kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsHSMMasterkeyCorrect.java +++ b/kms/src/main/java/org/apache/hadoop/crypto/key/VerifyIsHSMMasterkeyCorrect.java @@ -47,7 +47,7 @@ public static void main(String[] args) throws Throwable { } new VerifyIsHSMMasterkeyCorrect().getHSMMasterkey(hsmType, partitionName); } catch (Exception e) { - e.printStackTrace(); + } } diff --git a/kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSWebApp.java b/kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSWebApp.java index 1487beff0a..1d4ddccaef 100755 --- a/kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSWebApp.java +++ b/kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSWebApp.java @@ -222,7 +222,7 @@ public void contextInitialized(ServletContextEvent sce) { System.out.println(); System.out.println("Stacktrace:"); System.out.println("---------------------------------------------------"); - ex.printStackTrace(System.out); + System.out.println("---------------------------------------------------"); System.out.println(); System.exit(1); diff --git a/plugin-nestedstructure/src/test/java/org/apache/ranger/authorization/nestedstructure/authorizer/ExampleClient.java b/plugin-nestedstructure/src/test/java/org/apache/ranger/authorization/nestedstructure/authorizer/ExampleClient.java index af32aff996..f26e1de552 100644 --- a/plugin-nestedstructure/src/test/java/org/apache/ranger/authorization/nestedstructure/authorizer/ExampleClient.java +++ b/plugin-nestedstructure/src/test/java/org/apache/ranger/authorization/nestedstructure/authorizer/ExampleClient.java @@ -40,7 +40,7 @@ public static void main( String[] args) { System.out.println("hasAccess: "+ result.hasAccess()); System.out.println("authorizedJson: "+ result.getJson()); - result.getErrors().stream().forEach(e-> e.printStackTrace()); + result.getErrors().stream().forEach(e-> System.out.println("done"); } diff --git a/ranger-plugin-classloader/src/test/java/org/apache/ranger/plugin/classloader/test/Impl/TestChildFistClassLoader.java b/ranger-plugin-classloader/src/test/java/org/apache/ranger/plugin/classloader/test/Impl/TestChildFistClassLoader.java index 7f48c917d2..172fa77bda 100644 --- a/ranger-plugin-classloader/src/test/java/org/apache/ranger/plugin/classloader/test/Impl/TestChildFistClassLoader.java +++ b/ranger-plugin-classloader/src/test/java/org/apache/ranger/plugin/classloader/test/Impl/TestChildFistClassLoader.java @@ -38,7 +38,7 @@ public static void main(String [] args){ URL url = file.toPath().toUri().toURL(); urls = new URL[] {url}; } catch (Exception e) { - e.printStackTrace(); + } String[] libdirs = new String[] { file.getAbsolutePath() }; @@ -49,7 +49,7 @@ public static void main(String [] args){ TestPlugin testPlugin = (TestPlugin) rangerPluginClassLoader.loadClass("org.apache.ranger.plugin.classloader.test.Impl.TestPluginImpl").newInstance(); System.out.println(testPlugin.print()); } catch (Throwable t) { - t.printStackTrace(); + } } } diff --git a/ranger-tools/src/main/java/org/apache/ranger/sizing/RangerMemSizing.java b/ranger-tools/src/main/java/org/apache/ranger/sizing/RangerMemSizing.java index 5b6f513393..880a821984 100644 --- a/ranger-tools/src/main/java/org/apache/ranger/sizing/RangerMemSizing.java +++ b/ranger-tools/src/main/java/org/apache/ranger/sizing/RangerMemSizing.java @@ -344,7 +344,7 @@ private static CommandLine parseArgs(String[] args) { new HelpFormatter().printHelp("RangerMemSizing", options); } catch (ParseException excp) { System.out.println("Failed to parse arguments"); - excp.printStackTrace(System.out); + } return null; @@ -369,7 +369,7 @@ private void log(String msg) { private void log(String msg, Throwable excp) { out.println(DATE_FORMAT.format(new Date()) + ": " +msg); - excp.printStackTrace(out); + } private RangerPolicyEngineOptions getPolicyEngineOptions() { diff --git a/security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java b/security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java index ed1ea03768..1e0666b80f 100644 --- a/security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java +++ b/security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java @@ -2481,7 +2481,7 @@ public void getPoliciesInCSV(List policies, IOUtils.write(sb.toString(), out, "UTF-8"); } catch (Exception e) { LOG.error("Error while generating report file " + CSVFileName, e); - e.printStackTrace(); + } finally { try { if (out != null) { diff --git a/security-admin/src/main/java/org/apache/ranger/credentialapi/CredentialReader.java b/security-admin/src/main/java/org/apache/ranger/credentialapi/CredentialReader.java index f63828c200..0c3410ace6 100644 --- a/security-admin/src/main/java/org/apache/ranger/credentialapi/CredentialReader.java +++ b/security-admin/src/main/java/org/apache/ranger/credentialapi/CredentialReader.java @@ -86,7 +86,7 @@ public static String getDecryptedString(String CrendentialProviderPath,String al } } }catch(Exception ex){ - ex.printStackTrace(); + credential=null; } return credential; diff --git a/security-admin/src/main/java/org/apache/ranger/db/XXModuleDefDao.java b/security-admin/src/main/java/org/apache/ranger/db/XXModuleDefDao.java index c5b0daf445..fa15e052c3 100644 --- a/security-admin/src/main/java/org/apache/ranger/db/XXModuleDefDao.java +++ b/security-admin/src/main/java/org/apache/ranger/db/XXModuleDefDao.java @@ -102,7 +102,7 @@ public List findModuleURLOfPemittedModules(Long userId) { .getResultList(); } catch (Exception e) { - e.printStackTrace(); + return null; } } diff --git a/security-admin/src/main/java/org/apache/ranger/patch/BaseLoader.java b/security-admin/src/main/java/org/apache/ranger/patch/BaseLoader.java index 9b52e4a7d6..960a42e8ac 100644 --- a/security-admin/src/main/java/org/apache/ranger/patch/BaseLoader.java +++ b/security-admin/src/main/java/org/apache/ranger/patch/BaseLoader.java @@ -134,7 +134,7 @@ public void run() { // Thread.sleep(60 * 1000); } catch (InterruptedException e) { // TODO Auto-generated catch block - e.printStackTrace(); + } } logger.info("Monitor Thread exiting!!!"); diff --git a/security-admin/src/main/java/org/apache/ranger/patch/PatchAtlasForClassificationResource_J10047.java b/security-admin/src/main/java/org/apache/ranger/patch/PatchAtlasForClassificationResource_J10047.java index a6e39d82b7..85732ff464 100644 --- a/security-admin/src/main/java/org/apache/ranger/patch/PatchAtlasForClassificationResource_J10047.java +++ b/security-admin/src/main/java/org/apache/ranger/patch/PatchAtlasForClassificationResource_J10047.java @@ -114,7 +114,7 @@ public void execLoad() { addResourceClassificationsInServiceDef(); createAdditionalPolicyWithClassificationForExistingEntityClassificationPolicy(); } catch (Exception e) { - e.printStackTrace(); + throw new RuntimeException("Error while updating " + EMBEDDED_SERVICEDEF_ATLAS_NAME + " service-def"); } logger.info("<== PatchAtlasForClassificationResource_J10047.execLoad()"); diff --git a/security-admin/src/main/java/org/apache/ranger/patch/cliutil/ChangeUserNameUtil.java b/security-admin/src/main/java/org/apache/ranger/patch/cliutil/ChangeUserNameUtil.java index 4be81d69c9..fe8b1868ad 100644 --- a/security-admin/src/main/java/org/apache/ranger/patch/cliutil/ChangeUserNameUtil.java +++ b/security-admin/src/main/java/org/apache/ranger/patch/cliutil/ChangeUserNameUtil.java @@ -122,7 +122,7 @@ public void updateUserName() { System.exit(1); } } catch (Exception e) { - e.printStackTrace(); + } } else{ diff --git a/security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java b/security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java index d2d76733ea..6fadda8689 100644 --- a/security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java +++ b/security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java @@ -3853,7 +3853,7 @@ public ResponseEntity> deleteClusterServices(@PathPa } catch (Throwable e) { //log and proceed LOG.warn("Skipping deletion of service with ID="+serviceId); - e.printStackTrace(); + deleteResponse.setIsDeleted(Boolean.FALSE); deleteResponse.setErrorMsg(e.getMessage()); } diff --git a/security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKrbFilter.java b/security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKrbFilter.java index 29c1bcdef4..bd0d42f3b1 100644 --- a/security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKrbFilter.java +++ b/security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKrbFilter.java @@ -450,7 +450,7 @@ public void doFilter(ServletRequest request, ServletResponse response, FilterCha token = getToken(httpRequest); } catch (AuthenticationException ex) { - ex.printStackTrace(); + LOG.warn("AuthenticationToken ignored: " + ex.getMessage()); // will be sent back in a 401 unless filter authenticates authenticationEx = ex; @@ -504,7 +504,7 @@ public Principal getUserPrincipal() { } } catch (AuthenticationException ex) { // exception from the filter itself is fatal - ex.printStackTrace(); + errCode = HttpServletResponse.SC_FORBIDDEN; authenticationEx = ex; LOG.warn("Authentication exception: " + ex.getMessage(), ex); diff --git a/security-admin/src/main/java/org/apache/ranger/service/XAssetService.java b/security-admin/src/main/java/org/apache/ranger/service/XAssetService.java index b937cff04c..737e778e83 100644 --- a/security-admin/src/main/java/org/apache/ranger/service/XAssetService.java +++ b/security-admin/src/main/java/org/apache/ranger/service/XAssetService.java @@ -326,13 +326,13 @@ public List getTransactionLog(VXAsset vObj, XXAsset mObj, String actio } } catch (IllegalArgumentException e) { - e.printStackTrace(); + } catch (IllegalAccessException e) { - e.printStackTrace(); + } catch (NoSuchFieldException e) { - e.printStackTrace(); + } catch (SecurityException e) { - e.printStackTrace(); + } return trxLogList; diff --git a/security-admin/src/main/java/org/apache/ranger/service/XAuditMapService.java b/security-admin/src/main/java/org/apache/ranger/service/XAuditMapService.java index 3fe0832e26..ed2dab0638 100644 --- a/security-admin/src/main/java/org/apache/ranger/service/XAuditMapService.java +++ b/security-admin/src/main/java/org/apache/ranger/service/XAuditMapService.java @@ -138,11 +138,11 @@ public List getTransactionLog(VXAuditMap vObj, VXAuditMap mObj, String } } catch (IllegalArgumentException e) { - e.printStackTrace(); + } catch (IllegalAccessException e) { - e.printStackTrace(); + } catch (SecurityException e) { - e.printStackTrace(); + } return trxLogList; diff --git a/security-admin/src/main/java/org/apache/ranger/service/XGroupUserService.java b/security-admin/src/main/java/org/apache/ranger/service/XGroupUserService.java index 5cfcb785c6..6c6dd8c26a 100644 --- a/security-admin/src/main/java/org/apache/ranger/service/XGroupUserService.java +++ b/security-admin/src/main/java/org/apache/ranger/service/XGroupUserService.java @@ -254,11 +254,11 @@ public List getTransactionLog(VXGroupUser vObj, XXGroupUser mObj, Stri } } catch (IllegalArgumentException e) { - e.printStackTrace(); + } catch (IllegalAccessException e) { - e.printStackTrace(); + } catch (SecurityException e) { - e.printStackTrace(); + } return trxLogList; diff --git a/security-admin/src/main/java/org/apache/ranger/service/XPermMapService.java b/security-admin/src/main/java/org/apache/ranger/service/XPermMapService.java index 2fa22fa683..79edecea09 100644 --- a/security-admin/src/main/java/org/apache/ranger/service/XPermMapService.java +++ b/security-admin/src/main/java/org/apache/ranger/service/XPermMapService.java @@ -246,11 +246,11 @@ else if(value == null || "null".equalsIgnoreCase(value) || stringUtil.isEmpty(va } } catch (IllegalArgumentException e) { - e.printStackTrace(); + } catch (IllegalAccessException e) { - e.printStackTrace(); + } catch (SecurityException e) { - e.printStackTrace(); + } return trxLogList; diff --git a/security-admin/src/main/java/org/apache/ranger/service/XResourceService.java b/security-admin/src/main/java/org/apache/ranger/service/XResourceService.java index 57b20b7e77..4349ba6331 100644 --- a/security-admin/src/main/java/org/apache/ranger/service/XResourceService.java +++ b/security-admin/src/main/java/org/apache/ranger/service/XResourceService.java @@ -579,13 +579,13 @@ public List getTransactionLog(VXResource vObj, XXResource mObj, String } } catch (IllegalArgumentException e) { - e.printStackTrace(); + } catch (IllegalAccessException e) { - e.printStackTrace(); + } catch (NoSuchFieldException e) { - e.printStackTrace(); + } catch (SecurityException e) { - e.printStackTrace(); + } if(trxLogList.isEmpty()){ diff --git a/security-admin/src/test/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsServiceTest.java b/security-admin/src/test/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsServiceTest.java index 605f38e783..592fc0c589 100644 --- a/security-admin/src/test/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsServiceTest.java +++ b/security-admin/src/test/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsServiceTest.java @@ -68,7 +68,7 @@ public void testQuery() { try { LOGGER.warn(writer.writeValueAsString(x)); } catch (JsonProcessingException e) { - e.printStackTrace(); + } }); } diff --git a/tagsync/src/test/java/org/apache/ranger/tagsync/nestedstructureplugin/ResourceTests.java b/tagsync/src/test/java/org/apache/ranger/tagsync/nestedstructureplugin/ResourceTests.java index 05ca49e82c..8ef740bcf6 100644 --- a/tagsync/src/test/java/org/apache/ranger/tagsync/nestedstructureplugin/ResourceTests.java +++ b/tagsync/src/test/java/org/apache/ranger/tagsync/nestedstructureplugin/ResourceTests.java @@ -77,7 +77,7 @@ public void test_RangerEntityJsonField() { assertEquals("Resource element field value does not match", Collections.singletonList("channel"), resource.getResourceElements().get("field").getValues()); assertEquals("serviceName does not match expected value", "null_nestedstructure", resource.getServiceName()); } catch(Exception e) { - e.printStackTrace(); + fail("An error occurred while processing resource"); } @@ -95,7 +95,7 @@ public void test_RangerEntityJsonField() { assertEquals("Resource element field value does not match", Collections.singletonList("channel"), resource.getResourceElements().get("field").getValues()); assertEquals("serviceName does not match expected value", "dev_nestedstructure", resource.getServiceName()); } catch(Exception e) { - e.printStackTrace(); + fail("An error occurred while processing resource"); } } @@ -116,7 +116,7 @@ public void test_RangerEntityJsonObject() { assertEquals("Resource element schema value does not match", Collections.singletonList("json_object.foo.v1"), resource.getResourceElements().get("schema").getValues()); assertEquals("serviceName does not match expected value", "null_nestedstructure", resource.getServiceName()); } catch (Exception e) { - e.printStackTrace(); + fail("An error occurred while processing resource"); } @@ -132,7 +132,7 @@ public void test_RangerEntityJsonObject() { assertEquals("Resource element schema value does not match", Collections.singletonList("json_object.foo.v1"), resource.getResourceElements().get("schema").getValues()); assertEquals("serviceName does not match expected value", "dev_nestedstructure", resource.getServiceName()); } catch (Exception e) { - e.printStackTrace(); + fail("An error occurred while processing resource"); } } diff --git a/ugsync/src/main/java/org/apache/ranger/usergroupsync/UserSyncMetricsProducer.java b/ugsync/src/main/java/org/apache/ranger/usergroupsync/UserSyncMetricsProducer.java index 1e80c5da87..9c09564f59 100644 --- a/ugsync/src/main/java/org/apache/ranger/usergroupsync/UserSyncMetricsProducer.java +++ b/ugsync/src/main/java/org/apache/ranger/usergroupsync/UserSyncMetricsProducer.java @@ -37,7 +37,7 @@ public static void main(String[] args) { userSyncMetrics.run(); /* * try { userSyncMetrics.writeJVMMetrics(); } catch (Throwable e) { // TODO - * Auto-generated catch block e.printStackTrace(); } + * Auto-generated catch block } */ }