Skip to content

Commit 57e6d34

Browse files
authored
Create code owners (subscriptions-project#536)
1 parent 036dd9e commit 57e6d34

File tree

2 files changed

+21
-0
lines changed

2 files changed

+21
-0
lines changed

CONTRIBUTING.md

+1
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ A few things to note:
5555
* The Subscribe with Google Project follows the [fork & pull](https://help.github.com/articles/using-pull-requests/#fork--pull) model for accepting contributions.
5656
* Familiarize yourself with our [Design Principles](contributing/DESIGN_PRINCIPLES.md).
5757
* We follow [Google's JavaScript Style Guide](https://google.github.io/styleguide/jsguide.html). More generally make sure to follow the same comment and coding style as the rest of the project.
58+
* For reviewing your code, choose an owner from CODEOWNERS for the file or directories you change. When adding new files, choose owners of the directory where you wish to add files to be your reviewer. If no owner is listed for the file or directory you want to change, include the global owners at the top of the CODEOWNERS file.
5859
* Include tests when contributing code. There are plenty of tests that you can use as examples.
5960

6061
## Contributor License Agreement

docs/CODEOWNERS

+20
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
@jpettit, @dvoytenko, @chenshay
2+
src/proto/ @sohanirao
3+
src/api/propensity-api.js @sohanirao
4+
src/runtime/analytics-service.js @sohanirao
5+
src/runtime/analytics-service-test.js @sohanirao
6+
src/runtime/contributions-flow.js @diparikh
7+
src/runtime/contributions-flow-test.js @dparikh
8+
src/runtime/link-account-flow.js @sohanirao @dparikh @dvoytenko
9+
src/runtime/link-account-flow-test.js @sohanirao @dparikh @dvoytenko
10+
src/runtime/login-notification-api.js @chenshay
11+
src/runtime/login-prompt-api.js @chenshay
12+
src/runtime/login-prompt-api-test.js @chenshay
13+
src/runtime/offers-flow.js @dparikh
14+
src/runtime/offers-flow-test.js @dparikh
15+
src/runtime/propensity.js @sohanirao
16+
src/runtime/propensity-test.js @sohanirao
17+
src/runtime/propensity-server.js @sohanirao
18+
src/runtime/propensity-server-test.js @sohanirao
19+
src/runtime/wait-for-subscription-lookup-api.js @chenshay
20+
src/runtime/wait-for-subscription-lookup-api-test.js @chenshay

0 commit comments

Comments
 (0)