-
Notifications
You must be signed in to change notification settings - Fork 17
RDKEMW-9595: IAnalytics: Added additionalContext to sendEvent #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RDKEMW-9595: IAnalytics: Added additionalContext to sendEvent #582
Conversation
Reason for change: additionalContex for Analytics.sendEvent Test Procedure: Build and use new param Risks: Low Version: Patch Signed-off-by: Adrian Muzyka <[email protected]>
1cc1995 to
018d532
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new additionalContext parameter to the Analytics.sendEvent API to allow passing additional context information in JSON format as an opaque string without schema validation.
Key Changes:
- Added
additionalContextparameter to theSendEventmethod signature in the IAnalytics interface - Updated JSON schema definition to include the new parameter
- Updated API documentation with parameter descriptions and examples
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apis/Analytics/IAnalytics.h | Added additionalContext parameter to SendEvent method signature with @opaque annotation |
| tools/json_generator/output/Analytics/Analytics.json | Added additionalContext definition in the schema with description and example |
| docs/apis/AnalyticsPlugin.md | Updated parameter table and example to include the new optional additionalContext parameter; also includes unrelated configuration section updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Reason for change: additionalContex for Analytics.sendEvent
Test Procedure: Build and use new param
Risks: Low
Version: Patch