Skip to content

Conversation

@ananyasingh-vantiva
Copy link

Reason for change:
Residual EthWAN configuration files (/nvram/ETHWAN_ENABLE and /nvram/ethwan_interface) were not being removed during factory reset, which could lead to unnecessary configuration checks, potential conflicts, or performance issues when the device is expected to operate in DOCSIS mode. Removing these files ensures the device starts cleanly in DOCSIS mode after a factory reset.

Test Procedure:

  1. Enable EthWAN mode on the device using following command : dmcli eRT setv Device.X_RDKCENTRAL-COM_EthernetWAN.SelectedOperationalMode string Ethernet (This creates /nvram/ETHWAN_ENABLE and /nvram/ethwan_interface).
  2. Perform a factory reset.
  3. After reboot, verify that both /nvram/ETHWAN_ENABLE and /nvram/ethwan_interface files are deleted.
  4. Confirm that the device boots up in DOCSIS mode and operates normally. Command: dmcli eRT getv Device.X_RDKCENTRAL-COM_EthernetWAN.SelectedOperationalMode
  5. Check system logs for any errors related to WAN mode selection or configuration.
  6. Repeat the process to ensure consistent behavior.

Risks:

  1. If the removal commands are too broad or misused, there is a risk of deleting unintended files from NVRAM.
  2. If other processes depend on these files for valid reasons, their removal could impact those functionalities.
  3. Regression risk in factory reset or WAN mode selection logic if not properly tested.

Signed Off By:
Ananya Singh ([email protected])

@ananyasingh-vantiva ananyasingh-vantiva requested a review from a team as a code owner September 9, 2025 06:16
@ananyasingh-vantiva
Copy link
Author

recheck

@pradeeptakdas pradeeptakdas changed the title RDKBDEV-3287 : Optimize Device Performance- Remove Residual EthWAN Files from nvram During Factory Reset RDKCOM-5446: RDKBDEV-3287 : Optimize Device Performance- Remove Residual EthWAN Files from nvram During Factory Reset Sep 28, 2025
@CLAassistant
Copy link

CLAassistant commented Oct 17, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 3 committers have signed the CLA.

❌ ananyasingh-vantiva
❌ Sukanya673
❌ GoutamD2905
You have signed the CLA already but the status is still pending? Let us recheck it.

…les from nvram During Factory Reset

Reason for change:
Residual EthWAN configuration files (/nvram/ETHWAN_ENABLE and /nvram/ethwan_interface) were not being removed during factory reset, which could lead to unnecessary configuration checks, potential conflicts, or performance issues when the device is expected to operate in DOCSIS mode. Removing these files ensures the device starts cleanly in DOCSIS mode after a factory reset.

Test Procedure:

1. Enable EthWAN mode on the device using following command :
dmcli eRT setv Device.X_RDKCENTRAL-COM_EthernetWAN.SelectedOperationalMode string Ethernet
(This creates /nvram/ETHWAN_ENABLE and /nvram/ethwan_interface).
2. Perform a factory reset.
3. After reboot, verify that both /nvram/ETHWAN_ENABLE and /nvram/ethwan_interface files are deleted.
4. Confirm that the device boots up in DOCSIS mode and operates normally.
Command: dmcli eRT getv Device.X_RDKCENTRAL-COM_EthernetWAN.SelectedOperationalMode
5.Check system logs for any errors related to WAN mode selection or configuration.
6. Repeat the process to ensure consistent behavior.

Risks:

If the removal commands are too broad or misused, there is a risk of deleting unintended files from NVRAM.
If other processes depend on these files for valid reasons, their removal could impact those functionalities.
Regression risk in factory reset or WAN mode selection logic if not properly tested.

Signed Off By:
Ananya Singh ([email protected])
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants