Skip to content

Commit ff5fffb

Browse files
committed
Merge branch 'release/1.0.8'
2 parents 49dcea2 + ca57a38 commit ff5fffb

File tree

4 files changed

+22
-11
lines changed

4 files changed

+22
-11
lines changed

CHANGELOG.md

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,23 @@ All notable changes to this project will be documented in this file. Dates are d
44

55
Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
66

7+
#### [1.0.8](https://github.com/rdkcentral/rdkNativeScript/compare/1.0.7...1.0.8)
8+
9+
- RDKEMW-8952 : Switching between Xumo Fast Channels and Vipa activated… [`#71`](https://github.com/rdkcentral/rdkNativeScript/pull/71)
10+
- RDKEMW-8952 : Switching between Xumo Fast Channels and Vipa activated Channels [`505914d`](https://github.com/rdkcentral/rdkNativeScript/commit/505914dbfa6dbe842c7ec46e169ccca47ca6032b)
11+
- Merge tag '1.0.7' into develop [`d367c14`](https://github.com/rdkcentral/rdkNativeScript/commit/d367c14f8efa22be9632ba692ed658321402a0e3)
12+
713
#### [1.0.7](https://github.com/rdkcentral/rdkNativeScript/compare/1.0.6...1.0.7)
814

9-
- Switching between Xumo Fast Channels and Vipa activated… [`#68`](https://github.com/rdkcentral/rdkNativeScript/pull/68)
15+
> 30 September 2025
16+
17+
- RDKEMW-8952 : Switching between Xumo Fast Channels and Vipa activated… [`#68`](https://github.com/rdkcentral/rdkNativeScript/pull/68)
1018
- RDKEMW-5610 : L1 test cases for jsruntime [`#66`](https://github.com/rdkcentral/rdkNativeScript/pull/66)
1119
- Deploy fossid_integration_stateless_diffscan_target_repo action [`#67`](https://github.com/rdkcentral/rdkNativeScript/pull/67)
1220
- Deploy cla action [`#40`](https://github.com/rdkcentral/rdkNativeScript/pull/40)
1321
- Update CODEOWNERS [`#63`](https://github.com/rdkcentral/rdkNativeScript/pull/63)
14-
- Switching between Xumo Fast Channels and Vipa activated Channels [`228cf8b`](https://github.com/rdkcentral/rdkNativeScript/commit/228cf8bfdde6d7f7d991805193038b392bc0e89b)
22+
- 1.0.7 release changelog updates [`0f3be4f`](https://github.com/rdkcentral/rdkNativeScript/commit/0f3be4fecad9213a4d86c828e978c29199e5d190)
23+
- RDKEMW-8952 : Switching between Xumo Fast Channels and Vipa activated Channels [`228cf8b`](https://github.com/rdkcentral/rdkNativeScript/commit/228cf8bfdde6d7f7d991805193038b392bc0e89b)
1524
- Merge tag '1.0.6' into develop [`afdf341`](https://github.com/rdkcentral/rdkNativeScript/commit/afdf341c4f81e7019d76f207c7b428dbd0ffc00d)
1625

1726
#### [1.0.6](https://github.com/rdkcentral/rdkNativeScript/compare/1.0.5...1.0.6)

src/jsc/JavaScriptContext.cpp

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,6 @@ static AAMPJSBindings* gAAMPJSBindings = nullptr;
6262
//BIG CHANGE
6363
extern void functionLoadModule(JSGlobalContextRef ref, JSObjectRef globalObjectRef, char* buffer, int len, char* name);
6464

65-
static const char* envValue = std::getenv("NATIVEJS_DUMP_NETWORKMETRIC");
66-
6765
JSContextGroupRef globalContextGroup()
6866
{
6967
static JSContextGroupRef gGroupRef = JSContextGroupCreate();
@@ -134,13 +132,17 @@ void JavaScriptContext::loadAAMPJSBindingsLib()
134132
if (nullptr == gAAMPJSBindings->PlayerLibHandle)
135133
{
136134
static const char *aampJSBindingsLib = "libaampjsbindings.so";
135+
// This is required for NativeJS Plugin
136+
#if 0
137137
static const char *jscLib = "libJavaScriptCore.so";
138138
jscLibHandle = dlopen(jscLib, RTLD_NOW | RTLD_GLOBAL);
139139
if (!jscLibHandle)
140140
{
141141
std::cout<<"dlopen error for jsc library " << dlerror() << std::endl;
142142
}
143-
void *aampJSBindingsLibHandle = dlopen(aampJSBindingsLib, RTLD_NOW | RTLD_GLOBAL);
143+
#endif
144+
145+
void *aampJSBindingsLibHandle = dlopen(aampJSBindingsLib, RTLD_NOW | RTLD_GLOBAL);
144146
if (aampJSBindingsLibHandle)
145147
{
146148
gAAMPJSBindings->PlayerLibHandle = aampJSBindingsLibHandle;
@@ -165,7 +167,7 @@ void JavaScriptContext::unloadAAMPJSBindingsLib()
165167
if (nullptr != gAAMPJSBindings->PlayerLibHandle)
166168
{
167169
dlclose(gAAMPJSBindings->PlayerLibHandle);
168-
dlclose(jscLibHandle);
170+
//dlclose(jscLibHandle);
169171

170172
}
171173
}
@@ -481,9 +483,7 @@ void JavaScriptContext::onMetricsData (NetworkMetrics *net)
481483
rtString key = net->url;
482484
mNetworkMetricsData->set(key, rtValue((void *)net));
483485

484-
if (envValue) {
485-
dumpNetworkMetricData(net, this->getUrl());
486-
}
486+
dumpNetworkMetricData(net, this->getUrl());
487487
}
488488

489489
void JavaScriptContext::dumpNetworkMetricData(NetworkMetrics *metrics, std::string appUrl)

src/jsc/JavaScriptEngine.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,6 +194,7 @@ void JavaScriptEngine::collectGarbage()
194194
{
195195
if (gTopLevelContext)
196196
{
197-
JSSynchronousGarbageCollectForDebugging(gTopLevelContext);
197+
//JSSynchronousGarbageCollectForDebugging(gTopLevelContext);
198+
JSGarbageCollect(gTopLevelContext);
198199
}
199200
}

src/jsc/JavaScriptUtils.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ std::thread::id gMainThreadId;
6868

6969
static std::list<std::function<void ()>> gPendingFun;
7070
static std::mutex gDispatchMutex;
71+
static const char* envValue = std::getenv("NATIVEJS_DUMP_NETWORKMETRIC");
7172

7273
struct TimeoutInfo
7374
{
@@ -232,7 +233,7 @@ class rtHttpRequestEx : public rtHttpRequest
232233
resp->setHeaders(downloadRequest->headerData(), downloadRequest->headerDataSize());
233234
resp->setDownloadedData(downloadRequest->downloadedData(), downloadRequest->downloadedDataSize());
234235

235-
if (mMetricsListener)
236+
if (mMetricsListener && envValue)
236237
{
237238
rtLogWarn("metriclistener");
238239
NetworkMetrics *metrics = new NetworkMetrics();

0 commit comments

Comments
 (0)