DELIA-58758: [Coverity] Various medium impact issues identified in aamp - part 1

Reason for change: Coverity issues are addressed as requested from security team.

Signed-off-by: Deepan Ragunathan <[email protected]>
Change-Id: I3b0d426710c0baf384d5d82b084a4223e82d46ae
(cherry picked from commit b5a29d7)

Author: aahmed878

fragmentcollector_mpd.cpp

@@ -86,7 +86,7 @@
 #define MEDIATYPE_IMAGE "image"
 
 // weights used for autio/subtitle track-selection heuristic
-#define AAMP_LANGUAGE_SCORE 1000000000L  /**< Top priority:  matching language **/
+#define AAMP_LANGUAGE_SCORE 1000000000UL  /**< Top priority:  matching language **/
 #define AAMP_SCHEME_ID_SCORE 100000000L  /**< 2nd priority to scheme id matching **/
 #define AAMP_LABEL_SCORE 10000000L       /**< 3rd priority to  label matching **/
 #define AAMP_ROLE_SCORE 1000000L         /**< 4th priority to role/rendition matching **/
@@ -6614,7 +6614,7 @@ std::vector<AudioTrackInfo> &ac4Tracks, std::string &audioTrackIndex)
 				/**< No valid representation found in this Adaptation, discard this adaptation */
 				score = 0;
 			}
-			AAMPLOG_INFO( "track#%d::%d -  score = %d", iAdaptationSet, audioRepresentationIndex,  score );
+			AAMPLOG_INFO( "track#%d::%d -  score = %llu", iAdaptationSet, audioRepresentationIndex,  score );
 			if( score > bestScore )
 			{
 				bestScore = score;
@@ -6627,7 +6627,7 @@ std::vector<AudioTrackInfo> &ac4Tracks, std::string &audioTrackIndex)
 	if (CodecType == eAUDIO_DOLBYAC4)
 	{
 		/* TODO: Cuurently current Audio track is updating only for AC4 need mechanism to update for other tracks also */
-		AAMPLOG_INFO( "Audio Track selected index - %s - language : %s rendition : %s - codec - %s  score = %d", selectedAudioTrack.index.c_str(),
+		AAMPLOG_INFO( "Audio Track selected index - %s - language : %s rendition : %s - codec - %s  score = %llu", selectedAudioTrack.index.c_str(),
 		selectedAudioTrack.language.c_str(), selectedAudioTrack.rendition.c_str(), selectedAudioTrack.codec.c_str(),  bestScore );
 	}
 	return bestTrack;
@@ -12287,9 +12287,9 @@ AAMPStatusType  StreamAbstractionAAMP_MPD::EnableAndSetLiveOffsetForLLDashPlayba
 					stLLServiceData.targetLatency = TargetLatency*1000;
 				}
 			}
-			double latencyOffsetMin = stLLServiceData.minLatency/1000;
-			double latencyOffsetMax = stLLServiceData.maxLatency/1000;
-			double TargetLatencyWrtWallClockTime = stLLServiceData.targetLatency/1000;
+			double latencyOffsetMin = stLLServiceData.minLatency/(double)1000;
+			double latencyOffsetMax = stLLServiceData.maxLatency/(double)1000;
+			double TargetLatencyWrtWallClockTime = stLLServiceData.targetLatency/(double)1000;
 			AAMPLOG_WARN("StreamAbstractionAAMP_MPD:[LL-Dash] Min Latency: %ld Max Latency: %ld Target Latency: %ld",(long)latencyOffsetMin,(long)latencyOffsetMax,(long)TargetLatency);
 
 			//Ignore Low latency setting
@@ -12366,13 +12366,13 @@ bool StreamAbstractionAAMP_MPD::GetLowLatencyParams(const MPD* mpd,AampLLDashSer
 		for (unsigned iPeriod = 0; iPeriod < numPeriods; iPeriod++)
 		{
 			IPeriod *period = mpd->GetPeriods().at(iPeriod);
-			if(IsEmptyPeriod(period, mIsFogTSB))
-			{
-				// Empty Period . Ignore processing, continue to next.
-				continue;
-			}
 			if(NULL != period )
 			{
+				if(IsEmptyPeriod(period, mIsFogTSB))
+				{
+					// Empty Period . Ignore processing, continue to next.
+					continue;
+				}
 				const std::vector<IAdaptationSet *> adaptationSets = period->GetAdaptationSets();
 				if (adaptationSets.size() > 0)
 				{

isobmff/isobmffbuffer.cpp

@@ -274,14 +274,20 @@ bool IsoBmffBuffer::getTimeScaleInternal(const std::vector<Box*> *boxes, uint32_
 		Box *box = boxes->at(i);
 		if (IS_TYPE(box->getType(), Box::MVHD))
 		{
-			timeScale = dynamic_cast<MvhdBox *>(box)->getTimeScale();
-			ret = true;
+			MvhdBox *mvhdBox = dynamic_cast<MvhdBox *>(box);
+			if(mvhdBox){
+				timeScale = mvhdBox->getTimeScale();
+				ret = true;
+			}
 		}
 		else if (IS_TYPE(box->getType(), Box::MDHD))
 		{
-			timeScale = dynamic_cast<MdhdBox *>(box)->getTimeScale();
-			ret = true;
-			foundMdhd = true;
+			MdhdBox *mdhdBox = dynamic_cast<MdhdBox *>(box);
+			if(mdhdBox) {
+				timeScale = mdhdBox->getTimeScale();
+				ret = true;
+				foundMdhd = true;
+			}
 		}
 		if (box->hasChildren())
 		{
@@ -311,15 +317,21 @@ void IsoBmffBuffer::printBoxesInternal(const std::vector<Box*> *boxes)
 		AAMPLOG_WARN("Offset[%u] Type[%s] Size[%u]", box->getOffset(), box->getType(), box->getSize());
 		if (IS_TYPE(box->getType(), Box::TFDT))
 		{
-			AAMPLOG_WARN("****Base Media Decode Time: %lld", dynamic_cast<TfdtBox *>(box)->getBaseMDT());
+			if(dynamic_cast<TfdtBox *>(box)) {
+				AAMPLOG_WARN("****Base Media Decode Time: %lld", dynamic_cast<TfdtBox *>(box)->getBaseMDT());
+			}
 		}
 		else if (IS_TYPE(box->getType(), Box::MVHD))
 		{
-			AAMPLOG_WARN("**** TimeScale from MVHD: %u", dynamic_cast<MvhdBox *>(box)->getTimeScale());
+			if(dynamic_cast<MvhdBox *>(box)) {
+				AAMPLOG_WARN("**** TimeScale from MVHD: %u", dynamic_cast<MvhdBox *>(box)->getTimeScale());
+			}
 		}
 		else if (IS_TYPE(box->getType(), Box::MDHD))
 		{
-			AAMPLOG_WARN("**** TimeScale from MDHD: %u", dynamic_cast<MdhdBox *>(box)->getTimeScale());
+			if(dynamic_cast<MdhdBox *>(box)) {
+				AAMPLOG_WARN("**** TimeScale from MDHD: %u", dynamic_cast<MdhdBox *>(box)->getTimeScale());
+			}
 		}
 
 		if (box->hasChildren())

main_aamp.cpp

@@ -599,7 +599,7 @@ void PlayerInstanceAAMP::SetRateInternal(float rate,int overshootcorrection)
 	//Hack For DELIA-51318 convert the incoming rates into acceptable rates
 	if(ISCONFIGSET(eAAMPConfig_RepairIframes))
 	{
-		AAMPLOG_WARN("mRepairIframes is true, setting actual rate %d for the received rate %f", getWorkingTrickplayRate(rate), rate);
+		AAMPLOG_WARN("mRepairIframes is true, setting actual rate %f for the received rate %f", getWorkingTrickplayRate(rate), rate);
 		rate = getWorkingTrickplayRate(rate);
 	}
 

priv_aamp.cpp

@@ -2409,7 +2409,7 @@ void PrivateInstanceAAMP::NotifySpeedChanged(float rate, bool changeState)
 	//Hack For DELIA-51318 convert the incoming rates into acceptable rates
 	if(ISCONFIGSET_PRIV(eAAMPConfig_RepairIframes))
 	{
-		AAMPLOG_WARN("mRepairIframes is set, sending pseudo rate %d for the actual rate %d", getPseudoTrickplayRate(rate), rate);
+		AAMPLOG_WARN("mRepairIframes is set, sending pseudo rate %f for the actual rate %f", getPseudoTrickplayRate(rate), rate);
 		SendEvent(std::make_shared<SpeedChangedEvent>(getPseudoTrickplayRate(rate)),AAMP_EVENT_ASYNC_MODE);
 	}
 	else