Skip to content

Commit fde65a3

Browse files
fix: type to mode (#725)
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 parent 15d2f31 commit fde65a3

File tree

5 files changed

+24
-32
lines changed

5 files changed

+24
-32
lines changed

assets/index.less

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -134,22 +134,22 @@
134134
}
135135
}
136136

137-
&-type-spinner {
137+
&-mode-spinner {
138138
display: inline-flex;
139139
align-items: center;
140140
}
141141

142-
&-type-spinner &-handler {
142+
&-mode-spinner &-handler {
143143
flex: 0 0 20px;
144144
line-height: 26px;
145145
height: 100%;
146146
}
147147

148-
&-type-spinner &-handler-up {
148+
&-mode-spinner &-handler-up {
149149
border-bottom: 0;
150150
border-left: 1px solid #d9d9d9;
151151
}
152-
&-type-spinner &-handler-down {
152+
&-mode-spinner &-handler-down {
153153
border-top: 0;
154154
border-right: 1px solid #d9d9d9;
155155
}

docs/demo/spinner.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export default () => {
2020
<div style={{ margin: 10 }}>
2121
<h3>Controlled</h3>
2222
<InputNumber
23-
type="spinner"
23+
mode="spinner"
2424
aria-label="Simple number input example"
2525
min={-8}
2626
max={10}
@@ -54,7 +54,7 @@ export default () => {
5454
<hr />
5555
<h3>Uncontrolled</h3>
5656
<InputNumber
57-
type="spinner"
57+
mode="spinner"
5858
style={{ width: 100 }}
5959
onChange={onChange}
6060
min={-99}
@@ -65,7 +65,7 @@ export default () => {
6565
<hr />
6666
<h3>!changeOnBlur</h3>
6767
<InputNumber
68-
type="spinner"
68+
mode="spinner"
6969
style={{ width: 100 }}
7070
min={-9}
7171
max={9}

src/InputNumber.tsx

Lines changed: 10 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ export interface InputNumberProps<T extends ValueType = ValueType>
6464
/** value will show as string */
6565
stringMode?: boolean;
6666

67-
type?: 'input' | 'spinner';
67+
mode?: 'input' | 'spinner';
6868

6969
defaultValue?: T;
7070
value?: T | null;
@@ -122,7 +122,7 @@ type InternalInputNumberProps = Omit<InputNumberProps, 'prefix' | 'suffix'> & {
122122
const InternalInputNumber = React.forwardRef(
123123
(props: InternalInputNumberProps, ref: React.Ref<HTMLInputElement>) => {
124124
const {
125-
type,
125+
mode,
126126
prefixCls,
127127
className,
128128
style,
@@ -601,21 +601,13 @@ const InternalInputNumber = React.forwardRef(
601601
};
602602

603603
const upNode = (
604-
<StepHandler
605-
{...sharedHandlerProps}
606-
action="up"
607-
disabled={upDisabled}
608-
>
604+
<StepHandler {...sharedHandlerProps} action="up" disabled={upDisabled}>
609605
{upHandler}
610606
</StepHandler>
611607
);
612608

613609
const downNode = (
614-
<StepHandler
615-
{...sharedHandlerProps}
616-
action="down"
617-
disabled={downDisabled}
618-
>
610+
<StepHandler {...sharedHandlerProps} action="down" disabled={downDisabled}>
619611
{downHandler}
620612
</StepHandler>
621613
);
@@ -642,7 +634,7 @@ const InternalInputNumber = React.forwardRef(
642634
onCompositionEnd={onCompositionEnd}
643635
onBeforeInput={onBeforeInput}
644636
>
645-
{type === 'input' && controls && (
637+
{mode === 'input' && controls && (
646638
<div
647639
className={clsx(`${prefixCls}-handler-wrap`, classNames?.actions)}
648640
style={styles?.actions}
@@ -652,7 +644,7 @@ const InternalInputNumber = React.forwardRef(
652644
</div>
653645
)}
654646

655-
{type === 'spinner' && controls && downNode}
647+
{mode === 'spinner' && controls && downNode}
656648

657649
<div className={`${inputClassName}-wrap`}>
658650
<input
@@ -672,15 +664,15 @@ const InternalInputNumber = React.forwardRef(
672664
/>
673665
</div>
674666

675-
{type === 'spinner' && controls && upNode}
667+
{mode === 'spinner' && controls && upNode}
676668
</div>
677669
);
678670
},
679671
);
680672

681673
const InputNumber = React.forwardRef<InputNumberRef, InputNumberProps>((props, ref) => {
682674
const {
683-
type = 'input',
675+
mode = 'input',
684676
disabled,
685677
style,
686678
prefixCls = 'rc-input-number',
@@ -715,7 +707,7 @@ const InputNumber = React.forwardRef<InputNumberRef, InputNumberProps>((props, r
715707
return (
716708
<SemanticContext.Provider value={memoizedValue}>
717709
<BaseInput
718-
className={clsx(`${prefixCls}-type-${type}`, className)}
710+
className={clsx(`${prefixCls}-mode-${mode}`, className)}
719711
triggerFocus={focus}
720712
prefixCls={prefixCls}
721713
value={value}
@@ -736,7 +728,7 @@ const InputNumber = React.forwardRef<InputNumberRef, InputNumberProps>((props, r
736728
ref={holderRef}
737729
>
738730
<InternalInputNumber
739-
type={type}
731+
mode={mode}
740732
prefixCls={prefixCls}
741733
disabled={disabled}
742734
ref={inputFocusRef}

tests/__snapshots__/baseInput.test.tsx.snap

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ exports[`baseInput addon should render properly 1`] = `
44
<div>
55
<div>
66
<div
7-
class="rc-input-group-wrapper rc-input-type-input"
7+
class="rc-input-group-wrapper rc-input-mode-input"
88
>
99
<div
1010
class="rc-input-wrapper rc-input-group"
@@ -64,7 +64,7 @@ exports[`baseInput addon should render properly 1`] = `
6464
<br />
6565
<br />
6666
<div
67-
class="rc-input-group-wrapper rc-input-type-input"
67+
class="rc-input-group-wrapper rc-input-mode-input"
6868
>
6969
<div
7070
class="rc-input-wrapper rc-input-group"
@@ -128,7 +128,7 @@ exports[`baseInput addon should render properly 1`] = `
128128
exports[`baseInput prefix should render properly 1`] = `
129129
<div>
130130
<div
131-
class="rc-input-affix-wrapper rc-input-type-input"
131+
class="rc-input-affix-wrapper rc-input-mode-input"
132132
>
133133
<span
134134
class="rc-input-prefix"

tests/props.test.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -407,10 +407,10 @@ describe('InputNumber.Props', () => {
407407
});
408408
});
409409

410-
describe('type props', () => {
411-
it('render spinner type', () => {
412-
const { container } = render(<InputNumber value={1} type="spinner" />);
413-
expect(container.querySelector('.rc-input-number')).toHaveClass('rc-input-number-type-spinner');
410+
describe('mode props', () => {
411+
it('render spinner mode', () => {
412+
const { container } = render(<InputNumber value={1} mode="spinner" />);
413+
expect(container.querySelector('.rc-input-number')).toHaveClass('rc-input-number-mode-spinner');
414414
});
415415
});
416416

0 commit comments

Comments
 (0)