Skip to content

Fix optional dependencies shifting dependency indices, allow nulls in dependency arrays #444

Fix optional dependencies shifting dependency indices, allow nulls in dependency arrays

Fix optional dependencies shifting dependency indices, allow nulls in dependency arrays #444

Triggered via pull request June 24, 2025 20:56
@robhoganrobhogan
synchronize #1522
pr1522
Status Cancelled
Total duration 1m 51s
Artifacts

build-test-and-deploy.yml

on: pull_request
Matrix: test
Type check, lint, smoke test
43s
Type check, lint, smoke test
Tests with coverage
1m 32s
Tests with coverage
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 2 warnings
test (windows-latest, lts/*) / Tests [Node.js lts/*, windows-latest, Using yarn.lock]
Canceling since a higher priority waiting request for build-test-and-deploy-refs/pull/1522/merge exists
test (windows-latest, lts/-1) / Tests [Node.js lts/-1, windows-latest, Using yarn.lock]
Canceling since a higher priority waiting request for build-test-and-deploy-refs/pull/1522/merge exists
test (windows-latest, 18.18.0) / Tests [Node.js 18.18.0, windows-latest, Using yarn.lock]
Canceling since a higher priority waiting request for build-test-and-deploy-refs/pull/1522/merge exists
facebook/metro/build-test-and-deploy
Canceling since a higher priority waiting request for build-test-and-deploy-refs/pull/1522/merge exists
facebook/metro/build-test-and-deploy
Canceling since a higher priority waiting request for build-test-and-deploy-refs/pull/1522/merge exists
facebook/metro/build-test-and-deploy
Canceling since a higher priority waiting request for build-test-and-deploy-refs/pull/1522/merge exists
facebook/metro/build-test-and-deploy
Canceling since a higher priority waiting request for build-test-and-deploy-refs/pull/1522/merge exists
Type check, lint, smoke test: packages/metro-transform-plugins/src/addParamsToDefineCall.js#L26
Always use `== null` or `!= null` to check for `null` AND `undefined` values (even if you just expect either of them). Within fb we treat them as equal and `== null` checks for both