Remove unused inlineRequires params from BabelTransformer API

Summary:
X-link: react/react-native#38771

Changelog: [Internal]

Metro has been passing `inlineRequires: false` to Babel transformers for the last 5 years (D9636747), as the inline requires transform had been hoisted into the transform worker. Here we clean up the unused code paths in React Native's implementations of the Metro Babel transformer API, and the unused properties in the API itself.

Reviewed By: GijsWeterings

Differential Revision: D48034441

fbshipit-source-id: d24a793962942a3c87461ffbade847ea749dac95

Author: motiz88

packages/metro-babel-transformer/src/__tests__/transform-test.js

@@ -41,7 +41,6 @@ it('exposes the correct absolute path to a source file to plugins', () => {
       enableBabelRCLookup: false,
       globalPrefix: '__metro__',
       hot: false,
-      inlineRequires: false,
       minify: false,
       platform: null,
       publicPath: 'test',

packages/metro-babel-transformer/src/index.js

@@ -33,15 +33,14 @@ type BabelTransformerOptions = $ReadOnly<{
   experimentalImportSupport?: boolean,
   hermesParser?: boolean,
   hot: boolean,
-  inlineRequires: boolean,
-  nonInlinedRequires?: $ReadOnlyArray<string>,
   minify: boolean,
   unstable_disableES6Transforms?: boolean,
   platform: ?string,
   projectRoot: string,
   publicPath: string,
   unstable_transformProfile?: TransformProfile,
   globalPrefix: string,
+  inlineRequires?: void,
   ...
 }>;
 

packages/metro-babel-transformer/types/index.d.ts

@@ -23,8 +23,6 @@ export interface BabelTransformerOptions {
   readonly experimentalImportSupport?: boolean;
   readonly hermesParser?: boolean;
   readonly hot: boolean;
-  readonly inlineRequires: boolean;
-  readonly nonInlinedRequires?: ReadonlyArray<string>;
   readonly minify: boolean;
   readonly unstable_disableES6Transforms?: boolean;
   readonly platform: string | null;

packages/metro-transform-worker/src/index.js

@@ -570,19 +570,15 @@ function getBabelTransformArgs(
   {options, config, projectRoot}: TransformationContext,
   plugins?: Plugins = [],
 ): BabelTransformerArgs {
+  const {inlineRequires: _, ...babelTransformerOptions} = options;
   return {
     filename: file.filename,
     options: {
-      ...options,
+      ...babelTransformerOptions,
       enableBabelRCLookup: config.enableBabelRCLookup,
       enableBabelRuntime: config.enableBabelRuntime,
       globalPrefix: config.globalPrefix,
       hermesParser: config.hermesParser,
-      // Inline requires are now performed at a secondary step. We cannot
-      // unfortunately remove it from the internal transformer, since this one
-      // is used by other tooling, and this would affect it.
-      inlineRequires: false,
-      nonInlinedRequires: [],
       projectRoot,
       publicPath: config.publicPath,
     },