Skip to content

Commit 24c126d

Browse files
huntiemeta-codesync[bot]
authored andcommitted
Fix set-version script not updating dependencies under private/ (#55083)
Summary: Pull Request resolved: #55083 D86534510 broke our release workflow, as the intentionally narrowed package set for `set-version` unintentionally meant that `dependencies`/`devDependencies` were no longer completely applied — breaking `yarn` install. Fix and add clarification comments. Changelog: [Internal] Reviewed By: alanleedev Differential Revision: D90268470 fbshipit-source-id: ba731edc0f248cccf44b34f746236d383c318768
1 parent 9c4b92f commit 24c126d

1 file changed

Lines changed: 13 additions & 3 deletions

File tree

scripts/releases/set-version.js

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,22 +71,32 @@ async function setVersion(
7171
version /*: string */,
7272
skipReactNativeVersion /*: boolean */ = false,
7373
) /*: Promise<void> */ {
74-
const packages = await getPackages({
74+
// Packages to set the new versions of. This excludes packages under
75+
// private/, which are not versioned.
76+
const packagesToVersion = await getPackages({
7577
includeReactNative: true,
7678
forceIncludeRNTester: true,
7779
});
7880
const newPackageVersions = Object.fromEntries(
79-
Object.keys(packages).map(packageName => [
81+
Object.keys(packagesToVersion).map(packageName => [
8082
packageName,
8183
packageName === 'react-native' && skipReactNativeVersion
8284
? '1000.0.0'
8385
: version,
8486
]),
8587
);
8688

89+
// Packages to apply updated versions in (dependencies/devDependencies). This
90+
// is all packages and the workspace root.
8791
const packagesToUpdate = [
8892
await getWorkspaceRoot(),
89-
...Object.values(packages),
93+
...Object.values(
94+
await getPackages({
95+
includeReactNative: true,
96+
includePrivate: true,
97+
forceIncludeRNTester: true,
98+
}),
99+
),
90100
];
91101

92102
// Update all workspace packages

0 commit comments

Comments
 (0)