Reduce visbility of JSCRuntime target (#57093)

javache · facebook-github-bot · commit 3de1f76d65bf · 2026-06-08T02:20:44.000-07:00
Summary:

This is only pulled in by a few targets.

Changelog: [Internal]

Reviewed By: christophpurrer

Differential Revision: D107651646
diff --git a/packages/react-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTJscInstance.mm b/packages/react-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTJscInstance.mm
@@ -10,9 +10,10 @@
 
 namespace facebook::react {
 
-RCTJscInstance::RCTJscInstance() {}
+RCTJscInstance::RCTJscInstance() = default;
 
-std::unique_ptr<JSRuntime> RCTJscInstance::createJSRuntime(std::shared_ptr<MessageQueueThread> msgQueueThread) noexcept
+std::unique_ptr<JSRuntime> RCTJscInstance::createJSRuntime(
+    std::shared_ptr<MessageQueueThread> /*msgQueueThread*/) noexcept
 {
   return std::make_unique<JSIRuntimeHolder>(jsc::makeJSCRuntime());
 }

Original file line number	Diff line number	Diff line change
`@@ -10,9 +10,10 @@`
`10`	`10`
`11`	`11`	`namespace facebook::react {`
`12`	`12`
`13`		`-RCTJscInstance::RCTJscInstance() {}`
	`13`	`+RCTJscInstance::RCTJscInstance() = default;`
`14`	`14`
`15`		`-std::unique_ptr<JSRuntime> RCTJscInstance::createJSRuntime(std::shared_ptr<MessageQueueThread> msgQueueThread) noexcept`
	`15`	`+std::unique_ptr<JSRuntime> RCTJscInstance::createJSRuntime(`
	`16`	`+ std::shared_ptr<MessageQueueThread> /msgQueueThread/) noexcept`
`16`	`17`	`{`
`17`	`18`	`return std::make_unique<JSIRuntimeHolder>(jsc::makeJSCRuntime());`
`18`	`19`	`}`