Skip to content

Commit 4589667

Browse files
tjzelmeta-codesync[bot]
authored andcommitted
fix: inability to disable hermesV1 on Android (#55399)
Summary: Changing the line in `ReactPlugin.kt` that always set `hermesV1Enabled` to `true` even if it was explicitly disabled, accidentally omitted in #54989. In recent update of hermes V1 binary a file `RuntimeAdapter.h` was removed. ## Changelog: [ANDROID] [FIXED] - ReactPlugin.kt always setting `hermesV1Enabled` to `true` Pull Request resolved: #55399 Test Plan: Build React Native from source on latest 0.84 RC, disable hermesV1 and see that it compiles now. Reviewed By: cipolleschi Differential Revision: D92267385 Pulled By: cortinico fbshipit-source-id: 58ecae6d3064995ef9e63ddbd67ac04db2a1126b
1 parent 1f6d57f commit 4589667

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

  • packages/gradle-plugin/react-native-gradle-plugin/src/main/kotlin/com/facebook/react

packages/gradle-plugin/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/ReactPlugin.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@ class ReactPlugin : Plugin<Project> {
5555
project,
5656
)
5757

58-
if (project.rootProject.isHermesV1Enabled) {
59-
rootExtension.hermesV1Enabled.set(true)
58+
if (!project.rootProject.isHermesV1Enabled) {
59+
rootExtension.hermesV1Enabled.set(false)
6060
}
6161

6262
// App Only Configuration

0 commit comments

Comments
 (0)