Commit 4589667
fix: inability to disable hermesV1 on Android (#55399)
Summary:
Changing the line in `ReactPlugin.kt` that always set `hermesV1Enabled` to `true` even if it was explicitly disabled, accidentally omitted in #54989.
In recent update of hermes V1 binary a file `RuntimeAdapter.h` was removed.
## Changelog:
[ANDROID] [FIXED] - ReactPlugin.kt always setting `hermesV1Enabled` to `true`
Pull Request resolved: #55399
Test Plan: Build React Native from source on latest 0.84 RC, disable hermesV1 and see that it compiles now.
Reviewed By: cipolleschi
Differential Revision: D92267385
Pulled By: cortinico
fbshipit-source-id: 58ecae6d3064995ef9e63ddbd67ac04db2a1126b1 parent 1f6d57f commit 4589667
1 file changed
Lines changed: 2 additions & 2 deletions
File tree
- packages/gradle-plugin/react-native-gradle-plugin/src/main/kotlin/com/facebook/react
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | | - | |
59 | | - | |
| 58 | + | |
| 59 | + | |
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
| |||
0 commit comments