Add IgnoreStringLiterals in DefaultDevSupportManagerFactory class

Summary:
Adding IgnoreStringLiterals in DefaultDevSupportManagerFactory class to prevent proguard to keep the BridgeDevSupportManager class

changelog: [internal] internal

Reviewed By: alanleedev

Differential Revision: D72090836

Author: mdvacca

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DefaultDevSupportManagerFactory.kt

@@ -16,13 +16,15 @@ import com.facebook.react.devsupport.interfaces.DevSupportManager
 import com.facebook.react.devsupport.interfaces.PausedInDebuggerOverlayManager
 import com.facebook.react.devsupport.interfaces.RedBoxHandler
 import com.facebook.react.packagerconnection.RequestHandler
+import com.facebook.redex.annotations.IgnoreStringLiterals
 
 /**
  * A simple factory that creates instances of [DevSupportManager] implementations. Uses reflection
  * to create BridgeDevSupportManager if it exists. This allows ProGuard to strip that class and its
  * dependencies in release builds. If the class isn't found, [PerftestDevSupportManager] is returned
  * instead.
  */
+@IgnoreStringLiterals
 internal class DefaultDevSupportManagerFactory : DevSupportManagerFactory {
 
   override fun create(
@@ -47,15 +49,9 @@ internal class DefaultDevSupportManagerFactory : DevSupportManagerFactory {
           // trying to return the full support DevSupportManager and if it fails, then just
           // return PerftestDevSupportManager.
 
-          // ProGuard is surprisingly smart in this case and will keep a class if it detects a call
-          // to
-          // Class.forName() with a static string. So instead we generate a quasi-dynamic string to
-          // confuse it.
-          val className =
-              StringBuilder(DEVSUPPORT_IMPL_PACKAGE)
-                  .append(".")
-                  .append(DEVSUPPORT_IMPL_CLASS)
-                  .toString()
+          // @IgnoreStringLiterals annotation is used to enable ProGuard to strip out the
+          // BridgeDevSupportManager class
+          val className = "com.facebook.react.devsupport.BridgeDevSupportManager"
           val devSupportManagerClass = Class.forName(className)
           val constructor =
               devSupportManagerClass.getConstructor(
@@ -121,9 +117,4 @@ internal class DefaultDevSupportManagerFactory : DevSupportManagerFactory {
             devLoadingViewManager,
             pausedInDebuggerOverlayManager)
       }
-
-  private companion object {
-    private const val DEVSUPPORT_IMPL_PACKAGE = "com.facebook.react.devsupport"
-    private const val DEVSUPPORT_IMPL_CLASS = "BridgeDevSupportManager"
-  }
 }