Skip to content

Commit 5e0f723

Browse files
mdvaccameta-codesync[bot]
authored andcommitted
Fix MissingOverrideAnnotation: Add @OverRide to getRootViewTag and setRootViewTag (#55980)
Summary: Pull Request resolved: #55980 Fixed MissingOverrideAnnotation lint errors in ReactRootView.java. Added Override annotation to getRootViewTag() and setRootViewTag() methods which override methods from a superclass but were missing the annotation. changelog: [internal] internal Reviewed By: OmarBafagih Differential Revision: D95412652 fbshipit-source-id: 4a230fec3fee83c0bd91bfbc2651dc463b92fa19
1 parent f596bb3 commit 5e0f723

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactRootView.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -868,6 +868,7 @@ protected void finalize() throws Throwable {
868868
+ " or in the onDestroyView() of your hosting Fragment.");
869869
}
870870

871+
@Override
871872
public int getRootViewTag() {
872873
return mRootViewTag;
873874
}
@@ -876,6 +877,7 @@ private boolean isRootViewTagSet() {
876877
return mRootViewTag != 0 && mRootViewTag != NO_ID;
877878
}
878879

880+
@Override
879881
public void setRootViewTag(int rootViewTag) {
880882
mRootViewTag = rootViewTag;
881883
}

0 commit comments

Comments
 (0)