Remove componentStackType from source code (#55229)

Summary:
Pull Request resolved: #55229

All component stacks now use the native JS Error stack frame format which gets properly symbolicated. This removes the legacy/stack distinction since the legacy format (custom React string format) is no longer used.

After this change, all component stacks will be symbolicated, improving the debugging experience.

Changelog: [Internal]

Reviewed By: vzaidman, javache

Differential Revision: D90888223

fbshipit-source-id: ac0455b3194ccffba8f7102efd42efc25d17a0db

Author: rickhanlonii

packages/react-native/Libraries/LogBox/Data/LogBoxData.js

@@ -13,7 +13,6 @@ import type {LogLevel} from './LogBoxLog';
 import type {
   Category,
   ComponentStack,
-  ComponentStackType,
   ExtendedExceptionData,
   Message,
 } from './parseLogBoxLog';
@@ -32,7 +31,6 @@ export type LogData = Readonly<{
   message: Message,
   category: Category,
   componentStack: ComponentStack,
-  componentStackType: ComponentStackType | null,
   stack?: string,
 }>;
 
@@ -238,7 +236,6 @@ export function addLog(log: LogData): void {
           stack,
           category: log.category,
           componentStack: log.componentStack,
-          componentStackType: log.componentStackType || 'legacy',
         }),
       );
     } catch (error: unknown) {

packages/react-native/Libraries/LogBox/Data/LogBoxLog.js

@@ -13,7 +13,6 @@ import type {
   Category,
   CodeFrame,
   ComponentStack,
-  ComponentStackType,
   Message,
 } from './parseLogBoxLog';
 
@@ -61,7 +60,6 @@ export type LogBoxLogData = Readonly<{
   message: Message,
   stack: Stack,
   category: string,
-  componentStackType?: ComponentStackType,
   componentStack: ComponentStack,
   codeFrame?: ?CodeFrame,
   isComponentError: boolean,
@@ -74,7 +72,6 @@ class LogBoxLog {
   type: ?string;
   category: Category;
   componentStack: ComponentStack;
-  componentStackType: ComponentStackType;
   stack: Stack;
   count: number;
   level: LogLevel;
@@ -113,7 +110,6 @@ class LogBoxLog {
     this.stack = data.stack;
     this.category = data.category;
     this.componentStack = data.componentStack;
-    this.componentStackType = data.componentStackType || 'legacy';
     this.codeFrame = data.codeFrame;
     this.isComponentError = data.isComponentError;
     this.extraData = data.extraData;
@@ -132,9 +128,6 @@ class LogBoxLog {
   }
 
   getAvailableComponentStack(): ComponentStack {
-    if (this.componentStackType === 'legacy') {
-      return this.componentStack;
-    }
     return this.symbolicatedComponentStack.status === 'COMPLETE'
       ? this.symbolicatedComponentStack.componentStack
       : this.componentStack;
@@ -180,7 +173,7 @@ class LogBoxLog {
     }
     if (
       this.componentStack != null &&
-      this.componentStackType === 'stack' &&
+      this.componentStack.length > 0 &&
       this.symbolicatedComponentStack.status !== 'PENDING' &&
       this.symbolicatedComponentStack.status !== 'COMPLETE'
     ) {
@@ -192,6 +185,7 @@ class LogBoxLog {
         data => {
           this.updateComponentStackStatus(
             null,
+            // TODO: we shouldn't need to convert back to ComponentStack any more
             convertStackToComponentStack(data.stack),
             data?.codeFrame,
             callback,

packages/react-native/Libraries/LogBox/Data/__tests__/LogBoxData-test.js

@@ -65,7 +65,6 @@ const addLogs = (logs: Array<string>, options: void | {flush: boolean}) => {
       },
       category: message,
       componentStack: [],
-      componentStackType: null,
     });
     if (options == null || options.flush !== false) {
       jest.runOnlyPendingTimers();

packages/react-native/Libraries/LogBox/Data/__tests__/LogBoxLog-test.js

@@ -47,7 +47,6 @@ function getLogBoxLog() {
     message: {content: '...', substitutions: []},
     stack: createStack(['A', 'B', 'C']),
     category: 'Message category...',
-    componentStackType: 'stack',
     componentStack: createComponentStack(['A', 'B', 'C']),
     codeFrame: null,
   });