Skip to content

Commit 906468f

Browse files
cipolleschirobhogan
authored andcommitted
[RN][CI]Fix Windows CI
1 parent 710d499 commit 906468f

5 files changed

Lines changed: 18 additions & 18 deletions

File tree

.github/actions/build-hermesc-windows/action.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,23 +14,23 @@ runs:
1414
uses: actions/download-artifact@v4
1515
with:
1616
name: hermes-workspace
17-
path: 'D:\tmp\hermes'
17+
path: 'C:\tmp\hermes'
1818
- name: Set up workspace
1919
shell: powershell
2020
run: |
21-
mkdir -p D:\tmp\hermes\osx-bin
21+
mkdir -p C:\tmp\hermes\osx-bin
2222
mkdir -p .\packages\react-native\sdks\hermes
23-
cp -r -Force D:\tmp\hermes\hermes\* .\packages\react-native\sdks\hermes\.
23+
cp -r -Force C:\tmp\hermes\hermes\* .\packages\react-native\sdks\hermes\.
2424
cp -r -Force .\packages\react-native\sdks\hermes-engine\utils\* .\packages\react-native\sdks\hermes\.
2525
- name: Windows cache
2626
uses: actions/cache@v4
2727
with:
2828
key: v3-hermes-${{ github.job }}-windows-${{ inputs.hermes-version }}-${{ inputs.react-native-version }}
2929
path: |
30-
D:\tmp\hermes\win64-bin\
31-
D:\tmp\hermes\hermes\icu\
32-
D:\tmp\hermes\hermes\deps\
33-
D:\tmp\hermes\hermes\build_release\
30+
C:\tmp\hermes\win64-bin\
31+
C:\tmp\hermes\hermes\icu\
32+
C:\tmp\hermes\hermes\deps\
33+
C:\tmp\hermes\hermes\build_release\
3434
- name: setup-msbuild
3535
uses: microsoft/setup-msbuild@v1.3.2
3636
- name: Set up workspace
@@ -83,4 +83,4 @@ runs:
8383
uses: actions/upload-artifact@v4.3.4
8484
with:
8585
name: hermes-win64-bin
86-
path: D:\tmp\hermes\win64-bin\
86+
path: C:\tmp\hermes\win64-bin\

.github/workflows/nightly.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -119,9 +119,9 @@ jobs:
119119
runs-on: windows-2025
120120
needs: prepare_hermes_workspace
121121
env:
122-
HERMES_WS_DIR: 'D:\tmp\hermes'
123-
HERMES_TARBALL_ARTIFACTS_DIR: 'D:\tmp\hermes\hermes-runtime-darwin'
124-
HERMES_OSXBIN_ARTIFACTS_DIR: 'D:\tmp\hermes\osx-bin'
122+
HERMES_WS_DIR: 'C:\tmp\hermes'
123+
HERMES_TARBALL_ARTIFACTS_DIR: 'C:\tmp\hermes\hermes-runtime-darwin'
124+
HERMES_OSXBIN_ARTIFACTS_DIR: 'C:\tmp\hermes\osx-bin'
125125
ICU_URL: "https://github.com/unicode-org/icu/releases/download/release-64-2/icu4c-64_2-Win64-MSVC2017.zip"
126126
MSBUILD_DIR: 'C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\MSBuild\Current\Bin'
127127
CMAKE_DIR: 'C:\Program Files\CMake\bin'

.github/workflows/publish-release.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -116,9 +116,9 @@ jobs:
116116
runs-on: windows-2025
117117
needs: prepare_hermes_workspace
118118
env:
119-
HERMES_WS_DIR: 'D:\tmp\hermes'
120-
HERMES_TARBALL_ARTIFACTS_DIR: 'D:\tmp\hermes\hermes-runtime-darwin'
121-
HERMES_OSXBIN_ARTIFACTS_DIR: 'D:\tmp\hermes\osx-bin'
119+
HERMES_WS_DIR: 'C:\tmp\hermes'
120+
HERMES_TARBALL_ARTIFACTS_DIR: 'C:\tmp\hermes\hermes-runtime-darwin'
121+
HERMES_OSXBIN_ARTIFACTS_DIR: 'C:\tmp\hermes\osx-bin'
122122
ICU_URL: "https://github.com/unicode-org/icu/releases/download/release-64-2/icu4c-64_2-Win64-MSVC2017.zip"
123123
MSBUILD_DIR: 'C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\MSBuild\Current\Bin'
124124
CMAKE_DIR: 'C:\Program Files\CMake\bin'

.github/workflows/test-all.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -400,9 +400,9 @@ jobs:
400400
runs-on: windows-2025
401401
needs: prepare_hermes_workspace
402402
env:
403-
HERMES_WS_DIR: 'D:\tmp\hermes'
404-
HERMES_TARBALL_ARTIFACTS_DIR: 'D:\tmp\hermes\hermes-runtime-darwin'
405-
HERMES_OSXBIN_ARTIFACTS_DIR: 'D:\tmp\hermes\osx-bin'
403+
HERMES_WS_DIR: 'C:\tmp\hermes'
404+
HERMES_TARBALL_ARTIFACTS_DIR: 'C:\tmp\hermes\hermes-runtime-darwin'
405+
HERMES_OSXBIN_ARTIFACTS_DIR: 'C:\tmp\hermes\osx-bin'
406406
ICU_URL: "https://github.com/unicode-org/icu/releases/download/release-64-2/icu4c-64_2-Win64-MSVC2017.zip"
407407
MSBUILD_DIR: 'C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\MSBuild\Current\Bin'
408408
CMAKE_DIR: 'C:\Program Files\CMake\bin'

packages/gradle-plugin/shared/src/test/kotlin/com/facebook/react/utils/OsTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ class OsTest {
5555

5656
@Test
5757
fun unixifyPath_withAWindowsPath_convertsItCorrectly() {
58-
val aWindowsPath = "D:\\just\\a\\windows\\path\\"
58+
val aWindowsPath = "C:\\just\\a\\windows\\path\\"
5959

6060
assertThat("/D/just/a/windows/path/").isEqualTo(aWindowsPath.unixifyPath())
6161
}

0 commit comments

Comments
 (0)