Fix CQS signal readability-implicit-bool-conversion in xplat/js/react-native-github/packages (#53596)

generatedunixname89002005287564 · facebook-github-bot · commit 95b187bb3706 · 2025-09-04T03:56:08.000-07:00
Summary: Pull Request resolved: #53596 Reviewed By: rshest Differential Revision: D81574342 fbshipit-source-id: 9423d3341a9c349d7e7519b5acb7ee41f6ceb2b3
diff --git a/packages/react-native/Libraries/NativeAnimation/Nodes/RCTAnimatedNode.mm b/packages/react-native/Libraries/NativeAnimation/Nodes/RCTAnimatedNode.mm
@@ -16,7 +16,7 @@ @implementation RCTAnimatedNode {
 
 - (instancetype)initWithTag:(NSNumber *)tag config:(NSDictionary<NSString *, id> *)config
 {
-  if ((self = [super init])) {
+  if ((self = [super init]) != nullptr) {
     _nodeTag = tag;
     _config = [config copy];
   }
@@ -37,42 +37,42 @@ - (instancetype)initWithTag:(NSNumber *)tag config:(NSDictionary<NSString *, id>
 
 - (void)addChild:(RCTAnimatedNode *)child
 {
-  if (!_childNodes) {
+  if (_childNodes == nullptr) {
     _childNodes = [NSMapTable strongToWeakObjectsMapTable];
   }
-  if (child) {
+  if (child != nullptr) {
     [_childNodes setObject:child forKey:child.nodeTag];
     [child onAttachedToNode:self];
   }
 }
 
 - (void)removeChild:(RCTAnimatedNode *)child
 {
-  if (!_childNodes) {
+  if (_childNodes == nullptr) {
     return;
   }
-  if (child) {
+  if (child != nullptr) {
     [_childNodes removeObjectForKey:child.nodeTag];
     [child onDetachedFromNode:self];
   }
 }
 
 - (void)onAttachedToNode:(RCTAnimatedNode *)parent
 {
-  if (!_parentNodes) {
+  if (_parentNodes == nullptr) {
     _parentNodes = [NSMapTable strongToWeakObjectsMapTable];
   }
-  if (parent) {
+  if (parent != nullptr) {
     [_parentNodes setObject:parent forKey:parent.nodeTag];
   }
 }
 
 - (void)onDetachedFromNode:(RCTAnimatedNode *)parent
 {
-  if (!_parentNodes) {
+  if (_parentNodes == nullptr) {
     return;
   }
-  if (parent) {
+  if (parent != nullptr) {
     [_parentNodes removeObjectForKey:parent.nodeTag];
   }
 }
diff --git a/packages/react-native/Libraries/NativeAnimation/Nodes/RCTInterpolationAnimatedNode.mm b/packages/react-native/Libraries/NativeAnimation/Nodes/RCTInterpolationAnimatedNode.mm
@@ -86,7 +86,7 @@ @implementation RCTInterpolationAnimatedNode {
 
 - (instancetype)initWithTag:(NSNumber *)tag config:(NSDictionary<NSString *, id> *)config
 {
-  if ((self = [super initWithTag:tag config:config])) {
+  if ((self = [super initWithTag:tag config:config]) != nullptr) {
     _inputRange = config[@"inputRange"];
 
     NSArray *outputRangeConfig = config[@"outputRange"];
@@ -104,7 +104,7 @@ - (instancetype)initWithTag:(NSNumber *)tag config:(NSDictionary<NSString *, id>
       switch (_outputType) {
         case RCTInterpolationOutputColor: {
           UIColor *color = [RCTConvert UIColor:value];
-          [outputRange addObject:color ? color : [UIColor whiteColor]];
+          [outputRange addObject:(color != nullptr) ? color : [UIColor whiteColor]];
           break;
         }
         case RCTInterpolationOutputString:
@@ -141,7 +141,7 @@ - (void)onDetachedFromNode:(RCTAnimatedNode *)parent
 - (void)performUpdate
 {
   [super performUpdate];
-  if (!_parentNode) {
+  if (_parentNode == nullptr) {
     return;
   }
 
diff --git a/packages/react-native/Libraries/NativeAnimation/Nodes/RCTObjectAnimatedNode.mm b/packages/react-native/Libraries/NativeAnimation/Nodes/RCTObjectAnimatedNode.mm
@@ -48,7 +48,7 @@ - (id)_convertValue:(id)value
   if ([value isKindOfClass:[NSDictionary class]]) {
     NSDictionary<NSString *, id> *dict = (NSDictionary *)value;
     id nodeTag = [dict objectForKey:NODE_TAG_KEY];
-    if (nodeTag && [nodeTag isKindOfClass:[NSNumber class]]) {
+    if ((nodeTag != nullptr) && [nodeTag isKindOfClass:[NSNumber class]]) {
       RCTAnimatedNode *node = [self.parentNodes objectForKey:(NSNumber *)nodeTag];
       if ([node isKindOfClass:[RCTValueAnimatedNode class]]) {
         RCTValueAnimatedNode *valueNode = (RCTValueAnimatedNode *)node;
diff --git a/packages/react-native/Libraries/NativeAnimation/Nodes/RCTStyleAnimatedNode.mm b/packages/react-native/Libraries/NativeAnimation/Nodes/RCTStyleAnimatedNode.mm
@@ -18,7 +18,7 @@ @implementation RCTStyleAnimatedNode {
 
 - (instancetype)initWithTag:(NSNumber *)tag config:(NSDictionary<NSString *, id> *)config
 {
-  if ((self = [super initWithTag:tag config:config])) {
+  if ((self = [super initWithTag:tag config:config]) != nullptr) {
     _propsDictionary = [NSMutableDictionary new];
   }
   return self;
@@ -36,11 +36,11 @@ - (void)performUpdate
   NSDictionary<NSString *, NSNumber *> *style = self.config[@"style"];
   [style enumerateKeysAndObjectsUsingBlock:^(NSString *property, NSNumber *nodeTag, __unused BOOL *stop) {
     RCTAnimatedNode *node = [self.parentNodes objectForKey:nodeTag];
-    if (node) {
+    if (node != nullptr) {
       if ([node isKindOfClass:[RCTValueAnimatedNode class]]) {
         RCTValueAnimatedNode *valueAnimatedNode = (RCTValueAnimatedNode *)node;
         id animatedObject = valueAnimatedNode.animatedObject;
-        if (animatedObject) {
+        if (animatedObject != nullptr) {
           _propsDictionary[property] = animatedObject;
         } else {
           _propsDictionary[property] = @(valueAnimatedNode.value);
diff --git a/packages/react-native/Libraries/NativeAnimation/Nodes/RCTTrackingAnimatedNode.mm b/packages/react-native/Libraries/NativeAnimation/Nodes/RCTTrackingAnimatedNode.mm
@@ -18,7 +18,7 @@ @implementation RCTTrackingAnimatedNode {
 
 - (instancetype)initWithTag:(NSNumber *)tag config:(NSDictionary<NSString *, id> *)config
 {
-  if ((self = [super initWithTag:tag config:config])) {
+  if ((self = [super initWithTag:tag config:config]) != nullptr) {
     _animationId = config[@"animationId"];
     _toValueNodeTag = config[@"toValue"];
     _valueNodeTag = config[@"value"];
diff --git a/packages/react-native/Libraries/NativeAnimation/Nodes/RCTTransformAnimatedNode.mm b/packages/react-native/Libraries/NativeAnimation/Nodes/RCTTransformAnimatedNode.mm
@@ -14,7 +14,7 @@ @implementation RCTTransformAnimatedNode {
 
 - (instancetype)initWithTag:(NSNumber *)tag config:(NSDictionary<NSString *, id> *)config
 {
-  if ((self = [super initWithTag:tag config:config])) {
+  if ((self = [super initWithTag:tag config:config]) != nullptr) {
     _propsDictionary = [NSMutableDictionary new];
   }
   return self;
diff --git a/packages/react-native/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.mm b/packages/react-native/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.mm
@@ -59,7 +59,7 @@ @implementation RCTNativeAnimatedNodesManager {
 - (instancetype)initWithBridge:(nullable RCTBridge *)bridge
               surfacePresenter:(id<RCTSurfacePresenterStub>)surfacePresenter
 {
-  if ((self = [super init])) {
+  if ((self = [super init]) != nullptr) {
     _bridge = bridge;
     _surfacePresenter = surfacePresenter;
     _animationNodes = [NSMutableDictionary new];
@@ -72,7 +72,7 @@ - (instancetype)initWithBridge:(nullable RCTBridge *)bridge
 - (BOOL)isNodeManagedByFabric:(NSNumber *)tag
 {
   RCTAnimatedNode *node = _animationNodes[tag];
-  if (node) {
+  if (node != nullptr) {
     return [node isManagedByFabric];
   }
   return false;
@@ -106,7 +106,7 @@ - (void)createAnimatedNode:(NSNumber *)tag config:(NSDictionary<NSString *, id>
   NSString *nodeType = [RCTConvert NSString:config[@"type"]];
 
   Class nodeClass = map[nodeType];
-  if (!nodeClass) {
+  if (nodeClass == nullptr) {
     RCTLogError(@"Animated node type %@ not supported natively", nodeType);
     return;
   }
@@ -187,7 +187,7 @@ - (void)restoreDefaultValues:(NSNumber *)nodeTag
 - (void)dropAnimatedNode:(NSNumber *)tag
 {
   RCTAnimatedNode *node = _animationNodes[tag];
-  if (node) {
+  if (node != nullptr) {
     [node detachNode];
     [_animationNodes removeObjectForKey:tag];
   }
@@ -345,7 +345,7 @@ - (void)addAnimatedEventToView:(NSNumber *)viewTag
   NSNumber *nodeTag = [RCTConvert NSNumber:eventMapping[@"animatedValueTag"]];
   RCTAnimatedNode *node = _animationNodes[nodeTag];
 
-  if (!node) {
+  if (node == nullptr) {
     RCTLogError(@"Animated node with tag %@ does not exist", nodeTag);
     return;
   }
@@ -407,7 +407,7 @@ - (void)handleAnimatedEvent:(id<RCTEvent>)event
 
   NSString *key = [NSString stringWithFormat:@"%@%@", event.viewTag, RCTNormalizeAnimatedEventName(event.eventName)];
   NSMutableArray<RCTEventAnimation *> *driversForKey = _eventDrivers[key];
-  if (driversForKey) {
+  if (driversForKey != nullptr) {
     for (RCTEventAnimation *driver in driversForKey) {
       [self stopAnimationsForNode:driver.valueNode];
       [driver updateWithEvent:event];
@@ -439,7 +439,7 @@ - (void)stopListeningToAnimatedNodeValue:(NSNumber *)tag
 
 - (void)startAnimationLoopIfNeeded
 {
-  if (!_displayLink && _activeAnimations.count > 0) {
+  if ((_displayLink == nullptr) && _activeAnimations.count > 0) {
     _displayLink = [CADisplayLink displayLinkWithTarget:self selector:@selector(stepAnimations:)];
     [_displayLink addToRunLoop:[NSRunLoop mainRunLoop] forMode:NSRunLoopCommonModes];
   }
@@ -454,7 +454,7 @@ - (void)stopAnimationLoopIfNeeded
 
 - (void)stopAnimationLoop
 {
-  if (_displayLink) {
+  if (_displayLink != nullptr) {
     [_displayLink invalidate];
     _displayLink = nil;
   }
@@ -486,7 +486,7 @@ - (void)stepAnimations:(CADisplayLink *)displaylink
   NSArray<RCTEventAnimation *> *eventAnimations = _eventDrivers[key];
   for (RCTEventAnimation *animation in eventAnimations) {
     NSNumber *nodeTag = [animation.valueNode nodeTag];
-    if (nodeTag) {
+    if (nodeTag != nullptr) {
       [tags addObject:nodeTag];
     }
     for (NSNumber *childNodeKey in [animation.valueNode childNodes]) {
diff --git a/packages/react-native/Libraries/Network/RCTDataRequestHandler.mm b/packages/react-native/Libraries/Network/RCTDataRequestHandler.mm
@@ -25,7 +25,7 @@ @implementation RCTDataRequestHandler {
 - (void)invalidate
 {
   std::lock_guard<std::mutex> lock(_operationHandlerMutexLock);
-  if (_queue) {
+  if (_queue != nullptr) {
     for (NSOperation *operation in _queue.operations) {
       if (!operation.isCancelled && !operation.isFinished) {
         [operation cancel];
@@ -44,7 +44,7 @@ - (NSOperation *)sendRequest:(NSURLRequest *)request withDelegate:(id<RCTURLRequ
 {
   std::lock_guard<std::mutex> lock(_operationHandlerMutexLock);
   // Lazy setup
-  if (!_queue) {
+  if (_queue == nullptr) {
     _queue = [NSOperationQueue new];
     _queue.maxConcurrentOperationCount = 2;
   }
@@ -59,7 +59,7 @@ - (NSOperation *)sendRequest:(NSURLRequest *)request withDelegate:(id<RCTURLRequ
     // Get mime type
     NSRange firstSemicolon = [request.URL.resourceSpecifier rangeOfString:@";"];
     NSString *mimeType =
-        firstSemicolon.length ? [request.URL.resourceSpecifier substringToIndex:firstSemicolon.location] : nil;
+        (firstSemicolon.length != 0u) ? [request.URL.resourceSpecifier substringToIndex:firstSemicolon.location] : nil;
 
     // Send response
     NSURLResponse *response = [[NSURLResponse alloc] initWithURL:request.URL
@@ -72,7 +72,7 @@ - (NSOperation *)sendRequest:(NSURLRequest *)request withDelegate:(id<RCTURLRequ
     // Load data
     NSError *error;
     NSData *data = [NSData dataWithContentsOfURL:request.URL options:NSDataReadingMappedIfSafe error:&error];
-    if (data) {
+    if (data != nullptr) {
       [delegate URLRequest:strongOp didReceiveData:data];
     }
     [delegate URLRequest:strongOp didCompleteWithError:error];
diff --git a/packages/react-native/Libraries/Network/RCTHTTPRequestHandler.mm b/packages/react-native/Libraries/Network/RCTHTTPRequestHandler.mm
@@ -46,7 +46,7 @@ - (void)invalidate
 - (BOOL)isValid
 {
   // if session == nil and delegates != nil, we've been invalidated
-  return _session || !_delegates;
+  return (_session != nullptr) || (_delegates == nullptr);
 }
 
 #pragma mark - NSURLRequestHandler
@@ -67,7 +67,7 @@ - (NSURLSessionDataTask *)sendRequest:(NSURLRequest *)request withDelegate:(id<R
 {
   std::lock_guard<std::mutex> lock(_mutex);
   // Lazy setup
-  if (!_session && [self isValid]) {
+  if ((_session == nullptr) && [self isValid]) {
     // You can override default NSURLSession instance property allowsCellularAccess (default value YES)
     //  by providing the following key to your RN project (edit ios/project/Info.plist file in Xcode):
     // <key>ReactNetworkForceWifiOnly</key>    <true/>
@@ -80,12 +80,12 @@ - (NSURLSessionDataTask *)sendRequest:(NSURLRequest *)request withDelegate:(id<R
     callbackQueue.maxConcurrentOperationCount = 1;
     callbackQueue.underlyingQueue = [[_moduleRegistry moduleForName:"Networking"] methodQueue];
     NSURLSessionConfiguration *configuration;
-    if (urlSessionConfigurationProvider) {
+    if (urlSessionConfigurationProvider != nullptr) {
       configuration = urlSessionConfigurationProvider();
     } else {
       configuration = [NSURLSessionConfiguration defaultSessionConfiguration];
       // Set allowsCellularAccess to NO ONLY if key ReactNetworkForceWifiOnly exists AND its value is YES
-      if (useWifiOnly) {
+      if (useWifiOnly != nullptr) {
         configuration.allowsCellularAccess = ![useWifiOnly boolValue];
       }
       [configuration setHTTPShouldSetCookies:YES];
diff --git a/packages/react-native/Libraries/Settings/RCTSettingsManager.mm b/packages/react-native/Libraries/Settings/RCTSettingsManager.mm
@@ -39,7 +39,7 @@ - (instancetype)init
 
 - (instancetype)initWithUserDefaults:(NSUserDefaults *)defaults
 {
-  if ((self = [super init])) {
+  if ((self = [super init]) != nullptr) {
     _defaults = defaults;
 
     [[NSNotificationCenter defaultCenter] addObserver:self
@@ -84,7 +84,7 @@ - (void)userDefaultsDidChange:(NSNotification *)note
   _ignoringUpdates = YES;
   [values enumerateKeysAndObjectsUsingBlock:^(NSString *key, id json, BOOL *stop) {
     id plist = [RCTConvert NSPropertyList:json];
-    if (plist) {
+    if (plist != nullptr) {
       [self->_defaults setObject:plist forKey:key];
     } else {
       [self->_defaults removeObjectForKey:key];

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ @implementation RCTAnimatedNode {`
`16`	`16`
`17`	`17`	`- (instancetype)initWithTag:(NSNumber )tag config:(NSDictionary<NSString , id> *)config`
`18`	`18`	`{`
`19`		`- if ((self = [super init])) {`
	`19`	`+ if ((self = [super init]) != nullptr) {`
`20`	`20`	`_nodeTag = tag;`
`21`	`21`	`_config = [config copy];`
`22`	`22`	`}`
`@@ -37,42 +37,42 @@ - (instancetype)initWithTag:(NSNumber )tag config:(NSDictionary<NSString , id>`
`37`	`37`
`38`	`38`	`- (void)addChild:(RCTAnimatedNode *)child`
`39`	`39`	`{`
`40`		`- if (!_childNodes) {`
	`40`	`+ if (_childNodes == nullptr) {`
`41`	`41`	`_childNodes = [NSMapTable strongToWeakObjectsMapTable];`
`42`	`42`	`}`
`43`		`- if (child) {`
	`43`	`+ if (child != nullptr) {`
`44`	`44`	`[_childNodes setObject:child forKey:child.nodeTag];`
`45`	`45`	`[child onAttachedToNode:self];`
`46`	`46`	`}`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`- (void)removeChild:(RCTAnimatedNode *)child`
`50`	`50`	`{`
`51`		`- if (!_childNodes) {`
	`51`	`+ if (_childNodes == nullptr) {`
`52`	`52`	`return;`
`53`	`53`	`}`
`54`		`- if (child) {`
	`54`	`+ if (child != nullptr) {`
`55`	`55`	`[_childNodes removeObjectForKey:child.nodeTag];`
`56`	`56`	`[child onDetachedFromNode:self];`
`57`	`57`	`}`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`- (void)onAttachedToNode:(RCTAnimatedNode *)parent`
`61`	`61`	`{`
`62`		`- if (!_parentNodes) {`
	`62`	`+ if (_parentNodes == nullptr) {`
`63`	`63`	`_parentNodes = [NSMapTable strongToWeakObjectsMapTable];`
`64`	`64`	`}`
`65`		`- if (parent) {`
	`65`	`+ if (parent != nullptr) {`
`66`	`66`	`[_parentNodes setObject:parent forKey:parent.nodeTag];`
`67`	`67`	`}`
`68`	`68`	`}`
`69`	`69`
`70`	`70`	`- (void)onDetachedFromNode:(RCTAnimatedNode *)parent`
`71`	`71`	`{`
`72`		`- if (!_parentNodes) {`
	`72`	`+ if (_parentNodes == nullptr) {`
`73`	`73`	`return;`
`74`	`74`	`}`
`75`		`- if (parent) {`
	`75`	`+ if (parent != nullptr) {`
`76`	`76`	`[_parentNodes removeObjectForKey:parent.nodeTag];`
`77`	`77`	`}`
`78`	`78`	`}`
Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ @implementation RCTInterpolationAnimatedNode {`
`86`	`86`
`87`	`87`	`- (instancetype)initWithTag:(NSNumber )tag config:(NSDictionary<NSString , id> *)config`
`88`	`88`	`{`
`89`		`- if ((self = [super initWithTag:tag config:config])) {`
	`89`	`+ if ((self = [super initWithTag:tag config:config]) != nullptr) {`
`90`	`90`	`_inputRange = config[@"inputRange"];`
`91`	`91`
`92`	`92`	`NSArray *outputRangeConfig = config[@"outputRange"];`
`@@ -104,7 +104,7 @@ - (instancetype)initWithTag:(NSNumber )tag config:(NSDictionary<NSString , id>`
`104`	`104`	`switch (_outputType) {`
`105`	`105`	`case RCTInterpolationOutputColor: {`
`106`	`106`	`UIColor *color = [RCTConvert UIColor:value];`
`107`		`- [outputRange addObject:color ? color : [UIColor whiteColor]];`
	`107`	`+ [outputRange addObject:(color != nullptr) ? color : [UIColor whiteColor]];`
`108`	`108`	`break;`
`109`	`109`	`}`
`110`	`110`	`case RCTInterpolationOutputString:`
`@@ -141,7 +141,7 @@ - (void)onDetachedFromNode:(RCTAnimatedNode *)parent`
`141`	`141`	`- (void)performUpdate`
`142`	`142`	`{`
`143`	`143`	`[super performUpdate];`
`144`		`- if (!_parentNode) {`
	`144`	`+ if (_parentNode == nullptr) {`
`145`	`145`	`return;`
`146`	`146`	`}`
`147`	`147`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ @implementation RCTTrackingAnimatedNode {`
`18`	`18`
`19`	`19`	`- (instancetype)initWithTag:(NSNumber )tag config:(NSDictionary<NSString , id> *)config`
`20`	`20`	`{`
`21`		`- if ((self = [super initWithTag:tag config:config])) {`
	`21`	`+ if ((self = [super initWithTag:tag config:config]) != nullptr) {`
`22`	`22`	`_animationId = config[@"animationId"];`
`23`	`23`	`_toValueNodeTag = config[@"toValue"];`
`24`	`24`	`_valueNodeTag = config[@"value"];`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ @implementation RCTTransformAnimatedNode {`
`14`	`14`
`15`	`15`	`- (instancetype)initWithTag:(NSNumber )tag config:(NSDictionary<NSString , id> *)config`
`16`	`16`	`{`
`17`		`- if ((self = [super initWithTag:tag config:config])) {`
	`17`	`+ if ((self = [super initWithTag:tag config:config]) != nullptr) {`
`18`	`18`	`_propsDictionary = [NSMutableDictionary new];`
`19`	`19`	`}`
`20`	`20`	`return self;`