Remove dead RAMBundleRegistry::multipleBundlesRegistry static factory

sammy-SC · meta-codesync[bot] · commit bc7c757e9de9 · 2026-06-10T09:17:52.000-07:00
Summary: X-link: #57137 `RAMBundleRegistry::multipleBundlesRegistry` was a static factory wrapping the public `RAMBundleRegistry` constructor (the one taking a main bundle plus a factory callback), but it had no callers anywhere. Registries are constructed via the public constructor directly. With the sibling `singleBundleRegistry` already removed, this deletes the last orphaned static factory; the constructor and the rest of the class remain intact. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D108012906 fbshipit-source-id: 7bb403ff7660317f0f5b422dca140ac69e048dac
diff --git a/packages/react-native/ReactCommon/cxxreact/RAMBundleRegistry.cpp b/packages/react-native/ReactCommon/cxxreact/RAMBundleRegistry.cpp
@@ -20,13 +20,6 @@ namespace facebook::react {
 constexpr uint32_t RAMBundleRegistry::MAIN_BUNDLE_ID;
 #pragma clang diagnostic pop
 
-std::unique_ptr<RAMBundleRegistry> RAMBundleRegistry::multipleBundlesRegistry(
-    std::unique_ptr<JSModulesUnbundle> mainBundle,
-    std::function<std::unique_ptr<JSModulesUnbundle>(std::string)> factory) {
-  return std::make_unique<RAMBundleRegistry>(
-      std::move(mainBundle), std::move(factory));
-}
-
 RAMBundleRegistry::RAMBundleRegistry(
     std::unique_ptr<JSModulesUnbundle> mainBundle,
     std::function<std::unique_ptr<JSModulesUnbundle>(std::string)> factory)
diff --git a/packages/react-native/ReactCommon/cxxreact/RAMBundleRegistry.h b/packages/react-native/ReactCommon/cxxreact/RAMBundleRegistry.h
@@ -27,10 +27,6 @@ class RN_EXPORT [[deprecated("This API will be removed along with the legacy arc
  public:
   constexpr static uint32_t MAIN_BUNDLE_ID = 0;
 
-  static std::unique_ptr<RAMBundleRegistry> multipleBundlesRegistry(
-      std::unique_ptr<JSModulesUnbundle> mainBundle,
-      std::function<std::unique_ptr<JSModulesUnbundle>(std::string)> factory);
-
   explicit RAMBundleRegistry(
       std::unique_ptr<JSModulesUnbundle> mainBundle,
       std::function<std::unique_ptr<JSModulesUnbundle>(std::string)> factory = nullptr);
diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api
@@ -4179,7 +4179,6 @@ class facebook::react::RAMBundleRegistry {
   public facebook::react::JSModulesUnbundle::Module getModule(uint32_t bundleId, uint32_t moduleId);
   public facebook::react::RAMBundleRegistry& operator=(facebook::react::RAMBundleRegistry&&) = default;
   public static constexpr uint32_t MAIN_BUNDLE_ID;
-  public static std::unique_ptr<facebook::react::RAMBundleRegistry> multipleBundlesRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle, std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> factory);
   public virtual ~RAMBundleRegistry() = default;
   public void registerBundle(uint32_t bundleId, std::string bundlePath);
 }
diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api
@@ -4176,7 +4176,6 @@ class facebook::react::RAMBundleRegistry {
   public facebook::react::JSModulesUnbundle::Module getModule(uint32_t bundleId, uint32_t moduleId);
   public facebook::react::RAMBundleRegistry& operator=(facebook::react::RAMBundleRegistry&&) = default;
   public static constexpr uint32_t MAIN_BUNDLE_ID;
-  public static std::unique_ptr<facebook::react::RAMBundleRegistry> multipleBundlesRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle, std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> factory);
   public virtual ~RAMBundleRegistry() = default;
   public void registerBundle(uint32_t bundleId, std::string bundlePath);
 }
diff --git a/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api
@@ -6360,7 +6360,6 @@ class facebook::react::RAMBundleRegistry {
   public facebook::react::JSModulesUnbundle::Module getModule(uint32_t bundleId, uint32_t moduleId);
   public facebook::react::RAMBundleRegistry& operator=(facebook::react::RAMBundleRegistry&&) = default;
   public static constexpr uint32_t MAIN_BUNDLE_ID;
-  public static std::unique_ptr<facebook::react::RAMBundleRegistry> multipleBundlesRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle, std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> factory);
   public virtual ~RAMBundleRegistry() = default;
   public void registerBundle(uint32_t bundleId, std::string bundlePath);
 }
diff --git a/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api
@@ -6357,7 +6357,6 @@ class facebook::react::RAMBundleRegistry {
   public facebook::react::JSModulesUnbundle::Module getModule(uint32_t bundleId, uint32_t moduleId);
   public facebook::react::RAMBundleRegistry& operator=(facebook::react::RAMBundleRegistry&&) = default;
   public static constexpr uint32_t MAIN_BUNDLE_ID;
-  public static std::unique_ptr<facebook::react::RAMBundleRegistry> multipleBundlesRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle, std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> factory);
   public virtual ~RAMBundleRegistry() = default;
   public void registerBundle(uint32_t bundleId, std::string bundlePath);
 }
diff --git a/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api
@@ -2760,7 +2760,6 @@ class facebook::react::RAMBundleRegistry {
   public facebook::react::JSModulesUnbundle::Module getModule(uint32_t bundleId, uint32_t moduleId);
   public facebook::react::RAMBundleRegistry& operator=(facebook::react::RAMBundleRegistry&&) = default;
   public static constexpr uint32_t MAIN_BUNDLE_ID;
-  public static std::unique_ptr<facebook::react::RAMBundleRegistry> multipleBundlesRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle, std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> factory);
   public virtual ~RAMBundleRegistry() = default;
   public void registerBundle(uint32_t bundleId, std::string bundlePath);
 }
diff --git a/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api
@@ -2757,7 +2757,6 @@ class facebook::react::RAMBundleRegistry {
   public facebook::react::JSModulesUnbundle::Module getModule(uint32_t bundleId, uint32_t moduleId);
   public facebook::react::RAMBundleRegistry& operator=(facebook::react::RAMBundleRegistry&&) = default;
   public static constexpr uint32_t MAIN_BUNDLE_ID;
-  public static std::unique_ptr<facebook::react::RAMBundleRegistry> multipleBundlesRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle, std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> factory);
   public virtual ~RAMBundleRegistry() = default;
   public void registerBundle(uint32_t bundleId, std::string bundlePath);
 }

Original file line number	Diff line number	Diff line change
`@@ -4179,7 +4179,6 @@ class facebook::react::RAMBundleRegistry {`
`4179`	`4179`	`public facebook::react::JSModulesUnbundle::Module getModule(uint32_t bundleId, uint32_t moduleId);`
`4180`	`4180`	`public facebook::react::RAMBundleRegistry& operator=(facebook::react::RAMBundleRegistry&&) = default;`
`4181`	`4181`	`public static constexpr uint32_t MAIN_BUNDLE_ID;`
`4182`		`- public static std::unique_ptr<facebook::react::RAMBundleRegistry> multipleBundlesRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle, std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> factory);`
`4183`	`4182`	`public virtual ~RAMBundleRegistry() = default;`
`4184`	`4183`	`public void registerBundle(uint32_t bundleId, std::string bundlePath);`
`4185`	`4184`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4176,7 +4176,6 @@ class facebook::react::RAMBundleRegistry {`
`4176`	`4176`	`public facebook::react::JSModulesUnbundle::Module getModule(uint32_t bundleId, uint32_t moduleId);`
`4177`	`4177`	`public facebook::react::RAMBundleRegistry& operator=(facebook::react::RAMBundleRegistry&&) = default;`
`4178`	`4178`	`public static constexpr uint32_t MAIN_BUNDLE_ID;`
`4179`		`- public static std::unique_ptr<facebook::react::RAMBundleRegistry> multipleBundlesRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle, std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> factory);`
`4180`	`4179`	`public virtual ~RAMBundleRegistry() = default;`
`4181`	`4180`	`public void registerBundle(uint32_t bundleId, std::string bundlePath);`
`4182`	`4181`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6360,7 +6360,6 @@ class facebook::react::RAMBundleRegistry {`
`6360`	`6360`	`public facebook::react::JSModulesUnbundle::Module getModule(uint32_t bundleId, uint32_t moduleId);`
`6361`	`6361`	`public facebook::react::RAMBundleRegistry& operator=(facebook::react::RAMBundleRegistry&&) = default;`
`6362`	`6362`	`public static constexpr uint32_t MAIN_BUNDLE_ID;`
`6363`		`- public static std::unique_ptr<facebook::react::RAMBundleRegistry> multipleBundlesRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle, std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> factory);`
`6364`	`6363`	`public virtual ~RAMBundleRegistry() = default;`
`6365`	`6364`	`public void registerBundle(uint32_t bundleId, std::string bundlePath);`
`6366`	`6365`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6357,7 +6357,6 @@ class facebook::react::RAMBundleRegistry {`
`6357`	`6357`	`public facebook::react::JSModulesUnbundle::Module getModule(uint32_t bundleId, uint32_t moduleId);`
`6358`	`6358`	`public facebook::react::RAMBundleRegistry& operator=(facebook::react::RAMBundleRegistry&&) = default;`
`6359`	`6359`	`public static constexpr uint32_t MAIN_BUNDLE_ID;`
`6360`		`- public static std::unique_ptr<facebook::react::RAMBundleRegistry> multipleBundlesRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle, std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> factory);`
`6361`	`6360`	`public virtual ~RAMBundleRegistry() = default;`
`6362`	`6361`	`public void registerBundle(uint32_t bundleId, std::string bundlePath);`
`6363`	`6362`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2760,7 +2760,6 @@ class facebook::react::RAMBundleRegistry {`
`2760`	`2760`	`public facebook::react::JSModulesUnbundle::Module getModule(uint32_t bundleId, uint32_t moduleId);`
`2761`	`2761`	`public facebook::react::RAMBundleRegistry& operator=(facebook::react::RAMBundleRegistry&&) = default;`
`2762`	`2762`	`public static constexpr uint32_t MAIN_BUNDLE_ID;`
`2763`		`- public static std::unique_ptr<facebook::react::RAMBundleRegistry> multipleBundlesRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle, std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> factory);`
`2764`	`2763`	`public virtual ~RAMBundleRegistry() = default;`
`2765`	`2764`	`public void registerBundle(uint32_t bundleId, std::string bundlePath);`
`2766`	`2765`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2757,7 +2757,6 @@ class facebook::react::RAMBundleRegistry {`
`2757`	`2757`	`public facebook::react::JSModulesUnbundle::Module getModule(uint32_t bundleId, uint32_t moduleId);`
`2758`	`2758`	`public facebook::react::RAMBundleRegistry& operator=(facebook::react::RAMBundleRegistry&&) = default;`
`2759`	`2759`	`public static constexpr uint32_t MAIN_BUNDLE_ID;`
`2760`		`- public static std::unique_ptr<facebook::react::RAMBundleRegistry> multipleBundlesRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle, std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> factory);`
`2761`	`2760`	`public virtual ~RAMBundleRegistry() = default;`
`2762`	`2761`	`public void registerBundle(uint32_t bundleId, std::string bundlePath);`
`2763`	`2762`	`}`