Skip to content

Commit c007bcd

Browse files
rubennortefacebook-github-bot
authored andcommitted
Make useConcurrentRoot always true in renderElement
Summary: Changelog: [Internal] All apps have migrated to concurrent root (as they're using Fabric), so the `useConcurrentRoot` parameter is no longer needed. This removes `useConcurrentRoot` (and `useFabric`) from `renderElement` in `RendererImplementation` and the profiling variant, hardcoding the underlying call to `true`, and stops passing them from `renderApplication`. Differential Revision: D101981133
1 parent 6005ab8 commit c007bcd

2 files changed

Lines changed: 1 addition & 7 deletions

File tree

packages/react-native/Libraries/ReactNative/RendererImplementation.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -57,19 +57,15 @@ let cachedFabricRender;
5757
export function renderElement({
5858
element,
5959
rootTag,
60-
useFabric,
61-
useConcurrentRoot,
6260
}: {
6361
element: React.MixedElement,
6462
rootTag: number,
65-
useFabric: boolean,
66-
useConcurrentRoot: boolean,
6763
}): void {
6864
if (cachedFabricRender == null) {
6965
cachedFabricRender = getFabricRenderer().render;
7066
}
7167

72-
cachedFabricRender(element, rootTag, null, useConcurrentRoot, {
68+
cachedFabricRender(element, rootTag, null, true, {
7369
onCaughtError,
7470
onUncaughtError,
7571
onRecoverableError,

packages/react-native/Libraries/ReactNative/renderApplication.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,8 +97,6 @@ export default function renderApplication<Props extends Object>(
9797
Renderer.renderElement({
9898
element: renderable,
9999
rootTag,
100-
useFabric: true,
101-
useConcurrentRoot: true,
102100
});
103101
performanceLogger.stopTimespan('renderApplication_React_render');
104102
}

0 commit comments

Comments
 (0)