Commit e0a6801
Schedule React revision merge to happen before dispatching events
Summary:
Changelog: [ANDROID][FIXED] Schedule React revision merge to happen on `DISPATCH_UI` choreographer queue, before dispatching events
Before the introduction of branching, it was possible to handle synchronous events on the same frame they were dispatched. Branching broke that in two ways:
1. Merge was always scheduled on the end of the event loop (addressed by the previous diff)
2. Merge was scheduled using `runOnUIThread`, which turned out to be after the `DISPATCH_UI` choreographer phase, thus after the dispatch of events.
Differential Revision: D1009666231 parent 3a019fe commit e0a6801
1 file changed
Lines changed: 21 additions & 7 deletions
File tree
- packages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric
Lines changed: 21 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
| 104 | + | |
104 | 105 | | |
105 | 106 | | |
106 | 107 | | |
| |||
192 | 193 | | |
193 | 194 | | |
194 | 195 | | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
195 | 203 | | |
196 | 204 | | |
197 | 205 | | |
| |||
956 | 964 | | |
957 | 965 | | |
958 | 966 | | |
959 | | - | |
960 | | - | |
961 | | - | |
962 | | - | |
963 | | - | |
964 | | - | |
965 | | - | |
| 967 | + | |
966 | 968 | | |
967 | 969 | | |
968 | 970 | | |
| |||
1558 | 1560 | | |
1559 | 1561 | | |
1560 | 1562 | | |
| 1563 | + | |
| 1564 | + | |
| 1565 | + | |
| 1566 | + | |
| 1567 | + | |
| 1568 | + | |
| 1569 | + | |
| 1570 | + | |
| 1571 | + | |
| 1572 | + | |
| 1573 | + | |
| 1574 | + | |
1561 | 1575 | | |
1562 | 1576 | | |
1563 | 1577 | | |
| |||
0 commit comments