Commit e0d34b2
Fix visibility of DevSupportHttpClient by extracting DevSupportRequestHeaders (#55739)
Summary:
Pull Request resolved: #55739
Extract header management from the `internal` `DevSupportHttpClient` into a new
public `DevSupportRequestHeaders` singleton in `devsupport.interfaces`. This
allows external consumers (e.g. Expo Dev Launcher) to register custom HTTP
headers that will be applied to all React Native dev-support network traffic
without depending on internal APIs.
`DevSupportHttpClient` now delegates to `DevSupportRequestHeaders.allHeaders()`
instead of maintaining its own `ConcurrentHashMap`.
A separate `request_headers` Buck target is introduced to avoid a dependency
cycle (`bridge` → `inspector` → `interfaces` → `bridge`).
Changelog: [Android][Added] - Public DevSupportRequestHeaders API for registering custom dev-support HTTP headers
Reviewed By: cipolleschi
Differential Revision: D94354168
fbshipit-source-id: 72aa65b615fe4ef43feaab10ffea7526589a76fd1 parent 0ce2790 commit e0d34b2
3 files changed
Lines changed: 58 additions & 18 deletions
File tree
- packages/react-native/ReactAndroid
- api
- src/main/java/com/facebook/react/devsupport
- inspector
- interfaces
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2184 | 2184 | | |
2185 | 2185 | | |
2186 | 2186 | | |
| 2187 | + | |
| 2188 | + | |
| 2189 | + | |
| 2190 | + | |
| 2191 | + | |
| 2192 | + | |
| 2193 | + | |
2187 | 2194 | | |
2188 | 2195 | | |
2189 | 2196 | | |
| |||
Lines changed: 13 additions & 18 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
| 19 | + | |
| 20 | + | |
20 | 21 | | |
21 | 22 | | |
22 | | - | |
23 | | - | |
24 | 23 | | |
25 | | - | |
26 | | - | |
27 | | - | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
28 | 34 | | |
29 | | - | |
30 | 35 | | |
31 | 36 | | |
32 | 37 | | |
| |||
45 | 50 | | |
46 | 51 | | |
47 | 52 | | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | 53 | | |
Lines changed: 38 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
0 commit comments