Skip to content

Commit f2c9d74

Browse files
cipolleschifacebook-github-bot
authored andcommitted
Remove continue-on-error from e2e test in GHA (#51746)
Summary: Pull Request resolved: #51746 I observed that when continue-on-error is set to true, Github reports the outcome of a job as success even if it fails. With this change, we should ensure that when an E2E test fails, the pipeline fails, so that we can retry the jobs properly. ## Changelog: [Internal] - Remove continue-on-error from e2e tests in GHA Reviewed By: cortinico Differential Revision: D75796284 fbshipit-source-id: 0e769f53d7355ae6c985aace334b23205780673a
1 parent fedc7f2 commit f2c9d74

1 file changed

Lines changed: 0 additions & 3 deletions

File tree

.github/workflows/test-all.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,6 @@ jobs:
194194
env:
195195
HERMES_WS_DIR: /tmp/hermes
196196
HERMES_TARBALL_ARTIFACTS_DIR: /tmp/hermes/hermes-runtime-darwin
197-
continue-on-error: true
198197
strategy:
199198
fail-fast: false
200199
matrix:
@@ -227,7 +226,6 @@ jobs:
227226
env:
228227
HERMES_WS_DIR: /tmp/hermes
229228
HERMES_TARBALL_ARTIFACTS_DIR: /tmp/hermes/hermes-runtime-darwin
230-
continue-on-error: true
231229
strategy:
232230
fail-fast: false
233231
matrix:
@@ -315,7 +313,6 @@ jobs:
315313
if: ${{ github.ref == 'refs/heads/main' || contains(github.ref, 'stable') || inputs.run-e2e-tests }}
316314
runs-on: 4-core-ubuntu
317315
needs: build_npm_package
318-
continue-on-error: true
319316
strategy:
320317
fail-fast: false
321318
matrix:

0 commit comments

Comments
 (0)