Simplify PerformanceTracer API and move processing to TracingAgent#52934
Closed
rubennorte wants to merge 2 commits into
Closed
Simplify PerformanceTracer API and move processing to TracingAgent#52934rubennorte wants to merge 2 commits into
rubennorte wants to merge 2 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79271690 |
rubennorte
force-pushed
the
export-D79271690
branch
from
2e7656e to
3c3897c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79271690 |
Differential Revision: D79271691
rubennorte
force-pushed
the
export-D79271690
branch
from
3c3897c to
860c1d2
Compare
…52934) Summary: Pull Request resolved: #52934 Changelog: [internal] Right now, the `PerformanceTracer` API has a method to stop the trace and a separate one to collect serialized events. This refactors the API to return the collected events when calling `stopTracing` instead. The caller (in this case `TracingAgent`) is responsible for serializing and sending the events in chunks through CDP. Reviewed By: hoxyq Differential Revision: D79271690
rubennorte
force-pushed
the
export-D79271690
branch
from
860c1d2 to
fcf4c9c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79271690 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79271690 |
rubennorte
force-pushed
the
export-D79271690
branch
from
fcf4c9c to
3bb7195
Compare
Contributor
|
This pull request has been merged in 9f6440d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
Right now, the
PerformanceTracerAPI has a method to stop the trace and a separate one to collect serialized events. This refactors the API to return the collected events when callingstopTracinginstead.The caller (in this case
TracingAgent) is responsible for serializing and sending the events in chunks through CDP.Differential Revision: D79271690