Log synthetic events for trace start/end when the trace finishes#52937
Closed
rubennorte wants to merge 3 commits into
Closed
Log synthetic events for trace start/end when the trace finishes#52937rubennorte wants to merge 3 commits into
rubennorte wants to merge 3 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79271692 |
rubennorte
force-pushed
the
export-D79271692
branch
from
aef6d5d to
65579ef
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79271692 |
Differential Revision: D79271691
Differential Revision: D79271690
rubennorte
force-pushed
the
export-D79271692
branch
from
65579ef to
71d95f8
Compare
) Summary: Pull Request resolved: #52937 Changelog: [internal] Minor refactor to log the synthetic events for trace start when the trace finishes. This is to simplify future work to implement a sliding window for trace events. Reviewed By: hoxyq Differential Revision: D79271692
rubennorte
force-pushed
the
export-D79271692
branch
from
71d95f8 to
9aff376
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79271692 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79271692 |
rubennorte
force-pushed
the
export-D79271692
branch
from
9aff376 to
d0bf93e
Compare
Contributor
|
This pull request has been merged in 00debea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
Minor refactor to log the synthetic events for trace start when the trace finishes. This is to simplify future work to implement a sliding window for trace events.
Differential Revision: D79271692